Groups > linux.debian.maint.python > #14550

Re: Review of Debian package lazy-loader

Path	csiph.com!news.samoylyk.net!usenet.goja.nl.eu.org!aioe.org!bofh.it!news.nic.it!robomod
From	Bo YU <tsu.yubo@gmail.com>
Newsgroups	linux.debian.maint.python
Subject	Re: Review of Debian package lazy-loader
Date	Sat, 22 Oct 2022 14:10:01 +0200
Message-ID	<Fjlu9-fWP3-9@gated-at.bofh.it> (permalink)
References	<Fje9j-fSei-3@gated-at.bofh.it>
X-Original-To	Louis-Philippe Véronneau <pollo@riseup.net>
X-Mailbox-Line	From debian-python-request@lists.debian.org Sat Oct 22 12:06:38 2022
Old-Return-Path	<tsu.yubo@gmail.com>
X-Amavis-Spam-Status	No, score=-12.199 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=ham autolearn_force=no
X-Policyd-Weight	NOT_IN_SBL_XBL_SPAMHAUS=-1.5 CL_IP_EQ_HELO_IP=-2 (check from: .gmail. - helo: .mail-pg1-x52f.google. - helo-domain: .google.) FROM/MX_MATCHES_HELO(DOMAIN)=-2; rate: -5.5
X-Gm-Message-State	ACrzQf2rBF+ijhv/MS47MeI7WAAZehKU4F+x93k5I4tE/1vweBcQrT7d HFFSBy7SDayqmuY/iGzSZys=
X-Google-SMTP-Source	AMsMyM5hBdqoyTSnUc3NlvGbjV6yd+/Vi/lHLMa2sXDVnrnvwQQfnmY7kOBPRh9cLYKSt++HwQP7WA==
X-Received	by 2002:a05:6a00:1145:b0:52b:78c:fa26 with SMTP id b5-20020a056a00114500b0052b078cfa26mr24100381pfm.27.1666440376693; Sat, 22 Oct 2022 05:06:16 -0700 (PDT)
X-PGP-Key	https://github.com/yuzibo/yuzibo.github.io/blob/master/_includes/subkey-signing-06-18-143E4BAF-pub.asc
MIME-Version	1.0
Content-Type	multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="aohd57xade4ho7k2"
Content-Disposition	inline
X-Mailing-List	<debian-python@lists.debian.org> archive/latest/20401
List-ID	<debian-python.lists.debian.org>
List-URL	<https://lists.debian.org/debian-python/>
List-Archive	https://lists.debian.org/msgid-search/20221022120612.tr2kjcxefguh7phc@debian
Approved	robomod@news.nic.it
Lines	93
Organization	linux.* mail to news gateway
Sender	robomod@news.nic.it
X-Original-Cc	debian-python <debian-python@lists.debian.org>
X-Original-Date	Sat, 22 Oct 2022 20:06:12 +0800
X-Original-Message-ID	<20221022120612.tr2kjcxefguh7phc@debian>
X-Original-References	<ae54df73-e021-c715-90bf-43faa34f80c7@riseup.net>
Xref	csiph.com linux.debian.maint.python:14550

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,
On Fri, Oct 21, 2022 at 11:58:38PM -0400, Louis-Philippe Véronneau wrote:
>Hello,
>
>This is my review of the lazy-loader package you asked the Debian 
>Python Team to sponsor in the Debian archive.
>
>1. In d/control, I'm not sure to understand why the binary package is 
>marked as "Multi-Arch: foreign", as this package isn't arch dependent?

The binary package is arch dependent as it was marked as "Architecture: all"
I think. There is more knowledge for me to here:
https://wiki.debian.org/MultiArch/Hints#set_Multi-Arch:_foreign

Fixed it.

>
>

[...]
>You should instead run the upstream test suite as autopkgtests: they 
>are much more meaningful.
>
>Have a look at this example:
>
>https://salsa.debian.org/python-team/packages/metalfinder/-/tree/debian/master/debian/tests
>

Ok, The package now is updated according to the all above review comments.

>6. In d/changelog, you marked your entry as "unstable", whereas it 
>should be UNRELEASED. Please re-read the DPT's policy with regards to 
>this.

Ok, this is different entry with previous package that has been
sponsored by others DD. But I think 'UNRELEASED' entry is right:)
>
>7. Although I have not listed them here, pretty much all of the 
>lintian tags raised are relevant errors that you should fix.

Yeah, I run lintian the package this time and it got nothing from my
chroot build. The only error from mentor is:
```
Package uploaded for the UNRELEASED distribution
````
I think it should be ok this time.

>
>----------------------------------
>
>You're 90% there!
>
>I've removed your package from the sponsor queue for now, but feel 
>free to re-add it when you feel like you've dealt with my review. I'll 
>be happy to sponsor it then.

Thanks you very much! I have updated it from your valueable review.
Please let me know if there is any issues.

-- 
Regards,
--
   Bo YU

Back to linux.debian.maint.python | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Review of Debian package lazy-loader Louis-Philippe Véronneau <pollo@riseup.net> - 2022-10-22 06:20 +0200
  Re: Review of Debian package lazy-loader Bo YU <tsu.yubo@gmail.com> - 2022-10-22 14:10 +0200

csiph-web