Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.debian.maint.python > #14511

Re: review for python-ssdpy

Path csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From Ben Westover <kwestover.kw@gmail.com>
Newsgroups linux.debian.maint.python
Subject Re: review for python-ssdpy
Date Mon, 03 Oct 2022 18:00:02 +0200
Message-ID <Fcw1k-bNH3-3@gated-at.bofh.it> (permalink)
References <FcsAp-bLQN-7@gated-at.bofh.it>
X-Mailbox-Line From debian-python-request@lists.debian.org Mon Oct 3 15:56:59 2022
Old-Return-Path <kwestover.kw@gmail.com>
X-Amavis-Spam-Status No, score=-14.942 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, LDO_WHITELIST=-5, NICE_REPLY_A=-2.743, PGPSIGNATURE=-5, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=ham autolearn_force=no
X-Policyd-Weight NOT_IN_SBL_XBL_SPAMHAUS=-1.5 CL_IP_EQ_HELO_IP=-2 (check from: .gmail. - helo: .mail-qv1-xf2d.google. - helo-domain: .google.) FROM/MX_MATCHES_HELO(DOMAIN)=-2; rate: -5.5
X-Gm-Message-State ACrzQf2bIaShF9mY6EqqeK1mzTAWS/qSFtW4iNL4chuRvHpIGORKtA2r 8bXqflp8s2r6bDrGMgwO2xQJZqyKWrk=
X-Google-SMTP-Source AMsMyM7stK62BAg1POquDiFBecD27hXmcSKKrD16ZQkseQa35hugVKeTXKrdqNMfnxcsn26Ldfwd4g==
X-Received by 2002:a0c:f2d0:0:b0:4b1:71ad:f57d with SMTP id c16-20020a0cf2d0000000b004b171adf57dmr10692738qvm.109.1664812594009; Mon, 03 Oct 2022 08:56:34 -0700 (PDT)
MIME-Version 1.0
User-Agent Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1
Content-Language en-US
Content-Type multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------LUqFeEMmu0qv9NrVTqUSNdVx"
X-Mailing-List <debian-python@lists.debian.org> archive/latest/20360
List-ID <debian-python.lists.debian.org>
List-URL <https://lists.debian.org/debian-python/>
List-Archive https://lists.debian.org/msgid-search/69abf477-f9a3-5e52-5041-bb02ed1f79c8@gmail.com
Approved robomod@news.nic.it
Lines 59
Organization linux.* mail to news gateway
Sender robomod@news.nic.it
X-Original-Cc debian-python@lists.debian.org
X-Original-Date Mon, 3 Oct 2022 11:56:30 -0400
X-Original-Message-ID <69abf477-f9a3-5e52-5041-bb02ed1f79c8@gmail.com>
X-Original-References <20221003141248.611a4004@debian.org>
Xref csiph.com linux.debian.maint.python:14511

Show key headers only | View raw


[Multipart message — attachments visible in raw view] - view raw

Hello,

On 10/3/22 08:12, Jeroen Ploemen wrote:
> * control: missing build-dep on python3-all? Needed to run the
>    testsuite against all supported Python version rather than just the
>    default one.

Thanks, added.

> * watch: regex "(\d\.\d.\d)" is overly specific, could easily miss
>    upstream versions such as a hypothetical "1.5" or "1.4.10".

Fixed.

> Package ftbfs in pbuilder with errors in the testsuite; many of the
> failing tests are marked by upstream as incompatible with github ci,
> probably for similar reasons they fail in pbuilder, particularly
> assumptions regarding the availability and configuration of the
> network.
> 
> See log at https://paste.debian.net/hidden/daadfbea/

Thanks, I didn't catch that since I use sbuild instead of pbuilder. I 
have set the environment variable CI = true which should disable those 
tests. This and above fixes are pushed to Salsa.

--
Ben Westover

Back to linux.debian.maint.python | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

review for python-ssdpy Jeroen Ploemen <jcfp@debian.org> - 2022-10-03 14:20 +0200
  Re: review for python-ssdpy Ben Westover <kwestover.kw@gmail.com> - 2022-10-03 18:00 +0200
    Re: review for python-ssdpy Jeroen Ploemen <jcfp@debian.org> - 2022-10-04 15:00 +0200
      Re: review for python-ssdpy Ben Westover <kwestover.kw@gmail.com> - 2022-10-04 18:50 +0200

csiph-web