Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.debian.maint.python > #14513

Re: review for python-ssdpy

From Jeroen Ploemen <jcfp@debian.org>
Newsgroups linux.debian.maint.python
Subject Re: review for python-ssdpy
Date 2022-10-04 15:00 +0200
Message-ID <FcPGF-bZyc-19@gated-at.bofh.it> (permalink)
References <FcsAp-bLQN-7@gated-at.bofh.it> <Fcw1k-bNH3-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Mon, 3 Oct 2022 11:56:30 -0400
Ben Westover <kwestover.kw@gmail.com> wrote:

> Thanks, I didn't catch that since I use sbuild instead of pbuilder.
> I have set the environment variable CI = true which should disable
> those tests.

Unfortunately, it doesn't.

The change suggested below does make 'CI=true' take effect, but that
still leaves a few failing tests not marked by upstream. Probably
easiest to exclude those remaining troublemakers by instructing
pybuild to set a pytest option, e.g. PYBUILD_TEST_ARGS = -k 'not ...'.

--- a/debian/rules
+++ b/debian/rules
@@ -1,7 +1,6 @@
 #! /usr/bin/make -f
 
 export PYBUILD_NAME = ssdpy
-export CI = "true" # Skip tests which require network
 
 %:
        dh $@ --with python3,sphinxdoc --buildsystem=pybuild
@@ -11,3 +10,7 @@ execute_after_dh_auto_build:
 
 execute_after_dh_auto_clean:
        rm -rf debian/html
+
+override_dh_auto_test:
+       # Skip tests which require network
+       CI=true dh_auto_test

Back to linux.debian.maint.python | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

review for python-ssdpy Jeroen Ploemen <jcfp@debian.org> - 2022-10-03 14:20 +0200
  Re: review for python-ssdpy Ben Westover <kwestover.kw@gmail.com> - 2022-10-03 18:00 +0200
    Re: review for python-ssdpy Jeroen Ploemen <jcfp@debian.org> - 2022-10-04 15:00 +0200
      Re: review for python-ssdpy Ben Westover <kwestover.kw@gmail.com> - 2022-10-04 18:50 +0200

csiph-web