Groups > linux.debian.maint.python > #14710

review for pygubu/0.27-1

Path	csiph.com!pasdenom.info!aioe.org!bofh.it!news.nic.it!robomod
From	Jeroen Ploemen <jcfp@debian.org>
Newsgroups	linux.debian.maint.python
Subject	review for pygubu/0.27-1
Date	Sat, 10 Dec 2022 11:20:01 +0100
Message-ID	<FB57z-9G8V-3@gated-at.bofh.it> (permalink)
X-Original-To	tsu.yubo@gmail.com
X-Mailbox-Line	From debian-python-request@lists.debian.org Sat Dec 10 10:18:13 2022
Old-Return-Path	<jcfp@debian.org>
X-Amavis-Spam-Status	No, score=-114.024 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DIGITS_LETTERS=1, DKIMWL_WL_HIGH=-0.515, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_MED=-2.3, UNPARSEABLE_RELAY=0.001, USER_IN_DKIM_WELCOMELIST=-0.01, USER_IN_DKIM_WHITELIST=-100] autolearn=ham autolearn_force=no
X-Mailer	Claws Mail 4.1.1 (GTK 3.24.20; x86_64-pc-linux-gnu)
MIME-Version	1.0
Content-Type	multipart/signed; boundary="Sig_/PMKt/Gp9pEf0IwTyckeVNfJ"; protocol="application/pgp-signature"; micalg=pgp-sha512
X-Debian-User	jcfp
X-Mailing-List	<debian-python@lists.debian.org> archive/latest/20576
List-ID	<debian-python.lists.debian.org>
List-URL	<https://lists.debian.org/debian-python/>
List-Archive	https://lists.debian.org/msgid-search/20221210111717.1e46a2c6@debian.org
Approved	robomod@news.nic.it
Lines	74
Organization	linux.* mail to news gateway
Sender	robomod@news.nic.it
X-Original-Cc	debian-python@lists.debian.org
X-Original-Date	Sat, 10 Dec 2022 11:17:17 +0100
X-Original-Message-ID	<20221210111717.1e46a2c6@debian.org>
Xref	csiph.com linux.debian.maint.python:14710

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

hi Bo,

my comments for the pygubu package up for sponsorship in the Python
team:

* changelog: only a single entry is needed for an initial debian
  release.

* copyright:
  + please remove the copyright statement at the start of the MIT
    license paragraph so that it contains only the license terms;
  + tests/support.py appears to be based on [1] (i.e. from upstream
    python, license info at [2])?

* control:
  + do you need python3-tk for any other purpose than running tests?
    If not, mark as !nocheck;
  + "Description: Debian packaging for pygubu": you want to describe
    pygubu itself here, not that it's packaged for Debian - every
    package in the distribution is, after all.

* rules: the script at development/runtests.sh simply calls "python3
  -m unittest" on the tests dir for the default python3 only, which
  is not what you want. Consider letting pybuild (+pytest?) handle
  things directly, for example by changing the override to something
  like PYBUILD_SYSTEM=custom PYBUILD_TEST_ARGS="xvfb-run -a
  {interpreter} -m pytest -v tests" dh_auto_test.

* tests: you don't want to hardcode dependencies on an autopkgtest
  that should be pulled in by the binary package.

There's a debian/.gitlab-ci.yml file but the CI isn't enabled in the
repository settings on salsa.

The binary package seems to be missing dependencies on tk, pil
(conditional import at src/pygubu/stockimage.py:124), as well as a
large number of tk-related modules used by the plugins (tkcalendar,
awesometkinter, customtkinter, tkintertable, tkintermapview, tksheet;
most of these don't seem to be packaged yet).

Have you done any functional testing on a (reasonably clean) debian
testing or unstable install?


[1]https://hg.python.org/cpython/file/b5ac5e25d506/Lib/lib-tk/test/runtktests.py
[2]https://hg.python.org/cpython/file/b5ac5e25d506/LICENSE

Back to linux.debian.maint.python | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

review for pygubu/0.27-1 Jeroen Ploemen <jcfp@debian.org> - 2022-12-10 11:20 +0100
  Re: review for pygubu/0.27-1 Bo YU <tsu.yubo@gmail.com> - 2022-12-26 15:30 +0100

csiph-web