Path: csiph.com!pasdenom.info!aioe.org!bofh.it!news.nic.it!robomod From: Jeroen Ploemen Newsgroups: linux.debian.maint.python Subject: review for pygubu/0.27-1 Date: Sat, 10 Dec 2022 11:20:01 +0100 Message-ID: X-Original-To: tsu.yubo@gmail.com X-Mailbox-Line: From debian-python-request@lists.debian.org Sat Dec 10 10:18:13 2022 Old-Return-Path: X-Amavis-Spam-Status: No, score=-114.024 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DIGITS_LETTERS=1, DKIMWL_WL_HIGH=-0.515, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_MED=-2.3, UNPARSEABLE_RELAY=0.001, USER_IN_DKIM_WELCOMELIST=-0.01, USER_IN_DKIM_WHITELIST=-100] autolearn=ham autolearn_force=no X-Mailer: Claws Mail 4.1.1 (GTK 3.24.20; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/PMKt/Gp9pEf0IwTyckeVNfJ"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Debian-User: jcfp X-Mailing-List: archive/latest/20576 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/20221210111717.1e46a2c6@debian.org Approved: robomod@news.nic.it Lines: 74 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: debian-python@lists.debian.org X-Original-Date: Sat, 10 Dec 2022 11:17:17 +0100 X-Original-Message-ID: <20221210111717.1e46a2c6@debian.org> Xref: csiph.com linux.debian.maint.python:14710 --Sig_/PMKt/Gp9pEf0IwTyckeVNfJ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable hi Bo, my comments for the pygubu package up for sponsorship in the Python team: * changelog: only a single entry is needed for an initial debian release. * copyright: + please remove the copyright statement at the start of the MIT license paragraph so that it contains only the license terms; + tests/support.py appears to be based on [1] (i.e. from upstream python, license info at [2])? * control: + do you need python3-tk for any other purpose than running tests? If not, mark as !nocheck; + "Description: Debian packaging for pygubu": you want to describe pygubu itself here, not that it's packaged for Debian - every package in the distribution is, after all. * rules: the script at development/runtests.sh simply calls "python3 -m unittest" on the tests dir for the default python3 only, which is not what you want. Consider letting pybuild (+pytest?) handle things directly, for example by changing the override to something like PYBUILD_SYSTEM=3Dcustom PYBUILD_TEST_ARGS=3D"xvfb-run -a {interpreter} -m pytest -v tests" dh_auto_test. * tests: you don't want to hardcode dependencies on an autopkgtest that should be pulled in by the binary package. There's a debian/.gitlab-ci.yml file but the CI isn't enabled in the repository settings on salsa. The binary package seems to be missing dependencies on tk, pil (conditional import at src/pygubu/stockimage.py:124), as well as a large number of tk-related modules used by the plugins (tkcalendar, awesometkinter, customtkinter, tkintertable, tkintermapview, tksheet; most of these don't seem to be packaged yet). Have you done any functional testing on a (reasonably clean) debian testing or unstable install? [1]https://hg.python.org/cpython/file/b5ac5e25d506/Lib/lib-tk/test/runtktes= ts.py [2]https://hg.python.org/cpython/file/b5ac5e25d506/LICENSE --Sig_/PMKt/Gp9pEf0IwTyckeVNfJ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEd8lhnEnWos3N8v+qQoMEoXSNzHoFAmOUXK0ACgkQQoMEoXSN zHqoQg/8CdUavzwnIbi8n8SjSqe1RCGS7CaJD7rmIAmMAn1+X0UVp6wzvRJDrZX3 B/ZExWzMSL0sfjpU28IDE9IT7ZSOTGw5NeonMHIzEE3INOxymHYNRI1xvXNH7Oro kwaRn7Vmu/Hm5d2eOpyTkP5/RZhkK0mSaplt613+fStsrq80/hF8fJ8zHii4ptlH MljmSwy0T2MTVnOkhjEO+AD4IUMRjg3xg6/cuHaYgbAfrqTXbVlzAUPyHp+P1Z/r zhNb8H9d2E5USLzirScBoAL4fdphCAhYu2C4XiB/hR36uOSQUBqlj2gfD3UyYold y0Ljllgjt1zDTARLbDpbkUkz5x0qs1MCZY2Wm1ijRyOBGP6N8eaL8K4s6N5eWw0a 4VbegMSWtxzmpt84Fpw01OVcgIFHmC/QNoED9s/JA1/NSP7AVEkFx9Ud0nfNixyK 72Kp8MJJmNsUeImnCjFrve/SbNiYzXHXWbU8j3RLRzP0KkiubrV70Hsg28r+qvQs FFR2pTeHab197WFEu+4d/SBHYc8v6/0aMYzpRrsKFApa5Ue9Z0QJCljFIHAL0Jpi 7aCrastlLX9Yb0ZLETlPcHWzxuyWwa9wHJa6hWRNx33WLnftcJQ6nGsAQQDMYk6R q8dKn4c+fgbbf0/l0A3n+28MhTetv2G+yKn0XU8OkwyAMP3l7yI= =dUmt -----END PGP SIGNATURE----- --Sig_/PMKt/Gp9pEf0IwTyckeVNfJ--