Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #14488

Bug#1007025: git-multimail 1.6.0 package review

Cross-posted to 2 groups.

Show key headers only | View raw

On 2022-09-22 17:03:24, Bo YU wrote:
> Hi,
> On Tue, Sep 20, 2022 at 10:56:05AM -0400, Antoine Beaupré wrote:
>>> https://github.com/git-multimail/git-multimail/issues/221#issuecomment-1245009306
>>> (To avoid bring noisy for upstream, i just recorded it in a issue)
>>
>>I don't think pull requests are noisy... you should probably just submit
>>this as a PR upstream.
>
> Ok, got it. Will do.
> Sometime I mentioned the patch in the issue, the maintainer of upstream will
> pick it into if he think that is valuable.

Yeah, that's a reasonable assumption, but I find that maintainers often
process merge requests way more quickly and easily as they just need one
click to merge. :)

[...]

> I think the people found the issue also:
> https://github.com/git-multimail/git-multimail/issues/221#issuecomment-1252529169
>
> Certainly, lintian will give a kindly warning:
> W: git-multimail: script-with-language-extension [usr/bin/git_multimail.py]
>
> If I understand correctly, this is a bug as you said.
> The workround is still to use launcher file in d/ as in previous commit?

I think the simplest solution is not to rewrite the launcher, but to
rename it. So in debian/rules, you would simply do:

override_dh_auto_install:
        dh_auto_install
        mv debian/git-multimail/usr/bin/git_multimail.py debian/git-multimail/usr/bin/git-multimail

Also, get rid of the noop sections like:

override_dh_installdocs:
        dh_installdocs

Cheers!

-- 
I prefer the tumult of liberty to the quiet of servitude.
                        - Thomas Jefferson

Back to linux.debian.maint.python | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

I want to join the DPT vimer <tsu.yubo@gmail.com> - 2022-03-17 09:50 +0100
  Re: I want to join the DPT Sandro Tosi <morph@debian.org> - 2022-03-17 14:20 +0100
    Re: I want to join the DPT vimer <tsu.yubo@gmail.com> - 2022-03-17 15:10 +0100
      Re: I want to join the DPT Sandro Tosi <morph@debian.org> - 2022-03-17 15:30 +0100
    Re: I want to join the DPT Sandro Tosi <morph@debian.org> - 2022-03-17 15:50 +0100
      Re: I want to join the DPT Bo YU <tsu.yubo@gmail.com> - 2022-03-18 10:10 +0100
        Bug#1007025: I want to join the DPT Antoine Beaupré <anarcat@debian.org> - 2022-03-18 14:40 +0100
          Bug#1007025: I want to join the DPT Bo YU <tsu.yubo@gmail.com> - 2022-03-18 15:30 +0100
            Bug#1007025: I want to join the DPT Antoine Beaupré <anarcat@debian.org> - 2022-03-18 18:10 +0100
              Bug#1007025: git-multimail 1.6.0 package review Antoine Beaupré <anarcat@debian.org> - 2022-09-15 18:40 +0200
                Bug#1007025: git-multimail 1.6.0 package review Antoine Beaupré <anarcat@debian.org> - 2022-09-15 18:50 +0200
                Bug#1007025: git-multimail 1.6.0 package review Bo YU <tsu.yubo@gmail.com> - 2022-09-18 05:20 +0200
                Bug#1007025: git-multimail 1.6.0 package review Antoine Beaupré <anarcat@debian.org> - 2022-09-20 17:10 +0200
                Bug#1007025: git-multimail 1.6.0 package review Bo YU <tsu.yubo@gmail.com> - 2022-09-22 11:10 +0200
                Bug#1007025: git-multimail 1.6.0 package review Antoine Beaupré <anarcat@debian.org> - 2022-09-22 18:40 +0200
                Re: Bug#1007025: git-multimail 1.6.0 package review Jeroen Ploemen <jcfp@debian.org> - 2022-09-22 19:50 +0200
                Re: Bug#1007025: git-multimail 1.6.0 package review Antoine Beaupré <anarcat@debian.org> - 2022-09-22 20:20 +0200
                Re: Bug#1007025: git-multimail 1.6.0 package review Bo YU <tsu.yubo@gmail.com> - 2022-09-24 09:40 +0200
                Re: Bug#1007025: git-multimail 1.6.0 package review Bo YU <tsu.yubo@gmail.com> - 2022-09-26 15:10 +0200
    Re: I want to join the DPT vimer <tsu.yubo@gmail.com> - 2022-03-17 16:00 +0100
      Re: I want to join the DPT Stefano Rivera <stefanor@debian.org> - 2022-03-27 00:20 +0100
        Re: I want to join the DPT Bo YU <tsu.yubo@gmail.com> - 2022-03-31 05:30 +0200

csiph-web