Groups > linux.debian.maint.python > #13961

Re: Should we allow Janitor to commit directly to all DPT packages?

Path	csiph.com!newsfeed.xs4all.nl!newsfeed9.news.xs4all.nl!bofh.it!news.nic.it!robomod
From	Nilesh Patra <nilesh@riseup.net>
Newsgroups	linux.debian.maint.python
Subject	Re: Should we allow Janitor to commit directly to all DPT packages?
Date	Thu, 17 Feb 2022 22:10:02 +0100
Message-ID	<DRWci-2vmc-5@gated-at.bofh.it> (permalink)
References	<DRT4J-2tgC-3@gated-at.bofh.it> <DRV6x-2usV-11@gated-at.bofh.it> <DRW2B-2v2M-1@gated-at.bofh.it>
X-Original-To	debian-python@lists.debian.org
X-Mailbox-Line	From debian-python-request@lists.debian.org Thu Feb 17 21:01:37 2022
Old-Return-Path	<nilesh@riseup.net>
X-Amavis-Spam-Status	No, score=-12.908 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
X-Policyd-Weight	using cached result; rate:hard: -4.6
X-Riseup-User-ID	6C716995DD43433FAB1610A5FB61D8ADAD3C458B271EB8F4956E8AA10282A83D
MIME-Version	1.0
Content-Type	multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UUzWiOTo9V9K60HYOQf2aFVXlGqSiZr6A"
X-Mailing-List	<debian-python@lists.debian.org> archive/latest/19775
List-ID	<debian-python.lists.debian.org>
List-URL	<https://lists.debian.org/debian-python/>
List-Archive	https://lists.debian.org/msgid-search/0c4b2fbe-4b96-a454-0630-552f35eac283@riseup.net
Approved	robomod@news.nic.it
Lines	86
Organization	linux.* mail to news gateway
Sender	robomod@news.nic.it
X-Original-Date	Fri, 18 Feb 2022 02:31:13 +0530
X-Original-Message-ID	<0c4b2fbe-4b96-a454-0630-552f35eac283@riseup.net>
X-Original-References	<CAB4XWXxiJQKo_qKvUZ3n=hGqN=RPO6zQtcGUK5mAPJwKTvo_eA@mail.gmail.com> <Yg6n/lNxNQOSjNNc@an3as.eu> <CAB4XWXwy2A6FVrmNOY-P2E3tc4_vpd3baySRkDGDxB2MwV024Q@mail.gmail.com>
Xref	csiph.com linux.debian.maint.python:13961

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

On 2/18/22 2:23 AM, Sandro Tosi wrote:
>> I admit I'm hesitating a bit for different reasons.  While I agree that
>> direct commits are better than MRs I found several DPT packages with
>> very sensible changes in Git but no uploads following these.  For
>> instance fixing VCS fields and Maintainer name should be followed by an
>> according upload to make those changes visible to users and developers
>> of the *packages* in Debian.
>>
>> In the Debian Med team for instance we do those automatic changes before
>> uploading a package - say when upgrading to new upstream versions or
>> fixing some bugs.  Than we run the Janitor scripts and other automatic
>> changes which is all done in routine-update.  I personally find this
>> workflow more convenient.  That way Debian Med team (as well as pkg-r
>> team) are blacklisted for Janitor to not have competing changes inside
>> the package.
> 
> thanks for bringing the perspective of how things are done in the Med
> team, but it feels none of the points you mentioned nor the specific
> Med team workflow apply here,

I suppose the highlight was the usage of routine-update[1] package before upload
and we could use it with DPT too.
This does similar(same?) changes as in janitor.

But that said, I agree with what you wrote:

> or are relevant to just let Janitor
> commit directly to our packages.

I vote a in for/OK for janitor to commit directly as well.

[1]: https://tracker.debian.org/pkg/routine-update

Regards,
Nilesh

Thread

Should we allow Janitor to commit directly to all DPT packages? Sandro Tosi <morph@debian.org> - 2022-02-17 18:50 +0100
  Re: Should we allow Janitor to commit directly to all DPT packages? Andreas Tille <andreas@an3as.eu> - 2022-02-17 21:00 +0100
    Re: Should we allow Janitor to commit directly to all DPT packages? Sandro Tosi <morph@debian.org> - 2022-02-17 22:00 +0100
      Re: Should we allow Janitor to commit directly to all DPT packages? Nilesh Patra <nilesh@riseup.net> - 2022-02-17 22:10 +0100
        Re: Should we allow Janitor to commit directly to all DPT packages? Andreas Tille <andreas@an3as.eu> - 2022-02-19 14:30 +0100
  Re: Should we allow Janitor to commit directly to all DPT packages? Sandro Tosi <morph@debian.org> - 2022-03-29 23:50 +0200
    Re: Should we allow Janitor to commit directly to all DPT packages? stefanor@debian.org - 2022-05-24 12:40 +0200
      Re: Should we allow Janitor to commit directly to all DPT packages? Jelmer Vernooĳ <jelmer@debian.org> - 2022-05-24 12:50 +0200

csiph-web