Groups > linux.debian.maint.python > #13409

Re: Code review for grammalecte

Path	csiph.com!eternal-september.org!reader02.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Romain Porte <microjoe@microjoe.org>
Newsgroups	linux.debian.maint.python
Subject	Re: Code review for grammalecte
Date	Thu, 27 May 2021 14:30:01 +0200
Message-ID	<Cjnjb-7M2-3@gated-at.bofh.it> (permalink)
References	<CiMjE-29f-11@gated-at.bofh.it> <CiMjE-29f-9@gated-at.bofh.it>
X-Original-To	Louis-Philippe Véronneau <pollo@debian.org>
X-Mailbox-Line	From debian-python-request@lists.debian.org Thu May 27 12:24:09 2021
Old-Return-Path	<microjoe@microjoe.org>
X-Amavis-Spam-Status	No, score=-6.999 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, LDO_WHITELIST=-5, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001] autolearn=ham autolearn_force=no
X-Policyd-Weight	using cached result; rate: -5.5
X-Greylist	delayed 1199 seconds by postgrey-1.36 at bendel; Thu, 27 May 2021 12:08:14 UTC
Authentication-Results	garm.ovh; auth=pass (GARM-103G0056d4f72e2-a779-4a94-b047-44f859acd862, B7EBD773A3B82BA624FD0DBB7BF01AF7EF51F5DD) smtp.auth=microjoe@microjoe.org
X-Ovh-Clientip	82.65.169.98
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Transfer-Encoding	8bit
Content-Language	fr
X-Ovh-Tracer-ID	9408864050737751784
X-Vr-Spamstate	OK
X-Vr-Spamcause	gggruggvucftvghtrhhoucdtuddrgeduledrvdekhedggedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpefuvfhfhffkffgfgggjtgfgsehtkeertddtfeejnecuhfhrohhmpeftohhmrghinhcurfhorhhtvgcuoehmihgtrhhojhhovgesmhhitghrohhjohgvrdhorhhgqeenucggtffrrghtthgvrhhnpeegueejjeekgffhueelkedvleefgfelfedufeehjeevueeuleegudetgfdvhfegkeenucfkpheptddrtddrtddrtddpkedvrdeihedrudeiledrleeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepphhlrgihvghrjedvkedrhhgrrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpehmihgtrhhojhhovgesmhhitghrohhjohgvrdhorhhgpdhrtghpthhtohepuggvsghirghnqdhphihthhhonheslhhishhtshdruggvsghirghnrdhorhhg
X-Mailing-List	<debian-python@lists.debian.org> archive/latest/19197
List-ID	<debian-python.lists.debian.org>
List-URL	<https://lists.debian.org/debian-python/>
List-Archive	https://lists.debian.org/msgid-search/8bddbae7-abe7-05d7-7c73-79f83c5268f8@microjoe.org
Approved	robomod@news.nic.it
Lines	62
Organization	linux.* mail to news gateway
Sender	robomod@news.nic.it
X-Original-Cc	debian-python@lists.debian.org
X-Original-Date	Thu, 27 May 2021 13:29:21 +0200
X-Original-Message-ID	<8bddbae7-abe7-05d7-7c73-79f83c5268f8@microjoe.org>
X-Original-References	<e9ed9f91-8003-482e-1979-14267e265cd6@debian.org> <8a9afc9d-0636-60ce-12de-189f9dbb1ec2@debian.org>
Xref	csiph.com linux.debian.maint.python:13409

Show key headers only | View raw

Hi pollo,

Thanks for the review, I have (force)pushed the new changes with commits
that address the issues listed here, as well as other issues from IRC
comments you did earlier.

Please let me know by reply or on IRC if something is still missing.

Best regards,

Romain.

25/05/2021 22:57, Louis-Philippe Véronneau :
> Hello!
>
> This is quite a large package, so instead of continuing to spam the IRC
> channel, here are my comments.
>
> 1. These files are licensed under the MPL2
>
> * darg.py
> * gc_core/py/oxt/Grammalecte.py
> * gc_core/py/oxt/Options.py
> * gc_lang/fr/build_data.py
> * gc_lang/fr/dictionnaire/genfrdic.py
> * gc_lang/fr/dictionnaire/_templates/ooo/DictionarySwitcher.py
> * gc_lang/fr/oxt/AppLauncher.py
> * gc_lang/fr/oxt/Graphspell.py
> * gc_lang/fr/oxt/About/About.py
> * gc_lang/fr/oxt/ChangeAuthor/Author.py
> * gc_lang/fr/oxt/ContextMenu/ContextMenu.py
> * gc_lang/fr/oxt/DictOptions/DictOptions.py
> * gc_lang/fr/oxt/DictOptions/LexiconEditor.py
> * gc_lang/fr/oxt/DictOptions/SearchWords.py
> * gc_lang/fr/oxt/DictOptions/TagsInfo.py
> * gc_lang/fr/oxt/GraphicOptions/GraphicOptions.py
> * gc_lang/fr/oxt/Lexicographer/Enumerator.py
> * gc_lang/fr/oxt/TextFormatter/TextFormatterEditor.py
> * gc_lang/fr/oxt/TextFormatter/TextFormatter.py
> * graphspell/dawg.py
> * graphspell/progressbar.py
> * graphspell-js/dawg.js
>
> To me, this is a sign you haven't read the code
>
> Although it can be long and tiresome (and trust me, I know, I've just
> read the entire codebase :P), it's an important step in packaging
> something in Debian. When updating a package, you should also go through
> the diff.
>
> 2. There should be an entry in d/copyright for
> gc_lang/fr/dictionnaire/metaphone2.py
>
> 3. gc_lang/fr/nodejs/cli/lib/minimist.js seems to be a vendored copy of
> a version of node-minimist. If you need it, you should use the debian
> package. If not, it should be excluded.
>
> That's pretty much it! Fix those issues and I'll be happy to upload to
> experimental.
>
> Cheers,
>

Back to linux.debian.maint.python | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: Code review for grammalecte Louis-Philippe Véronneau <pollo@debian.org> - 2021-05-25 23:00 +0200
  Re: Code review for grammalecte Romain Porte <microjoe@microjoe.org> - 2021-05-27 14:30 +0200

csiph-web