Path: csiph.com!eternal-september.org!reader02.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From: Romain Porte <microjoe@microjoe.org>
Newsgroups: linux.debian.maint.python
Subject: Re: Code review for grammalecte
Date: Thu, 27 May 2021 14:30:01 +0200
Message-ID: <Cjnjb-7M2-3@gated-at.bofh.it>
References: <CiMjE-29f-11@gated-at.bofh.it> <CiMjE-29f-9@gated-at.bofh.it>
Old-Return-Path: <microjoe@microjoe.org>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Language: fr
Approved: robomod@news.nic.it
Lines: 62
Organization: linux.* mail to news gateway
Sender: robomod@news.nic.it
Xref: csiph.com linux.debian.maint.python:13409

Hi pollo,

Thanks for the review, I have (force)pushed the new changes with commits
that address the issues listed here, as well as other issues from IRC
comments you did earlier.

Please let me know by reply or on IRC if something is still missing.

Best regards,

Romain.

25/05/2021 22:57, Louis-Philippe Véronneau :
> Hello!
>
> This is quite a large package, so instead of continuing to spam the IRC
> channel, here are my comments.
>
> 1. These files are licensed under the MPL2
>
> * darg.py
> * gc_core/py/oxt/Grammalecte.py
> * gc_core/py/oxt/Options.py
> * gc_lang/fr/build_data.py
> * gc_lang/fr/dictionnaire/genfrdic.py
> * gc_lang/fr/dictionnaire/_templates/ooo/DictionarySwitcher.py
> * gc_lang/fr/oxt/AppLauncher.py
> * gc_lang/fr/oxt/Graphspell.py
> * gc_lang/fr/oxt/About/About.py
> * gc_lang/fr/oxt/ChangeAuthor/Author.py
> * gc_lang/fr/oxt/ContextMenu/ContextMenu.py
> * gc_lang/fr/oxt/DictOptions/DictOptions.py
> * gc_lang/fr/oxt/DictOptions/LexiconEditor.py
> * gc_lang/fr/oxt/DictOptions/SearchWords.py
> * gc_lang/fr/oxt/DictOptions/TagsInfo.py
> * gc_lang/fr/oxt/GraphicOptions/GraphicOptions.py
> * gc_lang/fr/oxt/Lexicographer/Enumerator.py
> * gc_lang/fr/oxt/TextFormatter/TextFormatterEditor.py
> * gc_lang/fr/oxt/TextFormatter/TextFormatter.py
> * graphspell/dawg.py
> * graphspell/progressbar.py
> * graphspell-js/dawg.js
>
> To me, this is a sign you haven't read the code
>
> Although it can be long and tiresome (and trust me, I know, I've just
> read the entire codebase :P), it's an important step in packaging
> something in Debian. When updating a package, you should also go through
> the diff.
>
> 2. There should be an entry in d/copyright for
> gc_lang/fr/dictionnaire/metaphone2.py
>
> 3. gc_lang/fr/nodejs/cli/lib/minimist.js seems to be a vendored copy of
> a version of node-minimist. If you need it, you should use the debian
> package. If not, it should be excluded.
>
> That's pretty much it! Fix those issues and I'll be happy to upload to
> experimental.
>
> Cheers,
>