Groups > linux.debian.maint.python > #13407

Re: Code review for grammalecte

Path	csiph.com!news.neodome.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Louis-Philippe Véronneau <pollo@debian.org>
Newsgroups	linux.debian.maint.python
Subject	Re: Code review for grammalecte
Date	Tue, 25 May 2021 23:00:02 +0200
Message-ID	<CiMjE-29f-9@gated-at.bofh.it> (permalink)
References	<CiMjE-29f-11@gated-at.bofh.it>
X-Original-To	microjoe@microjoe.org
X-Mailbox-Line	From debian-python-request@lists.debian.org Tue May 25 20:57:27 2021
Old-Return-Path	<pollo@debian.org>
X-Amavis-Spam-Status	No, score=-11.198 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, BODY_8BITS=1.5, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001] autolearn=ham autolearn_force=no
X-Policyd-Weight	using cached result; rate: -4.6
X-Riseup-User-ID	312FE967C9A25E4B70A932F83D776C1D6A1BBC8996C077339F6F525E80D931F5
MIME-Version	1.0
Content-Type	multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sIUXhT63krKY0tvU1OGoBO5ymV94dLjwS"
X-Mailing-List	<debian-python@lists.debian.org> archive/latest/19195
List-ID	<debian-python.lists.debian.org>
List-URL	<https://lists.debian.org/debian-python/>
List-Archive	https://lists.debian.org/msgid-search/8a9afc9d-0636-60ce-12de-189f9dbb1ec2@debian.org
Approved	robomod@news.nic.it
Lines	91
Organization	linux.* mail to news gateway
Sender	robomod@news.nic.it
X-Original-Cc	debian-python@lists.debian.org
X-Original-Date	Tue, 25 May 2021 16:57:04 -0400
X-Original-Message-ID	<8a9afc9d-0636-60ce-12de-189f9dbb1ec2@debian.org>
X-Original-References	<e9ed9f91-8003-482e-1979-14267e265cd6@debian.org>
Xref	csiph.com linux.debian.maint.python:13407

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Hello!

This is quite a large package, so instead of continuing to spam the IRC
channel, here are my comments.

1. These files are licensed under the MPL2

* darg.py
* gc_core/py/oxt/Grammalecte.py
* gc_core/py/oxt/Options.py
* gc_lang/fr/build_data.py
* gc_lang/fr/dictionnaire/genfrdic.py
* gc_lang/fr/dictionnaire/_templates/ooo/DictionarySwitcher.py
* gc_lang/fr/oxt/AppLauncher.py
* gc_lang/fr/oxt/Graphspell.py
* gc_lang/fr/oxt/About/About.py
* gc_lang/fr/oxt/ChangeAuthor/Author.py
* gc_lang/fr/oxt/ContextMenu/ContextMenu.py
* gc_lang/fr/oxt/DictOptions/DictOptions.py
* gc_lang/fr/oxt/DictOptions/LexiconEditor.py
* gc_lang/fr/oxt/DictOptions/SearchWords.py
* gc_lang/fr/oxt/DictOptions/TagsInfo.py
* gc_lang/fr/oxt/GraphicOptions/GraphicOptions.py
* gc_lang/fr/oxt/Lexicographer/Enumerator.py
* gc_lang/fr/oxt/TextFormatter/TextFormatterEditor.py
* gc_lang/fr/oxt/TextFormatter/TextFormatter.py
* graphspell/dawg.py
* graphspell/progressbar.py
* graphspell-js/dawg.js

To me, this is a sign you haven't read the code

Although it can be long and tiresome (and trust me, I know, I've just
read the entire codebase :P), it's an important step in packaging
something in Debian. When updating a package, you should also go through
the diff.

2. There should be an entry in d/copyright for
gc_lang/fr/dictionnaire/metaphone2.py

3. gc_lang/fr/nodejs/cli/lib/minimist.js seems to be a vendored copy of
a version of node-minimist. If you need it, you should use the debian
package. If not, it should be excluded.

That's pretty much it! Fix those issues and I'll be happy to upload to
experimental.

Cheers,

-- 
  ⢀⣴⠾⠻⢶⣦⠀
  ⣾⠁⢠⠒⠀⣿⡁  Louis-Philippe Véronneau
  ⢿⡄⠘⠷⠚⠋   pollo@debian.org / veronneau.org
  ⠈⠳⣄

Back to linux.debian.maint.python | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: Code review for grammalecte Louis-Philippe Véronneau <pollo@debian.org> - 2021-05-25 23:00 +0200
  Re: Code review for grammalecte Romain Porte <microjoe@microjoe.org> - 2021-05-27 14:30 +0200

csiph-web