Path: csiph.com!news.neodome.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod From: =?UTF-8?Q?Louis-Philippe_V=c3=a9ronneau?= Newsgroups: linux.debian.maint.python Subject: Re: Code review for grammalecte Date: Tue, 25 May 2021 23:00:02 +0200 Message-ID: References: X-Original-To: microjoe@microjoe.org X-Mailbox-Line: From debian-python-request@lists.debian.org Tue May 25 20:57:27 2021 Old-Return-Path: X-Amavis-Spam-Status: No, score=-11.198 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, BODY_8BITS=1.5, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001] autolearn=ham autolearn_force=no X-Policyd-Weight: using cached result; rate: -4.6 X-Riseup-User-ID: 312FE967C9A25E4B70A932F83D776C1D6A1BBC8996C077339F6F525E80D931F5 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sIUXhT63krKY0tvU1OGoBO5ymV94dLjwS" X-Mailing-List: archive/latest/19195 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/8a9afc9d-0636-60ce-12de-189f9dbb1ec2@debian.org Approved: robomod@news.nic.it Lines: 91 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: debian-python@lists.debian.org X-Original-Date: Tue, 25 May 2021 16:57:04 -0400 X-Original-Message-ID: <8a9afc9d-0636-60ce-12de-189f9dbb1ec2@debian.org> X-Original-References: Xref: csiph.com linux.debian.maint.python:13407 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --sIUXhT63krKY0tvU1OGoBO5ymV94dLjwS Content-Type: multipart/mixed; boundary="vUsIuwWARPhrZfEu91dyiB7zGzpgr5Asz"; protected-headers="v1" From: =?UTF-8?Q?Louis-Philippe_V=c3=a9ronneau?= To: microjoe@microjoe.org Cc: debian-python@lists.debian.org Message-ID: <8a9afc9d-0636-60ce-12de-189f9dbb1ec2@debian.org> Subject: Re: Code review for grammalecte References: In-Reply-To: --vUsIuwWARPhrZfEu91dyiB7zGzpgr5Asz Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hello! This is quite a large package, so instead of continuing to spam the IRC channel, here are my comments. 1. These files are licensed under the MPL2 * darg.py * gc_core/py/oxt/Grammalecte.py * gc_core/py/oxt/Options.py * gc_lang/fr/build_data.py * gc_lang/fr/dictionnaire/genfrdic.py * gc_lang/fr/dictionnaire/_templates/ooo/DictionarySwitcher.py * gc_lang/fr/oxt/AppLauncher.py * gc_lang/fr/oxt/Graphspell.py * gc_lang/fr/oxt/About/About.py * gc_lang/fr/oxt/ChangeAuthor/Author.py * gc_lang/fr/oxt/ContextMenu/ContextMenu.py * gc_lang/fr/oxt/DictOptions/DictOptions.py * gc_lang/fr/oxt/DictOptions/LexiconEditor.py * gc_lang/fr/oxt/DictOptions/SearchWords.py * gc_lang/fr/oxt/DictOptions/TagsInfo.py * gc_lang/fr/oxt/GraphicOptions/GraphicOptions.py * gc_lang/fr/oxt/Lexicographer/Enumerator.py * gc_lang/fr/oxt/TextFormatter/TextFormatterEditor.py * gc_lang/fr/oxt/TextFormatter/TextFormatter.py * graphspell/dawg.py * graphspell/progressbar.py * graphspell-js/dawg.js To me, this is a sign you haven't read the code Although it can be long and tiresome (and trust me, I know, I've just read the entire codebase :P), it's an important step in packaging something in Debian. When updating a package, you should also go through the diff. 2. There should be an entry in d/copyright for gc_lang/fr/dictionnaire/metaphone2.py 3. gc_lang/fr/nodejs/cli/lib/minimist.js seems to be a vendored copy of a version of node-minimist. If you need it, you should use the debian package. If not, it should be excluded. That's pretty much it! Fix those issues and I'll be happy to upload to experimental. Cheers, --=20 =E2=A2=80=E2=A3=B4=E2=A0=BE=E2=A0=BB=E2=A2=B6=E2=A3=A6=E2=A0=80 =E2=A3=BE=E2=A0=81=E2=A2=A0=E2=A0=92=E2=A0=80=E2=A3=BF=E2=A1=81 Louis-= Philippe V=C3=A9ronneau =E2=A2=BF=E2=A1=84=E2=A0=98=E2=A0=B7=E2=A0=9A=E2=A0=8B pollo@debian.o= rg / veronneau.org =E2=A0=88=E2=A0=B3=E2=A3=84 --vUsIuwWARPhrZfEu91dyiB7zGzpgr5Asz-- --sIUXhT63krKY0tvU1OGoBO5ymV94dLjwS Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQTKp0AHB6gWsCAvw830JXpQshz6hQUCYK1koQAKCRD0JXpQshz6 haqzAP0cczojdEoCq7QiJFVxv2QLbvXG0XMt+ZEYvVjVFqEkVQEAjXrKiA3dBjdq 2JMNLq8bn1JBrWQCt2RTM3V1YyXY3gU= =U7wV -----END PGP SIGNATURE----- --sIUXhT63krKY0tvU1OGoBO5ymV94dLjwS--