Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #13487

Re: Request for review for Poetry(Was: Re: Asking for help Poetry)

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Hello!!!

I just push some updates to salsa


Here are my comments:
>
> 1. d/control:
>
> You haven't set the Python Team either in Maintainer or Uploaders.
>
> Ready my bad! Also I note that some dependencies that I package for Poetry
were uploaded and DPT was not the Maintainer, I'll change those.

> ---------------------------------------------------------------------
>
> 2. d/control:
>
> If you require specific dependencies, you should make it clear in
> d/control. It's the kind of thing that helps a lot if people decide to
> backport it.
>
> Ready

> ---------------------------------------------------------------------
>
> 3. tests/repositories/fixtures
>
> This directory contains a bunch of tarballs from other projects. I'm not
> sure what should be done with this, as I guess they are used in the
> testsuite....
>
> My first reflex would be to exclude them from the imported tarball and
> disable the tests that require them, but I don't know how much of the
> testsuite depends on those tarballs.
>
> Maybe someone else from the team can chime-in?
>
> I will look at that these days. I can try to remove them and "turn off"
the test
that uses the tarballs.  Some days ago, I started to look at the pypy
package,
and it has the suittest in another package (btw, that is new for me).
Maybe poetry can have that approach? Also, I don't know if that makes sense.

> ---------------------------------------------------------------------
>
> 4. d/tests
>
> There are no autopkgtests. This being a large project that's kinda hard
> to package, I don't really mind for now.
>
> I think it's fair to wait to have at least 1 version in unstable before
> working on that.
>
yes, that was my idea.

>
> ---------------------------------------------------------------------
>
> 5. d/rules
>
> Isn't the step in execute_after_dh_auto_install better suited in
> execute_after_dh_clean instead? At least, it seems to me you're cleaning
> the ./foo dir you patched in.
>
> yes you're right, that makes more sense, thanks!

> ---------------------------------------------------------------------
>
> 6. Lintian: W: python3-poetry: no-manual-page usr/bin/poetry
>
> Again, not something that needs to be fixed, but each subcommand of
> poetry should probably get a man page:
>
> https://python-poetry.org/docs/cli/
>
> I looked at the code and I have no idea how this website is built (they
> don't use sphinx). It seems like they do something manual?
>
> https://github.com/python-poetry/poetry/issues/3382
>
> Anyway, here's an example of how I added man pages to a program with
> multiple commands:
>
> https://github.com/spl0k/supysonic/tree/master/docs/man
>
>
thanks for note it, I'll take a look these days.

> ---------------------------------------------------------------------
>
> Overall it's very good! The trickiest part to fix will likely be #3 :S
>
> > I need to skip some tests because use a non versioned python, so that
> > give me some troubles like "python don't exist".
> >
> > Also, there're some package (or package version) that aren't in Debian
> > yet. So, to save your time looking which are them I tell you that I run
> > the buildpackage in this way:
> >
> > ```
> >
> > gbp buildpackage --git-ignore-new
> >
> --extra-package=/home/eamanu/Debian/DEPENDENCIES/python3-cleo_0.8.1-1_all.deb
> >
> --extra-package=/home/eamanu/Debian/DEPENDENCIES/python3-httpretty_1.0.5-0.1_all.deb
> >
> --extra-package=/home/eamanu/Debian/DEPENDENCIES/python3-pkginfo_1.7.0-1_all.deb
>
> This package has not been updated on Salsa, or at least, I couldn't find
> version 1.7.0-1 anywhere. Maybe you forgot to push?
>
> Oh yes, I'm just psuh to salsa. Sorry!


Cheers!
Emmanuel

Back to linux.debian.maint.python | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Asking for help Poetry Emmanuel Arias <eamanu@yaerobi.com> - 2020-06-29 05:10 +0200
  Re: Asking for help Poetry Scott Kitterman <debian@kitterman.com> - 2020-06-29 06:10 +0200
    Re: Asking for help Poetry Bastian Venthur <venthur@debian.org> - 2020-11-19 16:20 +0100
      Re: Asking for help Poetry Emmanuel Arias <eamanu@yaerobi.com> - 2020-11-22 15:10 +0100
        Re: Asking for help Poetry Emmanuel Arias <eamanu@yaerobi.com> - 2020-12-04 22:40 +0100
          Re: Asking for help Poetry Emmanuel Arias <eamanu@yaerobi.com> - 2021-01-02 17:40 +0100
            Re: Asking for help Poetry Sandro Tosi <morph@debian.org> - 2021-03-12 18:10 +0100
              Re: Asking for help Poetry Emmanuel Arias <eamanu@yaerobi.com> - 2021-03-12 23:00 +0100
                Re: Asking for help Poetry Sandro Tosi <morph@debian.org> - 2021-03-15 08:30 +0100
                Re: Asking for help Poetry Emmanuel Arias <eamanu@yaerobi.com> - 2021-03-15 15:30 +0100
                Re: Asking for help Poetry Sandro Tosi <morph@debian.org> - 2021-05-09 03:40 +0200
                Re: Asking for help Poetry Emmanuel Arias <eamanu@yaerobi.com> - 2021-05-09 04:00 +0200
                Re: Asking for help Poetry Sandro Tosi <morph@debian.org> - 2021-05-11 06:30 +0200
                Re: Asking for help Poetry Emmanuel Arias <eamanu@yaerobi.com> - 2021-05-11 14:00 +0200
                Re: Asking for help Poetry Emmanuel Arias <eamanu@yaerobi.com> - 2021-05-27 03:40 +0200
                Request for review for Poetry(Was: Re: Asking for help Poetry) Emmanuel Arias <eamanu@yaerobi.com> - 2021-06-20 00:30 +0200
                Re: Request for review for Poetry(Was: Re: Asking for help Poetry) Louis-Philippe Véronneau <pollo@debian.org> - 2021-07-03 00:30 +0200
                Re: Request for review for Poetry(Was: Re: Asking for help Poetry) Louis-Philippe Véronneau <louis-philippe@veronneau.org> - 2021-07-03 00:30 +0200
                Re: Request for review for Poetry(Was: Re: Asking for help Poetry) Emmanuel Arias <eamanu@yaerobi.com> - 2021-08-26 17:00 +0200
                Re: Asking for help Poetry Bastian Venthur <venthur@debian.org> - 2021-03-15 10:00 +0100
                Re: Asking for help Poetry Emmanuel Arias <eamanu@yaerobi.com> - 2021-03-15 15:30 +0100

csiph-web