Path: csiph.com!newsfeed.xs4all.nl!newsfeed9.news.xs4all.nl!bofh.it!news.nic.it!robomod From: Emmanuel Arias Newsgroups: linux.debian.maint.python Subject: Re: Request for review for Poetry(Was: Re: Asking for help Poetry) Date: Thu, 26 Aug 2021 17:00:02 +0200 Message-ID: References: X-Mailbox-Line: From debian-python-request@lists.debian.org Thu Aug 26 14:59:14 2021 Old-Return-Path: X-Amavis-Spam-Status: No, score=-4.98 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=2, LDO_WHITELIST=-5, MURPHY_DRUGS_REL8=0.02, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=no autolearn_force=no X-Policyd-Weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 CL_IP_EQ_HELO_IP=-2 (check from: .yaerobi. - helo: .mail-wr1-x42b.google. - helo-domain: .google.) FROM/MX_MATCHES_HELO(DOMAIN)=-2; rate: -5.5 X-Gm-Message-State: AOAM5321eSV83yr+/jVLUvkq6At+K8g1Y7aWHv1wWVEvXMODI3IRJJFs nFNVgA9YF+B28j4TFJekv4KV2Mbc4DAnRL/t5TZXK+M3qt0= X-Google-SMTP-Source: ABdhPJwI4uuu9/ULgozgEo05GhIW7YK2+SKJ7c0seNwWslfSyKHLHnVa2jFlUd8m6PPCp/Jov5fTxDUWMJFdEryxveM= X-Received: by 2002:adf:f3c4:: with SMTP id g4mr4668242wrp.409.1629989936460; Thu, 26 Aug 2021 07:58:56 -0700 (PDT) MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000268b6e05ca779b79" X-Mailing-List: archive/latest/19279 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/CAFNO5od8=6-G7tJf=-4HONJUSOB9uKb2K-oxtvTJFaHQV0JYoQ@mail.gmail.com Approved: robomod@news.nic.it Lines: 259 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: debian-python X-Original-Date: Thu, 26 Aug 2021 11:58:44 -0300 X-Original-Message-ID: X-Original-References: <955fe2f6-d5c0-bc76-803c-3a3e047ab1e7@yaerobi.com> <3c823708-a9de-2bdb-cada-3573920bd884@yaerobi.com> Xref: csiph.com linux.debian.maint.python:13487 --000000000000268b6e05ca779b79 Content-Type: text/plain; charset="UTF-8" Hello!!! I just push some updates to salsa Here are my comments: > > 1. d/control: > > You haven't set the Python Team either in Maintainer or Uploaders. > > Ready my bad! Also I note that some dependencies that I package for Poetry were uploaded and DPT was not the Maintainer, I'll change those. > --------------------------------------------------------------------- > > 2. d/control: > > If you require specific dependencies, you should make it clear in > d/control. It's the kind of thing that helps a lot if people decide to > backport it. > > Ready > --------------------------------------------------------------------- > > 3. tests/repositories/fixtures > > This directory contains a bunch of tarballs from other projects. I'm not > sure what should be done with this, as I guess they are used in the > testsuite.... > > My first reflex would be to exclude them from the imported tarball and > disable the tests that require them, but I don't know how much of the > testsuite depends on those tarballs. > > Maybe someone else from the team can chime-in? > > I will look at that these days. I can try to remove them and "turn off" the test that uses the tarballs. Some days ago, I started to look at the pypy package, and it has the suittest in another package (btw, that is new for me). Maybe poetry can have that approach? Also, I don't know if that makes sense. > --------------------------------------------------------------------- > > 4. d/tests > > There are no autopkgtests. This being a large project that's kinda hard > to package, I don't really mind for now. > > I think it's fair to wait to have at least 1 version in unstable before > working on that. > yes, that was my idea. > > --------------------------------------------------------------------- > > 5. d/rules > > Isn't the step in execute_after_dh_auto_install better suited in > execute_after_dh_clean instead? At least, it seems to me you're cleaning > the ./foo dir you patched in. > > yes you're right, that makes more sense, thanks! > --------------------------------------------------------------------- > > 6. Lintian: W: python3-poetry: no-manual-page usr/bin/poetry > > Again, not something that needs to be fixed, but each subcommand of > poetry should probably get a man page: > > https://python-poetry.org/docs/cli/ > > I looked at the code and I have no idea how this website is built (they > don't use sphinx). It seems like they do something manual? > > https://github.com/python-poetry/poetry/issues/3382 > > Anyway, here's an example of how I added man pages to a program with > multiple commands: > > https://github.com/spl0k/supysonic/tree/master/docs/man > > thanks for note it, I'll take a look these days. > --------------------------------------------------------------------- > > Overall it's very good! The trickiest part to fix will likely be #3 :S > > > I need to skip some tests because use a non versioned python, so that > > give me some troubles like "python don't exist". > > > > Also, there're some package (or package version) that aren't in Debian > > yet. So, to save your time looking which are them I tell you that I run > > the buildpackage in this way: > > > > ``` > > > > gbp buildpackage --git-ignore-new > > > --extra-package=/home/eamanu/Debian/DEPENDENCIES/python3-cleo_0.8.1-1_all.deb > > > --extra-package=/home/eamanu/Debian/DEPENDENCIES/python3-httpretty_1.0.5-0.1_all.deb > > > --extra-package=/home/eamanu/Debian/DEPENDENCIES/python3-pkginfo_1.7.0-1_all.deb > > This package has not been updated on Salsa, or at least, I couldn't find > version 1.7.0-1 anywhere. Maybe you forgot to push? > > Oh yes, I'm just psuh to salsa. Sorry! Cheers! Emmanuel --000000000000268b6e05ca779b79 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello!!!

I just push some up= dates to salsa


Here are my comments:

1. d/control:

You haven't set the Python Team either in Maintainer or Uploaders.

Ready my bad! Also I note that some dependencies that= I package for Poetry
were uploaded and DPT was not the Maintaine= r, I'll change those.
---------------------------------------------------------------------

2. d/control:

If you require specific dependencies, you should make it clear in
d/control. It's the kind of thing that helps a lot if people decide to<= br> backport it.

Ready
---------------------------------------------------------------------

3. tests/repositories/fixtures

This directory contains a bunch of tarballs from other projects. I'm no= t
sure what should be done with this, as I guess they are used in the
testsuite....

My first reflex would be to exclude them from the imported tarball and
disable the tests that require them, but I don't know how much of the testsuite depends on those tarballs.

Maybe someone else from the team can chime-in?

I will look at that these days. I can try to remove t= hem and "turn off" the test
that uses the tarballs.=C2= =A0 Some days ago, I started to look at the pypy package,
and it = has the suittest in another package (btw, that is new for me).
Ma= ybe poetry can have that approach? Also, I don't know if that makes sen= se.
---------------------------------------------------------------------

4. d/tests

There are no autopkgtests. This being a large project that's kinda hard=
to package, I don't really mind for now.

I think it's fair to wait to have at least 1 version in unstable before=
working on that.
yes, that was my idea.=C2=A0

---------------------------------------------------------------------

5. d/rules

Isn't the step in execute_after_dh_auto_install better suited in
execute_after_dh_clean instead? At least, it seems to me you're cleanin= g
the ./foo dir you patched in.

yes you're right, that makes more sense, thanks!<= br>
---------------------------------------------------------------------

6. Lintian: W: python3-poetry: no-manual-page usr/bin/poetry

Again, not something that needs to be fixed, but each subcommand of
poetry should probably get a man page:

https://python-poetry.org/docs/cli/

I looked at the code and I have no idea how this website is built (they
don't use sphinx). It seems like they do something manual?

https://github.com/python-poetry/poetry/issues/33= 82

Anyway, here's an example of how I added man pages to a program with multiple commands:

https://github.com/spl0k/supysonic/tree/maste= r/docs/man


thanks for note it, I'll take a lo= ok these days.
---------------------------------------------------------------------

Overall it's very good! The trickiest part to fix will likely be #3 :S<= br>
> I need to skip some tests because use a non versioned python, so that<= br> > give me some troubles like "python don't exist".
>
> Also, there're some package (or package version) that aren't i= n Debian
> yet. So, to save your time looking which are them I tell you that I ru= n
> the buildpackage in this way:
>
> ```
>
> gbp buildpackage --git-ignore-new
> --extra-package=3D/home/eamanu/Debian/DEPENDENCIES/python3-cleo_0.8.1-= 1_all.deb
> --extra-package=3D/home/eamanu/Debian/DEPENDENCIES/python3-httpretty_1= .0.5-0.1_all.deb
> --extra-package=3D/home/eamanu/Debian/DEPENDENCIES/python3-pkginfo_1.7= .0-1_all.deb

This package has not been updated on Salsa, or at least, I couldn't fin= d
version 1.7.0-1 anywhere. Maybe you forgot to push?

Oh yes, I'm just psuh to salsa. Sorry!
=

Cheers!
Emmanuel
--000000000000268b6e05ca779b79--