Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.kernel > #66585 > unrolled thread

Bug#954778: linux-image-amd64: if using make bindeb-pkg there is a warning about the missing debug package

Back to article view | Back to linux.debian.kernel

Contents

  Bug#954778: linux-image-amd64: if using make bindeb-pkg there is a warning about the missing debug package Reinhard Karcher <reinhard.karcher@gmx.net> - 2020-03-23 12:40 +0100
    Processed: Re: Bug#954778: linux-image-amd64: if using make  bindeb-pkg there is a warning about the missing debug package "Debian Bug Tracking System" <owner@bugs.debian.org> - 2020-03-24 00:20 +0100
    Bug#954778: linux-image-amd64: if using make bindeb-pkg there is a warning about the missing debug package Ben Hutchings <ben@decadent.org.uk> - 2020-03-24 00:20 +0100
    Bug#954778: Patch: Suppress irrelevant warning when generating a debian package Reinhard Karcher <reinhard.karcher@gmx.net> - 2020-03-24 11:30 +0100
      Bug#954778: Patch: Suppress irrelevant warning when generating a debian package Masahiro Yamada <masahiroy@kernel.org> - 2020-03-29 14:30 +0200
        Bug#954778: Patch: Suppress irrelevant warning when generating a debian package Reinhard Karcher <reinhard.karcher@gmx.net> - 2020-03-29 15:00 +0200
          Bug#954778: Patch: Suppress irrelevant warning when generating a debian package Masahiro Yamada <masahiroy@kernel.org> - 2020-03-29 15:40 +0200
            Bug#954778: Patch: Suppress irrelevant warning when generating a debian package Reinhard Karcher <reinhard.karcher@gmx.net> - 2020-03-29 16:40 +0200
            Bug#954778: Patch: Suppress irrelevant warning when generating a debian package Reinhard Karcher <reinhard.karcher@gmx.net> - 2020-03-29 17:10 +0200
              Bug#954778: Patch: Suppress irrelevant warning when generating a debian package Masahiro Yamada <masahiroy@kernel.org> - 2020-03-30 02:40 +0200
    Bug#954778: marked as done (linux-image-amd64: if using make  bindeb-pkg there is a warning about the missing debug package) "Debian Bug Tracking System" <owner@bugs.debian.org> - 2020-06-22 11:30 +0200

#66585 — Bug#954778: linux-image-amd64: if using make bindeb-pkg there is a warning about the missing debug package

[Multipart message — attachments visible in raw view] — view raw

Package: linux-image-amd64
Version: 5.4.19-1
Severity: wishlist
Tags: patch

Dear Maintainer,


   * What led up to the situation?
     Compiling a new kernel from the source

   * What exactly did you do (or not do) that was effective (or
     ineffective)?
     make -j10 bindeb-pkg

   * What was the outcome of this action?
     A warning that there is no debug package

   * What outcome did you expect instead?
     No such warning.

I attach a patch to include the debug package in the
control file only if it is built later


-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (101, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.6.0-rc7 (SMP w/8 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE=de
(charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages linux-image-amd64 depends on:
ii  linux-image-5.4.0-4-amd64  5.4.19-1

linux-image-amd64 recommends no packages.

linux-image-amd64 suggests no packages.

[toc] | [next] | [standalone]

#66587 — Processed: Re: Bug#954778: linux-image-amd64: if using make bindeb-pkg there is a warning about the missing debug package

Processing control commands:

> tag -1 upstream
Bug #954778 [linux-image-amd64] linux-image-amd64: if using make bindeb-pkg there is a warning about the missing debug package
Added tag(s) upstream.

-- 
954778: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=954778
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

[toc] | [prev] | [next] | [standalone]

#66588

[Multipart message — attachments visible in raw view] — view raw

Control: tag -1 upstream

On Mon, 2020-03-23 at 12:31 +0100, Reinhard Karcher wrote:
[...]
> I attach a patch to include the debug package in the
> control file only if it is built later

Please send the patch upstream (linux-kbuild@vger.kernel.org),
following instructions at
<https://www.kernel.org/doc/html/latest/process/submitting-patches.html>,
and cc this bug report (954778@bugs.debian.org).

Ben.

-- 
Ben Hutchings
Time is nature's way of making sure that
everything doesn't happen at once.

[toc] | [prev] | [next] | [standalone]

#66591 — Bug#954778: Patch: Suppress irrelevant warning when generating a debian package

Creating a Debian package by compiling the kernel using make bindeb-pkg
without creating debug information creates a warning that no
debug package was created.
This patch excludes the debug package from the control file,
if no debug package is created by this configuration.

By making a contribution to this project, I certify that:
The contribution was created in whole or in part by me and I have the right to
submit it under the open source license indicated in the file.
Signed-off-by: Reinhard Karcher <reinhard.karcher@gmx.net>
---
The condition to include the debug package is copied from the file
builddeb in the same directory.

diff --git a/scripts/package/mkdebian b/scripts/package/mkdebian
index 357dc56bcf30..1673b9f84804 100755
--- a/scripts/package/mkdebian
+++ b/scripts/package/mkdebian
@@ -198,7 +198,10 @@ Description: Linux support headers for userspace
development
  This package provides userspaces headers from the Linux kernel.  These
headers
  are used by the installed headers for GNU glibc and other system libraries.
 Multi-Arch: same
+EOF

+if [ -n "$BUILD_DEBUG" ] ; then
+cat <<EOF >> debian/control
 Package: $dbg_packagename
 Section: debug
 Architecture: $debarch
@@ -206,6 +209,7 @@ Description: Linux kernel debugging symbols for $version
  This package will come in handy if you need to debug the kernel. It provides
  all the necessary debug symbols for the kernel and its modules.
 EOF
+fi

 cat <<EOF > debian/rules
 #!$(command -v $MAKE) -f

[toc] | [prev] | [next] | [standalone]

#66619 — Bug#954778: Patch: Suppress irrelevant warning when generating a debian package

On Tue, Mar 24, 2020 at 7:24 PM Reinhard Karcher
<reinhard.karcher@gmx.net> wrote:
>
> Creating a Debian package by compiling the kernel using make bindeb-pkg
> without creating debug information creates a warning that no
> debug package was created.
> This patch excludes the debug package from the control file,
> if no debug package is created by this configuration.

OK, this seems correct.

> By making a contribution to this project, I certify that:
> The contribution was created in whole or in part by me and I have the right to
> submit it under the open source license indicated in the file.

Please drop this.

Signed-off-by implies this.
No need to explain this in an individual patch.


> Signed-off-by: Reinhard Karcher <reinhard.karcher@gmx.net>
> ---
> The condition to include the debug package is copied from the file
> builddeb in the same directory.
>
> diff --git a/scripts/package/mkdebian b/scripts/package/mkdebian
> index 357dc56bcf30..1673b9f84804 100755
> --- a/scripts/package/mkdebian
> +++ b/scripts/package/mkdebian
> @@ -198,7 +198,10 @@ Description: Linux support headers for userspace
> development
>   This package provides userspaces headers from the Linux kernel.  These
> headers
>   are used by the installed headers for GNU glibc and other system libraries.
>  Multi-Arch: same
> +EOF
>
> +if [ -n "$BUILD_DEBUG" ] ; then


This file does not define BUILD_DEBUG.
So, this conditional is always false, isn't it?

It should be:

if is_enabled CONFIG_DEBUG_INFO; then




> +cat <<EOF >> debian/control
>  Package: $dbg_packagename
>  Section: debug
>  Architecture: $debarch
> @@ -206,6 +209,7 @@ Description: Linux kernel debugging symbols for $version
>   This package will come in handy if you need to debug the kernel. It provides
>   all the necessary debug symbols for the kernel and its modules.
>  EOF
> +fi
>
>  cat <<EOF > debian/rules
>  #!$(command -v $MAKE) -f
>
>
>


-- 
Best Regards
Masahiro Yamada

[toc] | [prev] | [next] | [standalone]

#66620 — Bug#954778: Patch: Suppress irrelevant warning when generating a debian package

[Multipart message — attachments visible in raw view] — view raw

Am Sonntag, 29. März 2020, 14:01 schrieb Masahiro Yamada:
> 
> > By making a contribution to this project, I certify that:
> > The contribution was created in whole or in part by me and I have the
> > right to submit it under the open source license indicated in the file.
> 
> Please drop this.
> 
> Signed-off-by implies this.
> No need to explain this in an individual patch.

Droped in attached new version.

> > +if [ -n "$BUILD_DEBUG" ] ; then
> 
> This file does not define BUILD_DEBUG.
> So, this conditional is always false, isn't it?
> 
> It should be:
> 
> if is_enabled CONFIG_DEBUG_INFO; then
> 

The definition of BUILD_DEBUG is copied from builddeb too. 
See attached patch.

--
Best regards
Reinhard Karcher

[toc] | [prev] | [next] | [standalone]

#66621 — Bug#954778: Patch: Suppress irrelevant warning when generating a debian package

On Sun, Mar 29, 2020 at 9:57 PM Reinhard Karcher
<reinhard.karcher@gmx.net> wrote:
>
> Am Sonntag, 29. März 2020, 14:01 schrieb Masahiro Yamada:
> >
> > > By making a contribution to this project, I certify that:
> > > The contribution was created in whole or in part by me and I have the
> > > right to submit it under the open source license indicated in the file.
> >
> > Please drop this.
> >
> > Signed-off-by implies this.
> > No need to explain this in an individual patch.
>
> Droped in attached new version.
>
> > > +if [ -n "$BUILD_DEBUG" ] ; then
> >
> > This file does not define BUILD_DEBUG.
> > So, this conditional is always false, isn't it?
> >
> > It should be:
> >
> > if is_enabled CONFIG_DEBUG_INFO; then
> >
>
> The definition of BUILD_DEBUG is copied from builddeb too.
> See attached patch.


No.

I want you to directly use

if is_enabled CONFIG_DEBUG_INFO; then
...
fi





I guess builddeb used BUILD_DEBUG
to avoid running grep twice.

It does not apply to mkdebian.



-- 
Best Regards
Masahiro Yamada

[toc] | [prev] | [next] | [standalone]

#66622 — Bug#954778: Patch: Suppress irrelevant warning when generating a debian package

[Multipart message — attachments visible in raw view] — view raw

Am Sonntag, 29. März 2020, 15:30 schrieb Masahiro Yamada:
> 
> I want you to directly use
> 
> if is_enabled CONFIG_DEBUG_INFO; then
> ...
> fi
> 

Corrected patch attached

--
Best regards
Reinhard Karcher

[toc] | [prev] | [next] | [standalone]

#66623 — Bug#954778: Patch: Suppress irrelevant warning when generating a debian package

[Multipart message — attachments visible in raw view] — view raw

There was a blank line missing between the package definitions.
Sorry for late testing.

--
Best regards
Reinhard Karcher

[toc] | [prev] | [next] | [standalone]

#66629 — Bug#954778: Patch: Suppress irrelevant warning when generating a debian package

On Mon, Mar 30, 2020 at 12:01 AM Reinhard Karcher
<reinhard.karcher@gmx.net> wrote:
>
> There was a blank line missing between the package definitions.
> Sorry for late testing.
>
> --
> Best regards
> Reinhard Karcher


The attached patch is not in a correct patch format.

This time, I manually crufted the format, and applied.

But, next time, please send it to ML instead of attachment,
in a correct format.

git supports useful commands to do this.

  [1]  "git format-patch"  to create a patch
  [2]  "git send-email" to send it to ML


I reworded the log as follows:

------------------>8---------------
kbuild: deb-pkg: fix warning when CONFIG_DEBUG_INFO is unset

Creating a Debian package without CONFIG_DEBUG_INFO produces
a warning that no debug package was created.

This patch excludes the debug package from the control file,
if no debug package is created by this configuration.

Signed-off-by: Reinhard Karcher <reinhard.karcher@gmx.net>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
------------------>8---------------


-- 
Best Regards
Masahiro Yamada

[toc] | [prev] | [next] | [standalone]

#67357 — Bug#954778: marked as done (linux-image-amd64: if using make bindeb-pkg there is a warning about the missing debug package)

[Multipart message — attachments visible in raw view] — view raw

Your message dated Mon, 22 Jun 2020 11:22:16 +0200
with message-id <4888497.0TKaKLWQZd@apollon>
and subject line Bug#954778: Suppress irrelevant warning when generating a debian package
has caused the Debian Bug report #954778,
regarding linux-image-amd64: if using make bindeb-pkg there is a warning about the missing debug package
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
954778: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=954778
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.kernel

csiph-web