Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #1002068

Bug#954778: Patch: Suppress irrelevant warning when generating a debian package

Cross-posted to 2 groups.

Show all headers | View raw

On Tue, Mar 24, 2020 at 7:24 PM Reinhard Karcher
<reinhard.karcher@gmx.net> wrote:
>
> Creating a Debian package by compiling the kernel using make bindeb-pkg
> without creating debug information creates a warning that no
> debug package was created.
> This patch excludes the debug package from the control file,
> if no debug package is created by this configuration.

OK, this seems correct.

> By making a contribution to this project, I certify that:
> The contribution was created in whole or in part by me and I have the right to
> submit it under the open source license indicated in the file.

Please drop this.

Signed-off-by implies this.
No need to explain this in an individual patch.


> Signed-off-by: Reinhard Karcher <reinhard.karcher@gmx.net>
> ---
> The condition to include the debug package is copied from the file
> builddeb in the same directory.
>
> diff --git a/scripts/package/mkdebian b/scripts/package/mkdebian
> index 357dc56bcf30..1673b9f84804 100755
> --- a/scripts/package/mkdebian
> +++ b/scripts/package/mkdebian
> @@ -198,7 +198,10 @@ Description: Linux support headers for userspace
> development
>   This package provides userspaces headers from the Linux kernel.  These
> headers
>   are used by the installed headers for GNU glibc and other system libraries.
>  Multi-Arch: same
> +EOF
>
> +if [ -n "$BUILD_DEBUG" ] ; then


This file does not define BUILD_DEBUG.
So, this conditional is always false, isn't it?

It should be:

if is_enabled CONFIG_DEBUG_INFO; then




> +cat <<EOF >> debian/control
>  Package: $dbg_packagename
>  Section: debug
>  Architecture: $debarch
> @@ -206,6 +209,7 @@ Description: Linux kernel debugging symbols for $version
>   This package will come in handy if you need to debug the kernel. It provides
>   all the necessary debug symbols for the kernel and its modules.
>  EOF
> +fi
>
>  cat <<EOF > debian/rules
>  #!$(command -v $MAKE) -f
>
>
>


-- 
Best Regards
Masahiro Yamada

Back to linux.debian.bugs.dist | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Bug#954778: linux-image-amd64: if using make bindeb-pkg there is a warning about the missing debug package Reinhard Karcher <reinhard.karcher@gmx.net> - 2020-03-23 12:40 +0100
  Bug#954778: linux-image-amd64: if using make bindeb-pkg there is a warning about the missing debug package Ben Hutchings <ben@decadent.org.uk> - 2020-03-24 00:20 +0100
  Bug#954778: Patch: Suppress irrelevant warning when generating a debian package Reinhard Karcher <reinhard.karcher@gmx.net> - 2020-03-24 11:30 +0100
    Bug#954778: Patch: Suppress irrelevant warning when generating a debian package Masahiro Yamada <masahiroy@kernel.org> - 2020-03-29 14:30 +0200
      Bug#954778: Patch: Suppress irrelevant warning when generating a debian package Reinhard Karcher <reinhard.karcher@gmx.net> - 2020-03-29 15:00 +0200
        Bug#954778: Patch: Suppress irrelevant warning when generating a debian package Masahiro Yamada <masahiroy@kernel.org> - 2020-03-29 15:40 +0200
          Bug#954778: Patch: Suppress irrelevant warning when generating a debian package Reinhard Karcher <reinhard.karcher@gmx.net> - 2020-03-29 16:40 +0200
          Bug#954778: Patch: Suppress irrelevant warning when generating a debian package Reinhard Karcher <reinhard.karcher@gmx.net> - 2020-03-29 17:10 +0200
            Bug#954778: Patch: Suppress irrelevant warning when generating a debian package Masahiro Yamada <masahiroy@kernel.org> - 2020-03-30 02:40 +0200

csiph-web