Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.debian.kernel > #57726 > unrolled thread

armel/marvell kernel size

Started byBen Hutchings <ben@decadent.org.uk>
First post2017-05-04 00:20 +0200
Last post2017-08-27 17:40 +0200
Articles 6 on this page of 26 — 5 participants

Back to article view | Back to linux.debian.kernel


Contents

  armel/marvell kernel size Ben Hutchings <ben@decadent.org.uk> - 2017-05-04 00:20 +0200
    Re: armel/marvell kernel size Roger Shimizu <rogershimizu@gmail.com> - 2017-05-06 07:50 +0200
      Re: armel/marvell kernel size Martin Michlmayr <tbm@cyrius.com> - 2017-05-08 16:10 +0200
        Re: armel/marvell kernel size Roger Shimizu <rogershimizu@gmail.com> - 2017-05-08 16:30 +0200
    Re: armel/marvell kernel size Ben Hutchings <ben@decadent.org.uk> - 2017-07-22 01:50 +0200
      Re: armel/marvell kernel size Roger Shimizu <rogershimizu@gmail.com> - 2017-07-22 17:40 +0200
        Re: armel/marvell kernel size Ben Hutchings <ben@decadent.org.uk> - 2017-07-22 18:30 +0200
      Re: armel/marvell kernel size Roger Shimizu <rogershimizu@gmail.com> - 2017-07-30 20:30 +0200
        Re: armel/marvell kernel size Ben Hutchings <ben@decadent.org.uk> - 2017-07-30 21:40 +0200
        Re: armel/marvell kernel size Ian Campbell <ijc@hellion.org.uk> - 2017-07-31 00:50 +0200
          Re: armel/marvell kernel size Roger Shimizu <rogershimizu@gmail.com> - 2017-07-31 02:30 +0200
        Re: armel/marvell kernel size Roger Shimizu <rogershimizu@gmail.com> - 2017-07-31 17:10 +0200
          Re: armel/marvell kernel size Roger Shimizu <rogershimizu@gmail.com> - 2017-08-17 18:20 +0200
          Bug#870185: armel/marvell kernel size Roger Shimizu <rogershimizu@gmail.com> - 2017-08-19 06:10 +0200
            Bug#870185: armel/marvell kernel size Ian Campbell <ijc@debian.org> - 2017-08-19 18:00 +0200
              Bug#870185: armel/marvell kernel size Roger Shimizu <rogershimizu@gmail.com> - 2017-08-19 19:40 +0200
                Bug#870185: armel/marvell kernel size Ben Hutchings <ben@decadent.org.uk> - 2017-08-20 00:00 +0200
                  Bug#870185: armel/marvell kernel size Roger Shimizu <rogershimizu@gmail.com> - 2017-08-20 14:30 +0200
                    Bug#870185: armel/marvell kernel size Ben Hutchings <ben@decadent.org.uk> - 2017-08-20 17:50 +0200
                      Bug#870185: armel/marvell kernel size Roger Shimizu <rogershimizu@gmail.com> - 2017-08-21 02:40 +0200
                        Bug#870185: armel/marvell kernel size Roger Shimizu <rogershimizu@gmail.com> - 2017-08-21 18:30 +0200
                          Bug#870185: armel/marvell kernel size Ben Hutchings <ben@decadent.org.uk> - 2017-08-21 20:00 +0200
                            Bug#870185: armel/marvell kernel size Roger Shimizu <rogershimizu@gmail.com> - 2017-08-26 18:40 +0200
                              Bug#870185: armel/marvell kernel size Roger Shimizu <rogershimizu@gmail.com> - 2017-08-26 18:40 +0200
                                Bug#870185: armel/marvell kernel size Roger Shimizu <rogershimizu@gmail.com> - 2017-08-27 17:40 +0200
                                  Bug#870185: armel/marvell kernel size Ben Hutchings <ben@decadent.org.uk> - 2017-08-27 17:40 +0200

Page 2 of 2 — ← Prev page 1 [2]


#58732 — Bug#870185: armel/marvell kernel size

FromRoger Shimizu <rogershimizu@gmail.com>
Date2017-08-21 18:30 +0200
SubjectBug#870185: armel/marvell kernel size
Message-ID<ugXKp-6Fz-5@gated-at.bofh.it>
In reply to#58728
Control: tag -1 +pending

On Mon, Aug 21, 2017 at 9:28 AM, Roger Shimizu <rogershimizu@gmail.com> wrote:
> On Mon, Aug 21, 2017 at 12:43 AM, Ben Hutchings <ben@decadent.org.uk> wrote:
>>
>> OK, then try using 4.11.6 source and bisecting the Debian config
>> changes.
>
> Result:
> 0905519af414d339f615d7aac974f9a9163cdbd3 is the first bad commit

So I confirmed the only problem is CONFIG_STRICT_KERNEL_RWX
Added a commit to disable STRICT_KERNEL_RWX for armel.
After cherry-pick this commit to 4.11.6-1 and 4.12.6-1, I confirmed
the kernel boot again on my linkstation device.

Added another commit on branch rosh/check-size2, that check the
decompressed image size.
I confirmed it works. Please kindly review. Thank you!

Cheers,
-- 
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 4096R/6C6ACD6417B3ACB1

[toc] | [prev] | [next] | [standalone]


#58733 — Bug#870185: armel/marvell kernel size

FromBen Hutchings <ben@decadent.org.uk>
Date2017-08-21 20:00 +0200
SubjectBug#870185: armel/marvell kernel size
Message-ID<ugZ9v-7pX-5@gated-at.bofh.it>
In reply to#58732

[Multipart message — attachments visible in raw view] — view raw

On Tue, 2017-08-22 at 01:22 +0900, Roger Shimizu wrote:
> Control: tag -1 +pending
> 
> On Mon, Aug 21, 2017 at 9:28 AM, Roger Shimizu <rogershimizu@gmail.com> wrote:
> > On Mon, Aug 21, 2017 at 12:43 AM, Ben Hutchings <ben@decadent.org.uk> wrote:
> > > 
> > > OK, then try using 4.11.6 source and bisecting the Debian config
> > > changes.
> > 
> > Result:
> > 0905519af414d339f615d7aac974f9a9163cdbd3 is the first bad commit
> 
> So I confirmed the only problem is CONFIG_STRICT_KERNEL_RWX
> Added a commit to disable STRICT_KERNEL_RWX for armel.
> After cherry-pick this commit to 4.11.6-1 and 4.12.6-1, I confirmed
> the kernel boot again on my linkstation device.

Oh I see, that adds section (1 MiB) alignment in several places. 
Surprisingly, the padding isn't completely zero-filled, so it inflates
the compressed image size too.

> Added another commit on branch rosh/check-size2, that check the
> decompressed image size.
> I confirmed it works. Please kindly review. Thank you!

Please choose a more meaningful name than 'image2' e.g. 'uncompressed-
image'.

For the size check, you're mostly duplicating the existing check_size()
function.  It would be preferable to have a single function with some
extra parameters so that it can do both compressed and uncompressed
size checks.

Ben.

-- 
Ben Hutchings
Make three consecutive correct guesses and you will be considered an
expert.

[toc] | [prev] | [next] | [standalone]


#58762 — Bug#870185: armel/marvell kernel size

FromRoger Shimizu <rogershimizu@gmail.com>
Date2017-08-26 18:40 +0200
SubjectBug#870185: armel/marvell kernel size
Message-ID<uiMhQ-3vg-11@gated-at.bofh.it>
In reply to#58733
On Tue, Aug 22, 2017 at 2:55 AM, Ben Hutchings <ben@decadent.org.uk> wrote:
> On Tue, 2017-08-22 at 01:22 +0900, Roger Shimizu wrote:
>
> Oh I see, that adds section (1 MiB) alignment in several places.
> Surprisingly, the padding isn't completely zero-filled, so it inflates
> the compressed image size too.

Good to know the details.
Pushed the fix to branch master.

>> Added another commit on branch rosh/check-size2, that check the
>> decompressed image size.
>> I confirmed it works. Please kindly review. Thank you!
>
> Please choose a more meaningful name than 'image2' e.g. 'uncompressed-
> image'.
>
> For the size check, you're mostly duplicating the existing check_size()
> function.  It would be preferable to have a single function with some
> extra parameters so that it can do both compressed and uncompressed
> size checks.

Thanks for your review!
Pushed updated commit to branch rosh/check-uncompressed-size.

Cheers,
-- 
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 4096R/6C6ACD6417B3ACB1

[toc] | [prev] | [next] | [standalone]


#58763 — Bug#870185: armel/marvell kernel size

FromRoger Shimizu <rogershimizu@gmail.com>
Date2017-08-26 18:40 +0200
SubjectBug#870185: armel/marvell kernel size
Message-ID<uiMhQ-3vg-13@gated-at.bofh.it>
In reply to#58762
On Sun, Aug 27, 2017 at 1:27 AM, Roger Shimizu <rogershimizu@gmail.com> wrote:
> On Tue, Aug 22, 2017 at 2:55 AM, Ben Hutchings <ben@decadent.org.uk> wrote:
>> For the size check, you're mostly duplicating the existing check_size()
>> function.  It would be preferable to have a single function with some
>> extra parameters so that it can do both compressed and uncompressed
>> size checks.

Forgot to give out result of my test run.

$ debian/bin/buildcheck.py debian/build/build_armel_none_marvell armel
none marvell
Can't read ABI reference.  ABI not checked!
Image size 2084434/2097080, using 99.40%.  Under 1% space in
UNRELEASED.  Continuing.
Uncompressed Image size 5934896/7340032, using 80.86%.  Uncompressed
Image fits.  Continuing.

Cheers,
-- 
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 4096R/6C6ACD6417B3ACB1

[toc] | [prev] | [next] | [standalone]


#58792 — Bug#870185: armel/marvell kernel size

FromRoger Shimizu <rogershimizu@gmail.com>
Date2017-08-27 17:40 +0200
SubjectBug#870185: armel/marvell kernel size
Message-ID<uj7Pj-16w-15@gated-at.bofh.it>
In reply to#58763
On Sun, Aug 27, 2017 at 1:31 AM, Roger Shimizu <rogershimizu@gmail.com> wrote:
> On Sun, Aug 27, 2017 at 1:27 AM, Roger Shimizu <rogershimizu@gmail.com> wrote:
>> On Tue, Aug 22, 2017 at 2:55 AM, Ben Hutchings <ben@decadent.org.uk> wrote:
>>> For the size check, you're mostly duplicating the existing check_size()
>>> function.  It would be preferable to have a single function with some
>>> extra parameters so that it can do both compressed and uncompressed
>>> size checks.
>
> Forgot to give out result of my test run.
>
> $ debian/bin/buildcheck.py debian/build/build_armel_none_marvell armel
> none marvell
> Can't read ABI reference.  ABI not checked!
> Image size 2084434/2097080, using 99.40%.  Under 1% space in
> UNRELEASED.  Continuing.
> Uncompressed Image size 5934896/7340032, using 80.86%.  Uncompressed
> Image fits.  Continuing.

I changed a bit by adding more error checking, and pushed to the same branch.
now its hash code is cc7783a.

Another question, the main fix for the bug, which is the commit below,
is pushed to master.
Can I cherry-pick this commit to branch sid? Thanks!

====
commit d0704122dd83e5b4258184a0e92dc57934477c71
Author:     Roger Shimizu <rogershimizu@gmail.com>
AuthorDate: Tue Aug 22 01:01:21 2017 +0900
Commit:     Roger Shimizu <rogershimizu@gmail.com>
CommitDate: Tue Aug 22 01:01:21 2017 +0900

    [armel] Disable CONFIG_STRICT_KERNEL_RWX

    This will save about 3MB on linux Image (before compression).
    u-boot loader on some armel devices has limitation that:
     - kernel image size <= 2MB (already described in
    debian/config/armel/defines)
     - kernel size after decompression <= 7MB
====

Cheers,
-- 
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 4096R/6C6ACD6417B3ACB1

[toc] | [prev] | [next] | [standalone]


#58793 — Bug#870185: armel/marvell kernel size

FromBen Hutchings <ben@decadent.org.uk>
Date2017-08-27 17:40 +0200
SubjectBug#870185: armel/marvell kernel size
Message-ID<uj7Pk-16w-21@gated-at.bofh.it>
In reply to#58792

[Multipart message — attachments visible in raw view] — view raw

On Mon, 2017-08-28 at 00:34 +0900, Roger Shimizu wrote:
> On Sun, Aug 27, 2017 at 1:31 AM, Roger Shimizu <rogershimizu@gmail.com> wrote:
> > On Sun, Aug 27, 2017 at 1:27 AM, Roger Shimizu <rogershimizu@gmail.com> wrote:
> > > On Tue, Aug 22, 2017 at 2:55 AM, Ben Hutchings <ben@decadent.org.uk> wrote:
> > > > For the size check, you're mostly duplicating the existing check_size()
> > > > function.  It would be preferable to have a single function with some
> > > > extra parameters so that it can do both compressed and uncompressed
> > > > size checks.
> > 
> > Forgot to give out result of my test run.
> > 
> > $ debian/bin/buildcheck.py debian/build/build_armel_none_marvell armel
> > none marvell
> > Can't read ABI reference.  ABI not checked!
> > Image size 2084434/2097080, using 99.40%.  Under 1% space in
> > UNRELEASED.  Continuing.
> > Uncompressed Image size 5934896/7340032, using 80.86%.  Uncompressed
> > Image fits.  Continuing.
> 
> I changed a bit by adding more error checking, and pushed to the same branch.
> now its hash code is cc7783a.
> 
> Another question, the main fix for the bug, which is the commit below,
> is pushed to master.
> Can I cherry-pick this commit to branch sid? Thanks!
[...]

Yes, please do.

Ben.

-- 
Ben Hutchings
Teamwork is essential - it allows you to blame someone else.

[toc] | [prev] | [standalone]


Page 2 of 2 — ← Prev page 1 [2]

Back to top | Article view | linux.debian.kernel


csiph-web