Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.kernel > #58762

Bug#870185: armel/marvell kernel size

From Roger Shimizu <rogershimizu@gmail.com>
Newsgroups linux.debian.bugs.dist, linux.debian.kernel
Subject Bug#870185: armel/marvell kernel size
Date 2017-08-26 18:40 +0200
Message-ID <uiMhQ-3vg-11@gated-at.bofh.it> (permalink)
References (11 earlier) <ugIV3-5yZ-1@gated-at.bofh.it> <ugXKp-6Fz-5@gated-at.bofh.it> <ugZ9v-7pX-5@gated-at.bofh.it> <u92xA-4C8-19@gated-at.bofh.it> <ugZ9v-7pX-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Cross-posted to 2 groups.

Show all headers | View raw

On Tue, Aug 22, 2017 at 2:55 AM, Ben Hutchings <ben@decadent.org.uk> wrote:
> On Tue, 2017-08-22 at 01:22 +0900, Roger Shimizu wrote:
>
> Oh I see, that adds section (1 MiB) alignment in several places.
> Surprisingly, the padding isn't completely zero-filled, so it inflates
> the compressed image size too.

Good to know the details.
Pushed the fix to branch master.

>> Added another commit on branch rosh/check-size2, that check the
>> decompressed image size.
>> I confirmed it works. Please kindly review. Thank you!
>
> Please choose a more meaningful name than 'image2' e.g. 'uncompressed-
> image'.
>
> For the size check, you're mostly duplicating the existing check_size()
> function.  It would be preferable to have a single function with some
> extra parameters so that it can do both compressed and uncompressed
> size checks.

Thanks for your review!
Pushed updated commit to branch rosh/check-uncompressed-size.

Cheers,
-- 
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 4096R/6C6ACD6417B3ACB1

Back to linux.debian.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

armel/marvell kernel size Ben Hutchings <ben@decadent.org.uk> - 2017-05-04 00:20 +0200
  Re: armel/marvell kernel size Roger Shimizu <rogershimizu@gmail.com> - 2017-05-06 07:50 +0200
    Re: armel/marvell kernel size Martin Michlmayr <tbm@cyrius.com> - 2017-05-08 16:10 +0200
      Re: armel/marvell kernel size Roger Shimizu <rogershimizu@gmail.com> - 2017-05-08 16:30 +0200
  Re: armel/marvell kernel size Ben Hutchings <ben@decadent.org.uk> - 2017-07-22 01:50 +0200
    Re: armel/marvell kernel size Roger Shimizu <rogershimizu@gmail.com> - 2017-07-22 17:40 +0200
      Re: armel/marvell kernel size Ben Hutchings <ben@decadent.org.uk> - 2017-07-22 18:30 +0200
    Re: armel/marvell kernel size Roger Shimizu <rogershimizu@gmail.com> - 2017-07-30 20:30 +0200
      Re: armel/marvell kernel size Ben Hutchings <ben@decadent.org.uk> - 2017-07-30 21:40 +0200
      Re: armel/marvell kernel size Ian Campbell <ijc@hellion.org.uk> - 2017-07-31 00:50 +0200
        Re: armel/marvell kernel size Roger Shimizu <rogershimizu@gmail.com> - 2017-07-31 02:30 +0200
      Re: armel/marvell kernel size Roger Shimizu <rogershimizu@gmail.com> - 2017-07-31 17:10 +0200
        Re: armel/marvell kernel size Roger Shimizu <rogershimizu@gmail.com> - 2017-08-17 18:20 +0200
        Bug#870185: armel/marvell kernel size Roger Shimizu <rogershimizu@gmail.com> - 2017-08-19 06:10 +0200
          Bug#870185: armel/marvell kernel size Ian Campbell <ijc@debian.org> - 2017-08-19 18:00 +0200
            Bug#870185: armel/marvell kernel size Roger Shimizu <rogershimizu@gmail.com> - 2017-08-19 19:40 +0200
              Bug#870185: armel/marvell kernel size Ben Hutchings <ben@decadent.org.uk> - 2017-08-20 00:00 +0200
                Bug#870185: armel/marvell kernel size Roger Shimizu <rogershimizu@gmail.com> - 2017-08-20 14:30 +0200
                Bug#870185: armel/marvell kernel size Ben Hutchings <ben@decadent.org.uk> - 2017-08-20 17:50 +0200
                Bug#870185: armel/marvell kernel size Roger Shimizu <rogershimizu@gmail.com> - 2017-08-21 02:40 +0200
                Bug#870185: armel/marvell kernel size Roger Shimizu <rogershimizu@gmail.com> - 2017-08-21 18:30 +0200
                Bug#870185: armel/marvell kernel size Ben Hutchings <ben@decadent.org.uk> - 2017-08-21 20:00 +0200
                Bug#870185: armel/marvell kernel size Roger Shimizu <rogershimizu@gmail.com> - 2017-08-26 18:40 +0200
                Bug#870185: armel/marvell kernel size Roger Shimizu <rogershimizu@gmail.com> - 2017-08-26 18:40 +0200
                Bug#870185: armel/marvell kernel size Roger Shimizu <rogershimizu@gmail.com> - 2017-08-27 17:40 +0200
                Bug#870185: armel/marvell kernel size Ben Hutchings <ben@decadent.org.uk> - 2017-08-27 17:40 +0200

csiph-web