Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.debian.kernel > #77872 > unrolled thread
| Started by | Diederik de Haas <didi.debian@cknow.org> |
|---|---|
| First post | 2023-01-10 02:00 +0100 |
| Last post | 2023-01-10 02:00 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.debian.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Bug#855017: [PATCH] ARM: dts: kirkwood: Fix SATA pinmux-ing for TS419 Diederik de Haas <didi.debian@cknow.org> - 2023-01-10 02:00 +0100
Processed: Re: [PATCH] ARM: dts: kirkwood: Fix SATA pinmux-ing for TS419 "Debian Bug Tracking System" <owner@bugs.debian.org> - 2023-01-10 02:00 +0100
| From | Diederik de Haas <didi.debian@cknow.org> |
|---|---|
| Date | 2023-01-10 02:00 +0100 |
| Subject | Bug#855017: [PATCH] ARM: dts: kirkwood: Fix SATA pinmux-ing for TS419 |
| Message-ID | <FMb9D-gOq2-3@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
Control: forwarded -1 https://lore.kernel.org/all/877f41ovlu.fsf@free-electrons.com/
Hi Ben,
On 07 Mar 2017 18:16:45 +0100 Gregory CLEMENT <gregory.clement@free-electrons.com> wrote:
> On lun., févr. 20 2017, Ben Hutchings <ben@decadent.org.uk> wrote:
> > On Mon, 2017-02-20 at 17:50 +0100, Thomas Petazzoni wrote:
> >> On Mon, 20 Feb 2017 16:40:25 +0000, Ben Hutchings wrote:
> >>
> >> > That is precisely what I intended. 20-23 are used by the second
> >> > Ethernet port. The old board code doesn't assign 4 or 5 at all.
> >>
> >> Then I believe it would be more explicit to have separate pin muxing
> >> configurations for SATA on this board.
> >
> > You mean, define additional pinmux nodes and override the pinctrl-0
> > property of &sata? more like this:
> >
> > --- a/arch/arm/boot/dts/kirkwood-ts419.dtsi
> > +++ b/arch/arm/boot/dts/kirkwood-ts419.dtsi
> > @@ -73,3 +73,19 @@
> > phy-handle = <ðphy1>;
> > };
> > };
> > +
> > +&pinctrl {
> > + pmx_sata0_ts419: pmx-sata0-ts419 {
> > + marvell,pins = "mpp15";
> > + marvell,function = "sata0";
> > + };
> > +
> > + pmx_sata1_ts419: pmx-sata1-ts419 {
> > + marvell,pins = "mpp16";
> > + marvell,function = "sata1";
> > + };
> > +};
> > +
> > +&sata {
> > + pinctrl-0 = <&pmx_sata0_ts419 &pmx_sata1_ts419>;
> > +};
>
> If you send a new version of your patch, then I will be able to apply
> it on mvebu/dt.
>
> Thanks,
>
> Gregory
Would it be an idea to send the updated patch for inclusion in upstream?
It's almost 6 years old, but it seems that it can still be applied cleanly.
[toc] | [next] | [standalone]
| From | "Debian Bug Tracking System" <owner@bugs.debian.org> |
|---|---|
| Date | 2023-01-10 02:00 +0100 |
| Subject | Processed: Re: [PATCH] ARM: dts: kirkwood: Fix SATA pinmux-ing for TS419 |
| Message-ID | <FMb9D-gOq2-1@gated-at.bofh.it> |
| In reply to | #77872 |
Processing control commands:
> forwarded -1 https://lore.kernel.org/all/877f41ovlu.fsf@free-electrons.com/
Bug #855017 {Done: Ben Hutchings <ben@decadent.org.uk>} [src:linux] linux-image-4.9.0-1-marvell: eth1 not detected/available on QNAP TS-419pII
Set Bug forwarded-to-address to 'https://lore.kernel.org/all/877f41ovlu.fsf@free-electrons.com/'.
--
855017: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=855017
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
[toc] | [prev] | [standalone]
Back to top | Article view | linux.debian.kernel
csiph-web