Bug#855017: [PATCH] ARM: dts: kirkwood: Fix SATA pinmux-ing for TS419

From	Diederik de Haas <didi.debian@cknow.org>
Newsgroups	linux.debian.bugs.dist, linux.debian.kernel
Subject	Bug#855017: [PATCH] ARM: dts: kirkwood: Fix SATA pinmux-ing for TS419
Date	2023-01-10 02:00 +0100
Message-ID	<FMb9D-gOq2-3@gated-at.bofh.it> (permalink)
References	<talTI-2mg-15@gated-at.bofh.it> <tir5T-2l6-3@gated-at.bofh.it>
Organization	Connecting Knowledge

Cross-posted to 2 groups.

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Control: forwarded -1 https://lore.kernel.org/all/877f41ovlu.fsf@free-electrons.com/

Hi Ben,

On 07 Mar 2017 18:16:45 +0100 Gregory CLEMENT <gregory.clement@free-electrons.com> wrote:
>  On lun., févr. 20 2017, Ben Hutchings <ben@decadent.org.uk> wrote:
> > On Mon, 2017-02-20 at 17:50 +0100, Thomas Petazzoni wrote:
> >> On Mon, 20 Feb 2017 16:40:25 +0000, Ben Hutchings wrote:
> >> 
> >> > That is precisely what I intended.  20-23 are used by the second
> >> > Ethernet port.  The old board code doesn't assign 4 or 5 at all.
> >> 
> >> Then I believe it would be more explicit to have separate pin muxing
> >> configurations for SATA on this board.
> >
> > You mean, define additional pinmux nodes and override the pinctrl-0
> > property of &sata?  more like this:
> >
> > --- a/arch/arm/boot/dts/kirkwood-ts419.dtsi
> > +++ b/arch/arm/boot/dts/kirkwood-ts419.dtsi
> > @@ -73,3 +73,19 @@
> >  		phy-handle = <&ethphy1>;
> >  	};
> >  };
> > +
> > +&pinctrl {
> > +	pmx_sata0_ts419: pmx-sata0-ts419 {
> > +		marvell,pins = "mpp15";
> > +		marvell,function = "sata0";
> > +	};
> > +
> > +	pmx_sata1_ts419: pmx-sata1-ts419 {
> > +		marvell,pins = "mpp16";
> > +		marvell,function = "sata1";
> > +	};
> > +};
> > +
> > +&sata {
> > +	pinctrl-0 = <&pmx_sata0_ts419 &pmx_sata1_ts419>;
> > +};
> 
> If you send a new version of your patch, then I will be able to apply
> it on mvebu/dt.
> 
> Thanks,
> 
> Gregory

Would it be an idea to send the updated patch for inclusion in upstream?
It's almost 6 years old, but it seems that it can still be applied cleanly.

Back to linux.debian.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Bug#855017: [PATCH] ARM: dts: kirkwood: Fix SATA pinmux-ing for TS419 Diederik de Haas <didi.debian@cknow.org> - 2023-01-10 02:00 +0100
  Processed: Re: [PATCH] ARM: dts: kirkwood: Fix SATA pinmux-ing  for TS419 "Debian Bug Tracking System" <owner@bugs.debian.org> - 2023-01-10 02:00 +0100

csiph-web