Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.kernel > #69528 > unrolled thread

Bug#982757: firmware-brcm80211: [REGRESSION] brcm/brcmfmac43340-sdio.bin missing in sid (20210208-1)

Back to article view | Back to linux.debian.kernel

Contents

  Bug#982757: firmware-brcm80211: [REGRESSION] brcm/brcmfmac43340-sdio.bin missing in sid (20210208-1) yan <yan@exalot.com> - 2021-02-14 00:50 +0100
    Bug#982757: firmware-brcm80211: [REGRESSION] brcm/brcmfmac43340-sdio.bin missing in sid (20210208-1) maximilian attems <maks@stro.at> - 2021-02-16 08:40 +0100
    Bug#982757: firmware-brcm80211: [REGRESSION] brcm/brcmfmac43340-sdio.bin missing in sid (20210208-1) Andreas Henriksson <andreas@fatal.se> - 2021-02-16 23:00 +0100
    Bug#982757: firmware-brcm80211: [REGRESSION] brcm/brcmfmac43340-sdio.bin missing in sid (20210208-1) Andreas Henriksson <andreas@fatal.se> - 2021-02-17 10:20 +0100

#69528 — Bug#982757: firmware-brcm80211: [REGRESSION] brcm/brcmfmac43340-sdio.bin missing in sid (20210208-1)

Package: firmware-brcm80211
Version: 20201218-3
Severity: normal

Dear Maintainer,

after latest update wifi stopped working and I saw that brcm/brcmfmac43340-sdio.bin was missing,
so I downgraded to the version from testing and it works again. please include again!

Thank You!

 --Jan Hetges

-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 5.10.0-3-686 (SMP w/4 CPU threads)
Kernel taint flags: TAINT_WARN
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

firmware-brcm80211 depends on no packages.

firmware-brcm80211 recommends no packages.

Versions of packages firmware-brcm80211 suggests:
ii  initramfs-tools  0.139

-- no debconf information

[toc] | [next] | [standalone]

#69555

[Multipart message — attachments visible in raw view] — view raw

severity 982757 critical
stop

> Version: 20201218-3
> Severity: normal

thank you for the report, oh boy this one is opens a can of trouble.
It seems I was blissfully unaware that the Debian packaging did not
take into account the symlinks of upstream linux-firmware WHENCE file.
So this means we are missing a *lot* - all the symlinks!?!?
 
> after latest update wifi stopped working and I saw that brcm/brcmfmac43340-sdio.bin was missing,

right it was replaced by newer cypress version and there should be
a symlink of that guy from the older name:

 Link: brcm/brcmfmac43340-sdio.bin -> ../cypress/cyfmac43340-sdio.bin

Could you please test latest 2021 upstream package with this symlink?

kind regards,

-- 
maks

[toc] | [prev] | [next] | [standalone]

#69560

On Tue, Feb 16, 2021 at 10:35:53PM +0100, Andreas Henriksson wrote:
> Control: notfound -1 20201218-3
> Control: found -1 20210208-1
> 
> On Tue, Feb 16, 2021 at 08:20:47AM +0100, maximilian attems wrote:
> [...]
> > right it was replaced by newer cypress version and there should be
> > a symlink of that guy from the older name:
> > 
> >  Link: brcm/brcmfmac43340-sdio.bin -> ../cypress/cyfmac43340-sdio.bin
> > 
> > Could you please test latest 2021 upstream package with this symlink?
> 
> It seems the bug report was filed against the (working) testing version
> when (as said in subject) the problem is really in the 2021 unstable
> version. Adjusted bug metadata accordingly. (I've confirmed by checking
> the content of both versions myself.)
> 
> It seems the reason that brcm/brcmfmac43340-sdio.bin symlink is missing
> is this:
> 
> The symlink first gets installed in debian/build/install ... then
... the rest on my analysis was completly wrong.

Actually I think the problem is this commit:
https://salsa.debian.org/kernel-team/firmware-nonfree/-/commit/9c597cb850e77c2bff39378503849a92ff522353

Regards,
Andreas Henriksson

[toc] | [prev] | [next] | [standalone]

#69565

On Tue, Feb 16, 2021 at 11:46:26PM +0100, maximilian attems wrote:
> > Actually I think the problem is this commit:
> > https://salsa.debian.org/kernel-team/firmware-nonfree/-/commit/9c597cb850e77c2bff39378503849a92ff522353
> 
> this commit is just fine, the debian package just needs to have the
> corresponding symlinks to the newer version.

FYI I've now tested reverting that commit and the symlinks are back:

Here's the sid vs sid+revert binary package content (files) diff:

--- fbr-sid-files.txt	2021-02-17 09:39:13.679336856 +0100
+++ fbr-sid-rev9c597cb850e7-files.txt	2021-02-17 10:00:12.730055901 +0100
@@ -63,4 +63,13 @@
 ./usr/share/doc/firmware-brcm80211/copyright
 ./usr/share/metainfo/
 ./usr/share/metainfo/firmware-brcm80211.metainfo.xml
+./lib/firmware/brcm/brcmfmac43340-sdio.bin
+./lib/firmware/brcm/brcmfmac43362-sdio.bin
+./lib/firmware/brcm/brcmfmac4339-sdio.bin
+./lib/firmware/brcm/brcmfmac43430-sdio.bin
+./lib/firmware/brcm/brcmfmac43455-sdio.bin
+./lib/firmware/brcm/brcmfmac4354-sdio.bin
+./lib/firmware/brcm/brcmfmac4356-pcie.bin
 ./lib/firmware/brcm/brcmfmac4356-sdio.bin
+./lib/firmware/brcm/brcmfmac43570-pcie.bin
+./lib/firmware/brcm/brcmfmac4373-sdio.bin

And yes, they are all symlinks... eg from the patched/rebuilt package:
$ dpkg -c patched/firmware-brcm80211_20210208-1_all.deb | grep brcmfmac43340-sdio
lrwxrwxrwx root/root         0 2021-02-17 09:58 ./lib/firmware/brcm/brcmfmac43340-sdio.bin -> ../cypress/cyfmac43340-sdio.bin




Note also that this is definitely not a general problem with symlinks
as even the existing package in sid has atleast one symlink in it still:

$ dpkg -c sid/firmware-brcm80211_20210208-1_all.deb  | grep -- '->'
lrwxrwxrwx root/root         0 2021-02-09 11:15 ./lib/firmware/brcm/brcmfmac4356-sdio.bin -> ../cypress/cyfmac4356-sdio.bin


The problem is simply that the symlinks are being installed into
debian/build/install/ but then they are not moved over to the
debian/firmware-brcm80211 directory to be included in the binary package.
It might be helpful to improve the packaging logic so files are /moved/
from debian/build/install/ into the respective binary package directory
and then fail the build if debian/build/install/ still contains anything
(ie. similar to --fail-missing in generic dh packages).

Regards,
Andreas Henriksson

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.kernel

csiph-web