Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.debian.kernel > #69565
| From | Andreas Henriksson <andreas@fatal.se> |
|---|---|
| Newsgroups | linux.debian.bugs.dist, linux.debian.kernel |
| Subject | Bug#982757: firmware-brcm80211: [REGRESSION] brcm/brcmfmac43340-sdio.bin missing in sid (20210208-1) |
| Date | 2021-02-17 10:20 +0100 |
| Message-ID | <BJra1-7Iy-1@gated-at.bofh.it> (permalink) |
| References | (2 earlier) <BJgeB-8p6-1@gated-at.bofh.it> <BJgxX-8vM-1@gated-at.bofh.it> <BJra1-7Iy-3@gated-at.bofh.it> <BIcPL-2Vf-3@gated-at.bofh.it> <BJra1-7Iy-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Cross-posted to 2 groups.
On Tue, Feb 16, 2021 at 11:46:26PM +0100, maximilian attems wrote: > > Actually I think the problem is this commit: > > https://salsa.debian.org/kernel-team/firmware-nonfree/-/commit/9c597cb850e77c2bff39378503849a92ff522353 > > this commit is just fine, the debian package just needs to have the > corresponding symlinks to the newer version. FYI I've now tested reverting that commit and the symlinks are back: Here's the sid vs sid+revert binary package content (files) diff: --- fbr-sid-files.txt 2021-02-17 09:39:13.679336856 +0100 +++ fbr-sid-rev9c597cb850e7-files.txt 2021-02-17 10:00:12.730055901 +0100 @@ -63,4 +63,13 @@ ./usr/share/doc/firmware-brcm80211/copyright ./usr/share/metainfo/ ./usr/share/metainfo/firmware-brcm80211.metainfo.xml +./lib/firmware/brcm/brcmfmac43340-sdio.bin +./lib/firmware/brcm/brcmfmac43362-sdio.bin +./lib/firmware/brcm/brcmfmac4339-sdio.bin +./lib/firmware/brcm/brcmfmac43430-sdio.bin +./lib/firmware/brcm/brcmfmac43455-sdio.bin +./lib/firmware/brcm/brcmfmac4354-sdio.bin +./lib/firmware/brcm/brcmfmac4356-pcie.bin ./lib/firmware/brcm/brcmfmac4356-sdio.bin +./lib/firmware/brcm/brcmfmac43570-pcie.bin +./lib/firmware/brcm/brcmfmac4373-sdio.bin And yes, they are all symlinks... eg from the patched/rebuilt package: $ dpkg -c patched/firmware-brcm80211_20210208-1_all.deb | grep brcmfmac43340-sdio lrwxrwxrwx root/root 0 2021-02-17 09:58 ./lib/firmware/brcm/brcmfmac43340-sdio.bin -> ../cypress/cyfmac43340-sdio.bin Note also that this is definitely not a general problem with symlinks as even the existing package in sid has atleast one symlink in it still: $ dpkg -c sid/firmware-brcm80211_20210208-1_all.deb | grep -- '->' lrwxrwxrwx root/root 0 2021-02-09 11:15 ./lib/firmware/brcm/brcmfmac4356-sdio.bin -> ../cypress/cyfmac4356-sdio.bin The problem is simply that the symlinks are being installed into debian/build/install/ but then they are not moved over to the debian/firmware-brcm80211 directory to be included in the binary package. It might be helpful to improve the packaging logic so files are /moved/ from debian/build/install/ into the respective binary package directory and then fail the build if debian/build/install/ still contains anything (ie. similar to --fail-missing in generic dh packages). Regards, Andreas Henriksson
Back to linux.debian.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
Bug#982757: firmware-brcm80211: [REGRESSION] brcm/brcmfmac43340-sdio.bin missing in sid (20210208-1) yan <yan@exalot.com> - 2021-02-14 00:50 +0100 Bug#982757: firmware-brcm80211: [REGRESSION] brcm/brcmfmac43340-sdio.bin missing in sid (20210208-1) maximilian attems <maks@stro.at> - 2021-02-16 08:40 +0100 Bug#982757: firmware-brcm80211: [REGRESSION] brcm/brcmfmac43340-sdio.bin missing in sid (20210208-1) Andreas Henriksson <andreas@fatal.se> - 2021-02-16 23:00 +0100 Bug#982757: firmware-brcm80211: [REGRESSION] brcm/brcmfmac43340-sdio.bin missing in sid (20210208-1) Andreas Henriksson <andreas@fatal.se> - 2021-02-17 10:20 +0100
csiph-web