Re: [PATCH] tracing: Use strlcpy() instead of strcpy() in __trace_find_cmdline()

Path	csiph.com!news.mixmin.net!news.unit0.net!newsfeed.CARNet.hr!news.spin.it!bofh.it!news.nic.it!robomod
From	Loic <hackurx@opensec.fr>
Newsgroups	linux.debian.kernel
Subject	Re: [PATCH] tracing: Use strlcpy() instead of strcpy() in __trace_find_cmdline()
Date	Mon, 17 Dec 2018 21:10:02 +0100
Message-ID	<x67nb-2Cy-11@gated-at.bofh.it> (permalink)
References	<x67nb-2Cy-13@gated-at.bofh.it> <x67nb-2Cy-15@gated-at.bofh.it> <x67nb-2Cy-17@gated-at.bofh.it> <x67nb-2Cy-19@gated-at.bofh.it> <x67nb-2Cy-21@gated-at.bofh.it>
X-Mailbox-Line	From debian-kernel-request@lists.debian.org Mon Dec 17 20:07:07 2018
Old-Return-Path	<hackurx@opensec.fr>
X-Amavis-Spam-Status	No, score=-1.186 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, MURPHY_DRUGS_REL8=0.02, RCVD_IN_SORBS_DUL=0.001, RDNS_NONE=0.793] autolearn=no autolearn_force=no
X-Policyd-Weight	using cached result; rate: -6.1
X-Greylist	delayed 477 seconds by postgrey-1.36 at bendel; Mon, 17 Dec 2018 19:50:19 UTC
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding	8bit
Disposition-Notification-To	Loic <hackurx@opensec.fr>
X-Sender	hackurx@opensec.fr
User-Agent	OpenSEC Mail
X-Ksmg-Antivirus	Kaspersky Secure Mail Gateway
X-Mailing-List	<debian-kernel@lists.debian.org> archive/latest/118852
List-ID	<debian-kernel.lists.debian.org>
List-URL	<https://lists.debian.org/debian-kernel/>
List-Archive	https://lists.debian.org/msgid-search/6af2b12206e8a640a0a30f78d4414b56@opensec.fr
Approved	robomod@news.nic.it
Lines	50
Organization	linux.* mail to news gateway
Sender	robomod@news.nic.it
X-Original-Cc	Steven Rostedt <rostedt@goodmis.org>, stable@vger.kernel.org, ameyt@codeaurora.org, amit.pundir@linaro.org
X-Original-Date	Mon, 17 Dec 2018 20:42:38 +0100
X-Original-Message-ID	<6af2b12206e8a640a0a30f78d4414b56@opensec.fr>
X-Original-References	<20181215182537.e0f95a3bb791e4f68f23eac8@opensec.fr> <20181216085233.GC29097@kroah.com> <20181216142702.09ed540b@vmware.local.home> <44d50224c2b4fbe8b814da24a53f67c0@opensec.fr> <20181217081940.GA16452@kroah.com>
Xref	csiph.com linux.debian.kernel:62754

Show key headers only | View raw

Le 2018-12-17 09:19, Greg KH a écrit :
> On Sun, Dec 16, 2018 at 09:08:20PM +0100, Loic wrote:
>> Le 2018-12-16 20:27, Steven Rostedt a écrit :
>> > On Sun, 16 Dec 2018 09:52:33 +0100
>> > Greg KH <gregkh@linuxfoundation.org> wrote:
>> >
>> > > On Sat, Dec 15, 2018 at 06:25:37PM +0100, Loic wrote:
>> > > > Hello,
>> > > >
>> > > > Please picked up this patch for linux 4.4 and 4.9.
>> > > > This fixes CVE-2017-0605 (Rejected?). Tested in Debian ;)
>> > >
>> > > It was rejected as a CVE for a good reason, and that reason is also
>> > > why
>> > > I refused to add it to the stable kernel releases.  In short, this is
>> > > not an issue or bug at all, there is nothing wrong with the existing
>> > > code.
>> > >
>> >
>> > I'm starting to regret that I ever accepted the original patch :-(
>> >
>> > -- Steve
>> 
>> Okay, I hadn't looked at the previous conversations because this 
>> change is
>> in the upstream and in debian...
> 
> Upstream is fine, it's a valid change so that people don't keep sending
> the crazy patch over and over.
> 
> Debian is just cargo-culting the thing and should probably drop it as 
> it
> keeps coming back to me every 3 months or so, and I have to reject it
> again :(
> 
> thanks,
> 
> greg k-h

Why didn't you follow the upstream or add a comment "no change for fake 
CVE-2017-0605" to break the debian patch ?

In short, I accuse the Debian kernel team in my defense, it's up to them 
to buy you a beer :)

Thanks.

Best regards,

Loic

Back to linux.debian.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] tracing: Use strlcpy() instead of strcpy() in  __trace_find_cmdline() Loic <hackurx@opensec.fr> - 2018-12-17 21:10 +0100
  Re: [PATCH] tracing: Use strlcpy() instead of strcpy() in  __trace_find_cmdline() Sasha Levin <sashal@kernel.org> - 2018-12-17 22:20 +0100
  Re: [PATCH] tracing: Use strlcpy() instead of strcpy() in  __trace_find_cmdline() Greg KH <gregkh@linuxfoundation.org> - 2018-12-17 22:30 +0100
    Re: [PATCH] tracing: Use strlcpy() instead of strcpy() in  __trace_find_cmdline() Loic <hackurx@opensec.fr> - 2018-12-18 19:10 +0100
  Re: [PATCH] tracing: Use strlcpy() instead of strcpy() in  __trace_find_cmdline() Ben Hutchings <ben@decadent.org.uk> - 2018-12-18 04:10 +0100

csiph-web