Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.debian.kernel > #62757

Re: [PATCH] tracing: Use strlcpy() instead of strcpy() in __trace_find_cmdline()

From Sasha Levin <sashal@kernel.org>
Newsgroups linux.debian.kernel
Subject Re: [PATCH] tracing: Use strlcpy() instead of strcpy() in __trace_find_cmdline()
Date 2018-12-17 22:20 +0100
Message-ID <x68sV-3fy-3@gated-at.bofh.it> (permalink)
References (1 earlier) <x67nb-2Cy-15@gated-at.bofh.it> <x67nb-2Cy-17@gated-at.bofh.it> <x67nb-2Cy-19@gated-at.bofh.it> <x67nb-2Cy-21@gated-at.bofh.it> <x67nb-2Cy-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Dec 17, 2018 at 08:42:38PM +0100, Loic wrote:
>Le 2018-12-17 09:19, Greg KH a écrit :
>>On Sun, Dec 16, 2018 at 09:08:20PM +0100, Loic wrote:
>>>Le 2018-12-16 20:27, Steven Rostedt a écrit :
>>>> On Sun, 16 Dec 2018 09:52:33 +0100
>>>> Greg KH <gregkh@linuxfoundation.org> wrote:
>>>>
>>>> > On Sat, Dec 15, 2018 at 06:25:37PM +0100, Loic wrote:
>>>> > > Hello,
>>>> > >
>>>> > > Please picked up this patch for linux 4.4 and 4.9.
>>>> > > This fixes CVE-2017-0605 (Rejected?). Tested in Debian ;)
>>>> >
>>>> > It was rejected as a CVE for a good reason, and that reason is also
>>>> > why
>>>> > I refused to add it to the stable kernel releases.  In short, this is
>>>> > not an issue or bug at all, there is nothing wrong with the existing
>>>> > code.
>>>> >
>>>>
>>>> I'm starting to regret that I ever accepted the original patch :-(
>>>>
>>>> -- Steve
>>>
>>>Okay, I hadn't looked at the previous conversations because this 
>>>change is
>>>in the upstream and in debian...
>>
>>Upstream is fine, it's a valid change so that people don't keep sending
>>the crazy patch over and over.
>>
>>Debian is just cargo-culting the thing and should probably drop it 
>>as it
>>keeps coming back to me every 3 months or so, and I have to reject it
>>again :(
>>
>>thanks,
>>
>>greg k-h
>
>Why didn't you follow the upstream or add a comment "no change for 
>fake CVE-2017-0605" to break the debian patch ?

This change is fine upstream, it doesn't even mention that CVE. It just
doesn't actually fix anything, so it doesn't belong in stable (nor is it
tagged for stable).

--
Thanks,
Sasha

Back to linux.debian.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH] tracing: Use strlcpy() instead of strcpy() in  __trace_find_cmdline() Loic <hackurx@opensec.fr> - 2018-12-17 21:10 +0100
  Re: [PATCH] tracing: Use strlcpy() instead of strcpy() in  __trace_find_cmdline() Sasha Levin <sashal@kernel.org> - 2018-12-17 22:20 +0100
  Re: [PATCH] tracing: Use strlcpy() instead of strcpy() in  __trace_find_cmdline() Greg KH <gregkh@linuxfoundation.org> - 2018-12-17 22:30 +0100
    Re: [PATCH] tracing: Use strlcpy() instead of strcpy() in  __trace_find_cmdline() Loic <hackurx@opensec.fr> - 2018-12-18 19:10 +0100
  Re: [PATCH] tracing: Use strlcpy() instead of strcpy() in  __trace_find_cmdline() Ben Hutchings <ben@decadent.org.uk> - 2018-12-18 04:10 +0100

csiph-web