Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.kernel > #61876

Bug#906664: initramfs-tools: Add partition table support to get_fstype

Cross-posted to 2 groups.

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Control: notfound -1 0.131ubuntu8
Control: found -1 0.132
Control: tag -1 wontfix

On Sun, 2018-08-19 at 15:39 +0300, Nazar Mokrynskyi wrote:
> Package: initramfs-tools
> Version: 0.131ubuntu8
> Severity: wishlist
> 
> 
> Hi,
> I'd like to have fully encrypted system with partition table inside
> of LUKS container. It is easier to manage for me than multi-layer
> LVM.

LVM inside LUKS (I don't know why you call it multi-layer LVM) is well
supported in Debian, so I find this statement surprising.

What's more, Linux block drivers have to opt in to supporting
partitions, and dm-crypt doesn't do that.  So the kernel doesn't look
for a partition table on a dm-crypt device.

> However, there are 2 issues with this described here: 
> https://bugs.launchpad.net/ubuntu/+source/cryptsetup/+bug/1786688
> 
> The first issue is that after decryption of LUKS container there is a
> filesystem check and `get_fstype` function returns `undefined` for
> any partition table.
> 
> I'd like it to return `pttable` or something similar instead, so that
> after decryption it will not lock container back with "unknown
> fstype, bad password or options?".
[...]

I think the current behaviour of get_fstype is correct.  It doesn't
print any error message; it just tells the caller whether a filesystem
was detected and if so what type it is.  It's up to the caller whether
to treat a failure as fatal, or to check for a partition table as well.

Ben.

-- 
Ben Hutchings
For every action, there is an equal and opposite criticism. - Harrison

Back to linux.debian.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Bug#906664: initramfs-tools: Add partition table support to get_fstype Nazar Mokrynskyi <nazar@mokrynskyi.com> - 2018-08-19 14:50 +0200
  Processed: Re: Bug#906664: initramfs-tools: Add partition table  support to get_fstype "Debian Bug Tracking System" <owner@bugs.debian.org> - 2018-08-21 02:10 +0200
  Bug#906664: initramfs-tools: Add partition table support to get_fstype Ben Hutchings <ben@decadent.org.uk> - 2018-08-21 02:10 +0200
    Bug#906664: initramfs-tools: Add partition table support to get_fstype Nazar Mokrynskyi <nazar@mokrynskyi.com> - 2018-08-21 08:00 +0200
      Bug#906664: initramfs-tools: Add partition table support to get_fstype Ben Hutchings <ben@decadent.org.uk> - 2018-08-22 22:30 +0200
        Bug#906664: [pkg-cryptsetup-devel] Bug#906664: initramfs-tools: Add partition table support to get_fstype Guilhem Moulin <guilhem@debian.org> - 2018-08-23 12:40 +0200
  Bug#906664: [pkg-cryptsetup-devel] Bug#906664: initramfs-tools: Add partition table support to get_fstype Guilhem Moulin <guilhem@debian.org> - 2018-08-23 12:50 +0200

csiph-web