Path: csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod From: Ben Hutchings Newsgroups: linux.debian.bugs.dist,linux.debian.kernel Subject: Bug#906664: initramfs-tools: Add partition table support to get_fstype Date: Tue, 21 Aug 2018 02:10:02 +0200 Message-ID: References: X-Original-To: Nazar Mokrynskyi , 906664@bugs.debian.org X-Mailbox-Line: From debian-bugs-dist-request@lists.debian.org Tue Aug 21 00:03:09 2018 Old-Return-Path: X-Spam-Flag: NO X-Spam-Score: -2.299 Reply-To: Ben Hutchings , 906664@bugs.debian.org Resent-To: debian-bugs-dist@lists.debian.org Resent-Cc: Debian kernel team X-Debian-Pr-Message: followup 906664 X-Debian-Pr-Package: initramfs-tools X-Debian-Pr-Source: initramfs-tools X-Spam-Bayes: score:0.0000 Tokens: new, 17; hammy, 150; neutral, 102; spammy, 0. spammytokens: hammytokens:0.000-+--H*c:pgp-sha512, 0.000-+--H*F:D*decadent.org.uk, 0.000-+--H*RU:sk:shadbol, 0.000-+--H*r:sk:shadbol, 0.000-+--HX-SA-Exim-Scanned:sk:shadbol Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-M2DSgQowUjg493P+Y66H" X-Mailer: Evolution 3.28.5-1 MIME-Version: 1.0 X-Sa-Exim-Connect-IP: 2a02:8011:400e:2:cbab:f00:c93f:614 X-Sa-Exim-Mail-From: ben@decadent.org.uk X-Sa-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false X-Debian-Message: from BTS X-Mailing-List: archive/latest/1480358 List-ID: List-URL: Approved: robomod@news.nic.it Lines: 73 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Date: Tue, 21 Aug 2018 00:57:52 +0100 X-Original-Message-ID: X-Original-References: <153468237179.2109.17235396617938097509.reportbug@localhost.localdomain> <153468237179.2109.17235396617938097509.reportbug@localhost.localdomain> Xref: csiph.com linux.debian.bugs.dist:913815 linux.debian.kernel:61876 --=-M2DSgQowUjg493P+Y66H Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Control: notfound -1 0.131ubuntu8 Control: found -1 0.132 Control: tag -1 wontfix On Sun, 2018-08-19 at 15:39 +0300, Nazar Mokrynskyi wrote: > Package: initramfs-tools > Version: 0.131ubuntu8 > Severity: wishlist >=20 >=20 > Hi, > I'd like to have fully encrypted system with partition table inside > of LUKS container. It is easier to manage for me than multi-layer > LVM. LVM inside LUKS (I don't know why you call it multi-layer LVM) is well supported in Debian, so I find this statement surprising. What's more, Linux block drivers have to opt in to supporting partitions, and dm-crypt doesn't do that. So the kernel doesn't look for a partition table on a dm-crypt device. > However, there are 2 issues with this described here:=20 > https://bugs.launchpad.net/ubuntu/+source/cryptsetup/+bug/1786688 >=20 > The first issue is that after decryption of LUKS container there is a > filesystem check and `get_fstype` function returns `undefined` for > any partition table. >=20 > I'd like it to return `pttable` or something similar instead, so that > after decryption it will not lock container back with "unknown > fstype, bad password or options?". [...] I think the current behaviour of get_fstype is correct. It doesn't print any error message; it just tells the caller whether a filesystem was detected and if so what type it is. It's up to the caller whether to treat a failure as fatal, or to check for a partition table as well. Ben. --=20 Ben Hutchings For every action, there is an equal and opposite criticism. - Harrison --=-M2DSgQowUjg493P+Y66H Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEErCspvTSmr92z9o8157/I7JWGEQkFAlt7VYAACgkQ57/I7JWG EQmvPRAArCXS/jNeTBrgY/RDtT1u9PP7/+8LUClqHBJjKH67kCrEcUPr/sd/1mCi 2P2DOxSNH50EcImI75T6yIJ85WJ1HARqLvQt95uYOCYanhpUo6EuR7isnMeJLqsX eQYOIeCu728w3bR+cJdHX03V4fGlKHNT7a0Ib5mge4Cd2E9bgBnPtFaeiMomqOPb dUWduWu7KB5otU0ylgfeXu20kYNl5Uib9tGiSZcs3VUlmT0sD1yle786s5vciSc2 d/5fKO9sdJ2gOjUcXA/5atiXsS9OGFYZqy5QeUluJ34o2BfaMw4XDdNCID/bPzNe ycBh8VD0h+8+YN52/18Kw9NlPYe/IkRxHRAiDUIY2l7adAFtyhJzFTy47JhQrL3b VR6w+kW7TQespp5MRJHoMj2kH3e+tQUJFMDfEY/3noTWrS2DquB8iNxxV3JNMqJy 8w0Hst7Kdu435Wtx2DEyv3ByiPOih4Muckfpvw+MD15K6Dvv7FsP21kHPPe5+Noa xCCigIzyhIgWKzHlmZMhxJi3x0UIwYkhUA0y1OfexzIqXmb6+sWPt03FQrCzUe6N jiL+ozD9cgdyV1FIe91Hrq4IP4XXNDwqCs0mmr3IxlYzLWhkQN9/RRwtgPev28LJ 9LXoKG+Id+JZ9rkj671v2hrp31xif5pSXvz/6X0YyT52AlUXRD8= =vNlx -----END PGP SIGNATURE----- --=-M2DSgQowUjg493P+Y66H--