Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.debian.kernel > #55899
| From | Linus Torvalds <torvalds@linux-foundation.org> |
|---|---|
| Newsgroups | linux.debian.kernel, linux.kernel |
| Subject | Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm |
| Date | 2016-11-29 22:00 +0100 |
| Message-ID | <sIXm1-4RO-15@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <sIR6V-It-9@gated-at.bofh.it> <sISPo-1Rc-33@gated-at.bofh.it> <sIT8J-2eS-1@gated-at.bofh.it> <sITiq-2kT-41@gated-at.bofh.it> <sIWJj-4l9-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Cross-posted to 2 groups.
On Tue, Nov 29, 2016 at 11:57 AM, Ben Hutchings <ben@decadent.org.uk> wrote:
>
> If the modversion is missing then the fallback should be to a full
> vermagic match, i.e. including the release string. Something like
> this (untested):
This really seems way too complicated for this situation.
And it's wrong too. The whole point of modversions was that you didn't
want to do the full version check.
We already know there were *some* crc's (we checked that at the top of
check_version(), but we've also checked it in "same_magic()" - it's
what makes us ignore the exact version number), but this particular
symbol doesn't have a crc. Just let it through, because we have bugs
in binutils.
So your extra complexity logic seems actively wrong. It makes
MODVERSIONS not work at all, rather than limp along. You're better off
just not having MODVERSIONS.
Linus
Back to linux.debian.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Ben Hutchings <ben@decadent.org.uk> - 2016-11-29 02:20 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Nicholas Piggin <npiggin@gmail.com> - 2016-11-29 03:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Michal Marek <mmarek@suse.com> - 2016-11-29 10:20 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Linus Torvalds <torvalds@linux-foundation.org> - 2016-11-29 05:10 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Adam Borowski <kilobyte@angband.pl> - 2016-11-29 14:20 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Ingo Molnar <mingo@kernel.org> - 2016-11-29 14:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Adam Borowski <kilobyte@angband.pl> - 2016-11-29 15:30 +0100
[PATCH] x86/kbuild: enable modversions for symbols exported from asm Adam Borowski <kilobyte@angband.pl> - 2016-11-29 15:00 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Linus Torvalds <torvalds@linux-foundation.org> - 2016-11-29 16:50 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Michal Marek <mmarek@suse.com> - 2016-11-29 17:20 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Linus Torvalds <torvalds@linux-foundation.org> - 2016-11-29 17:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Ben Hutchings <ben@decadent.org.uk> - 2016-11-29 21:00 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Linus Torvalds <torvalds@linux-foundation.org> - 2016-11-29 22:00 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Linus Torvalds <torvalds@linux-foundation.org> - 2016-11-30 20:00 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Ben Hutchings <ben@decadent.org.uk> - 2016-11-30 22:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Nicholas Piggin <npiggin@gmail.com> - 2016-12-01 03:20 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Ben Hutchings <ben@decadent.org.uk> - 2016-12-01 03:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Nicholas Piggin <npiggin@gmail.com> - 2016-12-01 05:00 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Michal Marek <mmarek@suse.com> - 2016-12-01 17:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-12-02 16:00 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Nicholas Piggin <npiggin@gmail.com> - 2016-12-09 05:00 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Ian Campbell <ijc@hellion.org.uk> - 2016-12-09 16:30 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Nicholas Piggin <npiggin@gmail.com> - 2016-12-09 17:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-12-10 14:00 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Nicholas Piggin <npiggin@gmail.com> - 2016-12-12 05:10 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Ian Campbell <ijc@hellion.org.uk> - 2016-12-12 10:10 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Don Zickus <dzickus@redhat.com> - 2016-12-14 19:20 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Stanislav Kozina <skozina@redhat.com> - 2016-12-13 02:30 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Michal Marek <mmarek@suse.com> - 2016-12-14 00:10 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Dodji Seketeli <dodji@seketeli.org> - 2016-12-14 10:20 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Michal Marek <mmarek@suse.com> - 2016-12-14 10:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Michal Marek <mmarek@suse.com> - 2016-12-14 11:00 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Dodji Seketeli <dodji@seketeli.org> - 2016-12-14 11:00 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Michal Marek <mmarek@suse.com> - 2016-12-14 11:10 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Dodji Seketeli <dodji@seketeli.org> - 2016-12-14 11:20 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Michal Marek <mmarek@suse.com> - 2016-12-14 11:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Dodji Seketeli <dodji@seketeli.org> - 2016-12-14 11:20 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Don Zickus <dzickus@redhat.com> - 2016-12-01 05:50 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Nicholas Piggin <npiggin@gmail.com> - 2016-12-01 05:50 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Don Zickus <dzickus@redhat.com> - 2016-12-01 16:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Don Zickus <dzickus@redhat.com> - 2016-12-01 17:00 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-12-01 17:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Don Zickus <dzickus@redhat.com> - 2016-12-01 20:10 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Christoph Hellwig <hch@infradead.org> - 2016-12-01 17:10 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Nicholas Piggin <npiggin@gmail.com> - 2016-12-09 05:10 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Stanislav Kozina <skozina@redhat.com> - 2016-12-09 09:20 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Nicholas Piggin <npiggin@gmail.com> - 2016-12-09 09:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Stanislav Kozina <skozina@redhat.com> - 2016-12-09 16:00 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Nicholas Piggin <npiggin@gmail.com> - 2016-12-09 17:20 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-12-09 17:30 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Stanislav Kozina <skozina@redhat.com> - 2016-12-12 11:10 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Nicholas Piggin <npiggin@gmail.com> - 2016-12-13 08:50 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Hannes Frederic Sowa <hannes@redhat.com> - 2016-12-14 15:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Nicholas Piggin <npiggin@gmail.com> - 2016-12-15 03:30 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Hannes Frederic Sowa <hannes@redhat.com> - 2016-12-15 12:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Nicholas Piggin <npiggin@gmail.com> - 2016-12-15 13:30 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Hannes Frederic Sowa <hannes@redhat.com> - 2016-12-15 14:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Nicholas Piggin <npiggin@gmail.com> - 2016-12-15 15:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Hannes Frederic Sowa <hannes@redhat.com> - 2016-12-15 16:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Stanislav Kozina <skozina@redhat.com> - 2016-12-15 15:00 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Don Zickus <dzickus@redhat.com> - 2016-12-09 17:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Stanislav Kozina <skozina@redhat.com> - 2016-12-01 12:20 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Nicholas Piggin <npiggin@gmail.com> - 2016-12-01 12:30 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Stanislav Kozina <skozina@redhat.com> - 2016-12-01 13:00 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Nicholas Piggin <npiggin@gmail.com> - 2016-12-01 14:00 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Dodji Seketeli <dodji@seketeli.org> - 2016-12-01 16:50 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Michal Marek <mmarek@suse.com> - 2016-12-01 17:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Adam Borowski <kilobyte@angband.pl> - 2016-11-29 18:10 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Linus Torvalds <torvalds@linux-foundation.org> - 2016-11-29 18:30 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Linus Torvalds <torvalds@linux-foundation.org> - 2016-11-29 18:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Arnd Bergmann <arnd@arndb.de> - 2016-12-01 15:20 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Michal Marek <mmarek@suse.com> - 2016-12-01 17:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-01 19:50 +0100
Re: [RFC, PATCH, v3.9] default exported asm symbols to zero Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-02 14:00 +0100
Re: [RFC, PATCH, v3.9] default exported asm symbols to zero Arnd Bergmann <arnd@arndb.de> - 2016-12-02 16:10 +0100
Re: [RFC, PATCH, v3.9] default exported asm symbols to zero Adam Borowski <kilobyte@angband.pl> - 2016-12-02 16:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-02 18:30 +0100
Re: [RFC, PATCH, v3.9] default exported asm symbols to zero Ben Hutchings <ben@decadent.org.uk> - 2016-12-03 05:40 +0100
Re: [RFC, PATCH, v3.9] default exported asm symbols to zero Arnd Bergmann <arnd@arndb.de> - 2016-12-03 12:10 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Alan Modra <amodra@gmail.com> - 2016-12-04 09:20 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-04 22:10 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Michal Marek <mmarek@suse.com> - 2016-11-29 22:50 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Ben Hutchings <ben@decadent.org.uk> - 2016-12-02 03:10 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Adam Borowski <kilobyte@angband.pl> - 2016-12-02 12:30 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Ben Hutchings <ben@decadent.org.uk> - 2016-12-02 16:10 +0100
csiph-web