Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.debian.kernel > #55890
| From | Adam Borowski <kilobyte@angband.pl> |
|---|---|
| Newsgroups | linux.kernel, linux.debian.kernel |
| Subject | [PATCH] x86/kbuild: enable modversions for symbols exported from asm |
| Date | 2016-11-29 15:00 +0100 |
| Message-ID | <sIR6V-It-9@gated-at.bofh.it> (permalink) |
| References | <sIQud-v5-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Cross-posted to 2 groups.
Commit 4efca4ed ("kbuild: modversions for EXPORT_SYMBOL() for asm") adds
modversion support for symbols exported from asm files. Architectures
must include C-style declarations for those symbols in asm/asm-prototypes.h
in order for them to be versioned.
Add these declarations for x86, and an architecture-independent file that
can be used for common symbols.
User impact: kernels may fail to load modules at all when
CONFIG_MODVERSIONS=y.
Signed-off-by: Adam Borowski <kilobyte@angband.pl>
Tested-by: Kalle Valo <kvalo@codeaurora.org>
Acked-by: Nicholas Piggin <npiggin@gmail.com>
Tested-by: Peter Wu <peter@lekensteyn.nl>
Tested-by: Oliver Hartkopp <socketcan@hartkopp.net>
---
> So somebody send me a minimal patch that is
>
> (a) tested
By many people.
> (b) explains it
The actual logic is in 4efca4ed0. It wants C prototypes defined in
asm/asm-prototypes.h that lists symbols defined in assembly -- genksyms
knows only how to read C code.
> (c) obvious
To be honest I don't quite understand what's the real gain over code that
was removed by 784d5699eddc, this mostly brings the symbols back. But
that's for people wiser than me to explain.
> and I'll happily re-enable modversions.
The powerpc counterpart to this patch is in mainline as 9e5f688, although a
file by that name already existed.
As for arm, it looks like it was handled the other way by 8478132.
diff --git a/arch/x86/include/asm/asm-prototypes.h b/arch/x86/include/asm/asm-prototypes.h
new file mode 100644
index 0000000..ae87224
--- /dev/null
+++ b/arch/x86/include/asm/asm-prototypes.h
@@ -0,0 +1,12 @@
+#include <asm/ftrace.h>
+#include <asm/uaccess.h>
+#include <asm/string.h>
+#include <asm/page.h>
+#include <asm/checksum.h>
+
+#include <asm-generic/asm-prototypes.h>
+
+#include <asm/page.h>
+#include <asm/pgtable.h>
+#include <asm/special_insns.h>
+#include <asm/preempt.h>
diff --git a/include/asm-generic/asm-prototypes.h b/include/asm-generic/asm-prototypes.h
new file mode 100644
index 0000000..df13637
--- /dev/null
+++ b/include/asm-generic/asm-prototypes.h
@@ -0,0 +1,7 @@
+#include <linux/bitops.h>
+extern void *__memset(void *, int, __kernel_size_t);
+extern void *__memcpy(void *, const void *, __kernel_size_t);
+extern void *__memmove(void *, const void *, __kernel_size_t);
+extern void *memset(void *, int, __kernel_size_t);
+extern void *memcpy(void *, const void *, __kernel_size_t);
+extern void *memmove(void *, const void *, __kernel_size_t);
--
2.10.2
Back to linux.debian.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Ben Hutchings <ben@decadent.org.uk> - 2016-11-29 02:20 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Nicholas Piggin <npiggin@gmail.com> - 2016-11-29 03:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Michal Marek <mmarek@suse.com> - 2016-11-29 10:20 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Linus Torvalds <torvalds@linux-foundation.org> - 2016-11-29 05:10 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Adam Borowski <kilobyte@angband.pl> - 2016-11-29 14:20 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Ingo Molnar <mingo@kernel.org> - 2016-11-29 14:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Adam Borowski <kilobyte@angband.pl> - 2016-11-29 15:30 +0100
[PATCH] x86/kbuild: enable modversions for symbols exported from asm Adam Borowski <kilobyte@angband.pl> - 2016-11-29 15:00 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Linus Torvalds <torvalds@linux-foundation.org> - 2016-11-29 16:50 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Michal Marek <mmarek@suse.com> - 2016-11-29 17:20 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Linus Torvalds <torvalds@linux-foundation.org> - 2016-11-29 17:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Ben Hutchings <ben@decadent.org.uk> - 2016-11-29 21:00 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Linus Torvalds <torvalds@linux-foundation.org> - 2016-11-29 22:00 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Linus Torvalds <torvalds@linux-foundation.org> - 2016-11-30 20:00 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Ben Hutchings <ben@decadent.org.uk> - 2016-11-30 22:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Nicholas Piggin <npiggin@gmail.com> - 2016-12-01 03:20 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Ben Hutchings <ben@decadent.org.uk> - 2016-12-01 03:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Nicholas Piggin <npiggin@gmail.com> - 2016-12-01 05:00 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Michal Marek <mmarek@suse.com> - 2016-12-01 17:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-12-02 16:00 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Nicholas Piggin <npiggin@gmail.com> - 2016-12-09 05:00 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Ian Campbell <ijc@hellion.org.uk> - 2016-12-09 16:30 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Nicholas Piggin <npiggin@gmail.com> - 2016-12-09 17:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-12-10 14:00 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Nicholas Piggin <npiggin@gmail.com> - 2016-12-12 05:10 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Ian Campbell <ijc@hellion.org.uk> - 2016-12-12 10:10 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Don Zickus <dzickus@redhat.com> - 2016-12-14 19:20 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Stanislav Kozina <skozina@redhat.com> - 2016-12-13 02:30 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Michal Marek <mmarek@suse.com> - 2016-12-14 00:10 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Dodji Seketeli <dodji@seketeli.org> - 2016-12-14 10:20 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Michal Marek <mmarek@suse.com> - 2016-12-14 10:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Michal Marek <mmarek@suse.com> - 2016-12-14 11:00 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Dodji Seketeli <dodji@seketeli.org> - 2016-12-14 11:00 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Michal Marek <mmarek@suse.com> - 2016-12-14 11:10 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Dodji Seketeli <dodji@seketeli.org> - 2016-12-14 11:20 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Michal Marek <mmarek@suse.com> - 2016-12-14 11:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Dodji Seketeli <dodji@seketeli.org> - 2016-12-14 11:20 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Don Zickus <dzickus@redhat.com> - 2016-12-01 05:50 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Nicholas Piggin <npiggin@gmail.com> - 2016-12-01 05:50 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Don Zickus <dzickus@redhat.com> - 2016-12-01 16:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Don Zickus <dzickus@redhat.com> - 2016-12-01 17:00 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-12-01 17:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Don Zickus <dzickus@redhat.com> - 2016-12-01 20:10 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Christoph Hellwig <hch@infradead.org> - 2016-12-01 17:10 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Nicholas Piggin <npiggin@gmail.com> - 2016-12-09 05:10 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Stanislav Kozina <skozina@redhat.com> - 2016-12-09 09:20 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Nicholas Piggin <npiggin@gmail.com> - 2016-12-09 09:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Stanislav Kozina <skozina@redhat.com> - 2016-12-09 16:00 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Nicholas Piggin <npiggin@gmail.com> - 2016-12-09 17:20 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-12-09 17:30 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Stanislav Kozina <skozina@redhat.com> - 2016-12-12 11:10 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Nicholas Piggin <npiggin@gmail.com> - 2016-12-13 08:50 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Hannes Frederic Sowa <hannes@redhat.com> - 2016-12-14 15:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Nicholas Piggin <npiggin@gmail.com> - 2016-12-15 03:30 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Hannes Frederic Sowa <hannes@redhat.com> - 2016-12-15 12:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Nicholas Piggin <npiggin@gmail.com> - 2016-12-15 13:30 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Hannes Frederic Sowa <hannes@redhat.com> - 2016-12-15 14:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Nicholas Piggin <npiggin@gmail.com> - 2016-12-15 15:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Hannes Frederic Sowa <hannes@redhat.com> - 2016-12-15 16:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Stanislav Kozina <skozina@redhat.com> - 2016-12-15 15:00 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Don Zickus <dzickus@redhat.com> - 2016-12-09 17:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Stanislav Kozina <skozina@redhat.com> - 2016-12-01 12:20 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Nicholas Piggin <npiggin@gmail.com> - 2016-12-01 12:30 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Stanislav Kozina <skozina@redhat.com> - 2016-12-01 13:00 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Nicholas Piggin <npiggin@gmail.com> - 2016-12-01 14:00 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Dodji Seketeli <dodji@seketeli.org> - 2016-12-01 16:50 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Michal Marek <mmarek@suse.com> - 2016-12-01 17:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Adam Borowski <kilobyte@angband.pl> - 2016-11-29 18:10 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Linus Torvalds <torvalds@linux-foundation.org> - 2016-11-29 18:30 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Linus Torvalds <torvalds@linux-foundation.org> - 2016-11-29 18:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Arnd Bergmann <arnd@arndb.de> - 2016-12-01 15:20 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Michal Marek <mmarek@suse.com> - 2016-12-01 17:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-01 19:50 +0100
Re: [RFC, PATCH, v3.9] default exported asm symbols to zero Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-02 14:00 +0100
Re: [RFC, PATCH, v3.9] default exported asm symbols to zero Arnd Bergmann <arnd@arndb.de> - 2016-12-02 16:10 +0100
Re: [RFC, PATCH, v3.9] default exported asm symbols to zero Adam Borowski <kilobyte@angband.pl> - 2016-12-02 16:40 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-02 18:30 +0100
Re: [RFC, PATCH, v3.9] default exported asm symbols to zero Ben Hutchings <ben@decadent.org.uk> - 2016-12-03 05:40 +0100
Re: [RFC, PATCH, v3.9] default exported asm symbols to zero Arnd Bergmann <arnd@arndb.de> - 2016-12-03 12:10 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Alan Modra <amodra@gmail.com> - 2016-12-04 09:20 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-04 22:10 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Michal Marek <mmarek@suse.com> - 2016-11-29 22:50 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Ben Hutchings <ben@decadent.org.uk> - 2016-12-02 03:10 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Adam Borowski <kilobyte@angband.pl> - 2016-12-02 12:30 +0100
Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm Ben Hutchings <ben@decadent.org.uk> - 2016-12-02 16:10 +0100
csiph-web