Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.debian.kernel > #67182

Bug#961299: [PATCH] Don't run dh_strip on vmlinuz

Path csiph.com!goblin3!goblin2!goblin.stu.neva.ru!aioe.org!bofh.it!news.nic.it!robomod
From Ben Hutchings <ben@decadent.org.uk>
Newsgroups linux.debian.bugs.dist, linux.debian.kernel
Subject Bug#961299: [PATCH] Don't run dh_strip on vmlinuz
Date Tue, 26 May 2020 13:00:01 +0200
Message-ID <AaFtn-129-7@gated-at.bofh.it> (permalink)
References <AarA6-1ks-13@gated-at.bofh.it> <AarA6-1ks-15@gated-at.bofh.it> <AarA6-1ks-13@gated-at.bofh.it>
X-Original-To Helge Deller <deller@gmx.de>, 961299@bugs.debian.org
X-Mailbox-Line From debian-bugs-dist-request@lists.debian.org Tue May 26 10:57:12 2020
Old-Return-Path <debbugs@buxtehude.debian.org>
X-Spam-Flag NO
X-Spam-Score -0.45
Reply-To Ben Hutchings <ben@decadent.org.uk>, 961299@bugs.debian.org
Resent-To debian-bugs-dist@lists.debian.org
Resent-Cc Debian Kernel Team <debian-kernel@lists.debian.org>
X-Debian-Pr-Message followup 961299
X-Debian-Pr-Package linux
X-Debian-Pr-Keywords ftbfs
X-Debian-Pr-Source linux
X-Spam-Bayes score:0.0000 Tokens: new, 27; hammy, 150; neutral, 76; spammy, 0. spammytokens: hammytokens:0.000-+--H*F:D*decadent.org.uk, 0.000-+--H*RU:sk:shadbol, 0.000-+--H*r:sk:shadbol, 0.000-+--HX-SA-Exim-Scanned:sk:shadbol, 0.000-+--H*RU:88.96.1.126
Content-Type multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-CNHmwErwiB1H3ljS1K0R"
User-Agent Evolution 3.36.2-1
MIME-Version 1.0
X-Sa-Exim-Connect-IP 192.168.4.242
X-Sa-Exim-Mail-From ben@decadent.org.uk
X-Sa-Exim-Scanned No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false
X-Debian-Message from BTS
X-Mailing-List <debian-bugs-dist@lists.debian.org> archive/latest/1605348
List-ID <debian-bugs-dist.lists.debian.org>
List-URL <https://lists.debian.org/debian-bugs-dist/>
Approved robomod@news.nic.it
Lines 77
Organization linux.* mail to news gateway
Sender robomod@news.nic.it
X-Original-Date Tue, 26 May 2020 11:54:10 +0100
X-Original-Message-ID <cf8997a3086f74c032de550bd7dfa22efb865fdb.camel@decadent.org.uk>
X-Original-References <20200525200612.GA13843@ls3530.fritz.box> <6a289d06-e14c-f9f1-a3b0-cfc2c2a43aad@gmx.de> <20200525200612.GA13843@ls3530.fritz.box>
Xref csiph.com linux.debian.bugs.dist:1011435 linux.debian.kernel:67182

Cross-posted to 2 groups.

Show key headers only | View raw


[Multipart message — attachments visible in raw view] - view raw

On Mon, 2020-05-25 at 22:06 +0200, Helge Deller wrote:
> The debian kernel build switched to use debhelper
> compatibility level 12 with this commit:
> 
> commit 59a5af36cbf1cc01ef48b91719f999a699d99fab
> Author: Ben Hutchings <ben@decadent.org.uk>
> Date:   Sun Apr 19 19:49:03 2020 +0100
>     debhelper started complaining about level 9, so it's time to upgrade
>     again.
> 
> This change broke the kernel build on the hppa architecture.
> Since compat level 12, dh_strip runs the "strip" command on any vmlinuz*
> files, which wasn't the case before.
> On hppa the 64-bit build needs to run "hppa64-linux-strip" instead of
> "strip".
> 
> Fix it by adding "vmlinuz" to the exclude list of dh_strip, and thus
> behave as compat level 9 did before.
> 
> Tested on hppa and x86-64.
> Ok to commit, or any other idea on how to fix it?

Looks good to me.  Remember to update debian/changelog as well.

Ben.

> Helge
> 
> 
> diff --git a/debian/rules.real b/debian/rules.real
> index e73588b4093c..af1d246f3b27 100644
> --- a/debian/rules.real
> +++ b/debian/rules.real
> @@ -447,7 +447,7 @@ endif
>  	+$(MAKE_SELF) \
>  	  install-image_$(ARCH)_$(FEATURESET)_$(FLAVOUR)_bug \
>  	  PACKAGE_DIR='$(PACKAGE_DIR)' PACKAGE_NAME='$(PACKAGE_NAME)' REAL_VERSION='$(REAL_VERSION)'
> -	dh_strip --no-automatic-dbgsym -Xvmlinux
> +	dh_strip --no-automatic-dbgsym -Xvmlinux -Xvmlinuz
>  	ln -sf linux-image.NEWS debian/$(PACKAGE_NAME).NEWS
>  	+$(MAKE_SELF) install-base
> 
-- 
Ben Hutchings
Editing code like this is akin to sticking plasters on the bleeding
stump of a severed limb. - me, 29 June 1999


Back to linux.debian.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

Bug#961299: [PATCH] Don't run dh_strip on vmlinuz Helge Deller <deller@gmx.de> - 2020-05-25 22:10 +0200
  Bug#961299: [PATCH] Don't run dh_strip on vmlinuz Ben Hutchings <ben@decadent.org.uk> - 2020-05-26 13:00 +0200

csiph-web