Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.kernel > #67178 > unrolled thread

Bug#961299: [PATCH] Don't run dh_strip on vmlinuz

Back to article view | Back to linux.debian.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Bug#961299: [PATCH] Don't run dh_strip on vmlinuz Helge Deller <deller@gmx.de> - 2020-05-25 22:10 +0200
    Bug#961299: [PATCH] Don't run dh_strip on vmlinuz Ben Hutchings <ben@decadent.org.uk> - 2020-05-26 13:00 +0200

#67178 — Bug#961299: [PATCH] Don't run dh_strip on vmlinuz

The debian kernel build switched to use debhelper
compatibility level 12 with this commit:

commit 59a5af36cbf1cc01ef48b91719f999a699d99fab
Author: Ben Hutchings <ben@decadent.org.uk>
Date:   Sun Apr 19 19:49:03 2020 +0100
    debhelper started complaining about level 9, so it's time to upgrade
    again.

This change broke the kernel build on the hppa architecture.
Since compat level 12, dh_strip runs the "strip" command on any vmlinuz*
files, which wasn't the case before.
On hppa the 64-bit build needs to run "hppa64-linux-strip" instead of
"strip".

Fix it by adding "vmlinuz" to the exclude list of dh_strip, and thus
behave as compat level 9 did before.

Tested on hppa and x86-64.
Ok to commit, or any other idea on how to fix it?

Helge


diff --git a/debian/rules.real b/debian/rules.real
index e73588b4093c..af1d246f3b27 100644
--- a/debian/rules.real
+++ b/debian/rules.real
@@ -447,7 +447,7 @@ endif
 	+$(MAKE_SELF) \
 	  install-image_$(ARCH)_$(FEATURESET)_$(FLAVOUR)_bug \
 	  PACKAGE_DIR='$(PACKAGE_DIR)' PACKAGE_NAME='$(PACKAGE_NAME)' REAL_VERSION='$(REAL_VERSION)'
-	dh_strip --no-automatic-dbgsym -Xvmlinux
+	dh_strip --no-automatic-dbgsym -Xvmlinux -Xvmlinuz
 	ln -sf linux-image.NEWS debian/$(PACKAGE_NAME).NEWS
 	+$(MAKE_SELF) install-base

[toc] | [next] | [standalone]

#67182

[Multipart message — attachments visible in raw view] — view raw

On Mon, 2020-05-25 at 22:06 +0200, Helge Deller wrote:
> The debian kernel build switched to use debhelper
> compatibility level 12 with this commit:
> 
> commit 59a5af36cbf1cc01ef48b91719f999a699d99fab
> Author: Ben Hutchings <ben@decadent.org.uk>
> Date:   Sun Apr 19 19:49:03 2020 +0100
>     debhelper started complaining about level 9, so it's time to upgrade
>     again.
> 
> This change broke the kernel build on the hppa architecture.
> Since compat level 12, dh_strip runs the "strip" command on any vmlinuz*
> files, which wasn't the case before.
> On hppa the 64-bit build needs to run "hppa64-linux-strip" instead of
> "strip".
> 
> Fix it by adding "vmlinuz" to the exclude list of dh_strip, and thus
> behave as compat level 9 did before.
> 
> Tested on hppa and x86-64.
> Ok to commit, or any other idea on how to fix it?

Looks good to me.  Remember to update debian/changelog as well.

Ben.

> Helge
> 
> 
> diff --git a/debian/rules.real b/debian/rules.real
> index e73588b4093c..af1d246f3b27 100644
> --- a/debian/rules.real
> +++ b/debian/rules.real
> @@ -447,7 +447,7 @@ endif
>  	+$(MAKE_SELF) \
>  	  install-image_$(ARCH)_$(FEATURESET)_$(FLAVOUR)_bug \
>  	  PACKAGE_DIR='$(PACKAGE_DIR)' PACKAGE_NAME='$(PACKAGE_NAME)' REAL_VERSION='$(REAL_VERSION)'
> -	dh_strip --no-automatic-dbgsym -Xvmlinux
> +	dh_strip --no-automatic-dbgsym -Xvmlinux -Xvmlinuz
>  	ln -sf linux-image.NEWS debian/$(PACKAGE_NAME).NEWS
>  	+$(MAKE_SELF) install-base
> 
-- 
Ben Hutchings
Editing code like this is akin to sticking plasters on the bleeding
stump of a severed limb. - me, 29 June 1999

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.kernel

csiph-web