Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.debian.bugs.dist > #1230111 > unrolled thread
| Started by | Petter Reinholdtsen <pere@hungry.com> |
|---|---|
| First post | 2025-01-25 06:30 +0100 |
| Last post | 2025-02-06 14:40 +0100 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.debian.bugs.dist
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Bug#1093193: broadcom-sta-dkms: Enable AppStream metainfo XML Petter Reinholdtsen <pere@hungry.com> - 2025-01-25 06:30 +0100
Bug#1093193: broadcom-sta-dkms: Enable AppStream metainfo XML Eduard Bloch <edi@gmx.de> - 2025-02-06 12:10 +0100
Bug#1093193: broadcom-sta-dkms: Enable AppStream metainfo XML Petter Reinholdtsen <pere@hungry.com> - 2025-02-06 12:20 +0100
Bug#1093193: broadcom-sta-dkms: Enable AppStream metainfo XML Petter Reinholdtsen <pere@hungry.com> - 2025-02-06 14:40 +0100
| From | Petter Reinholdtsen <pere@hungry.com> |
|---|---|
| Date | 2025-01-25 06:30 +0100 |
| Subject | Bug#1093193: broadcom-sta-dkms: Enable AppStream metainfo XML |
| Message-ID | <K8GU2-bFZN-11@gated-at.bofh.it> |
Dear Eduard, Cyril and Roger, Is there anything I can do to help get this AppStream fix into unstable? -- Happy hacking Petter Reinholdtsen
[toc] | [next] | [standalone]
| From | Eduard Bloch <edi@gmx.de> |
|---|---|
| Date | 2025-02-06 12:10 +0100 |
| Message-ID | <Kd7VD-eOaN-19@gated-at.bofh.it> |
| In reply to | #1230111 |
Hallo, * Petter Reinholdtsen [Sat, Jan 25 2025, 06:24:53AM]: > Dear Eduard, Cyril and Roger, > > Is there anything I can do to help get this AppStream fix into unstable? Yes. Please explain - can I ignore this? W: broadcom-sta-dkms: appstream-metadata-validation-failed Problems reported by "appstreamcli validate-tree". I am no expert and just wanted to reproduce this. The lintian-info help help is not helpful (talking about path-to-package-root ... what does that mean? So I unpacked the deb and gave it the metainfo folder... is that what this means?!) appstreamcli validate-tree --no-net usr/share/metainfo I: ~:~: dir-no-metadata-found ? Validation was successful: infos: 1 Looks okay. What is wrong? Best regards, Eduard.
[toc] | [prev] | [next] | [standalone]
| From | Petter Reinholdtsen <pere@hungry.com> |
|---|---|
| Date | 2025-02-06 12:20 +0100 |
| Message-ID | <Kd85j-eOfx-3@gated-at.bofh.it> |
| In reply to | #1231980 |
[Eduard Bloch] > Yes. Please explain - can I ignore this? > > W: broadcom-sta-dkms: appstream-metadata-validation-failed Problems > reported by "appstreamcli validate-tree". Most likely not. > I am no expert and just wanted to reproduce this. Try this, assuming the package files are stuffed in debian/broadcom-sta-dkms by/ the build: appstreamcli validate-tree debian/broadcom-sta-dkms > The lintian-info help help is not helpful (talking about > path-to-package-root ... what does that mean? It is me trying to explain to use the directory root created in debian/ by the build system before wrapping up the .deb. I guess it should be rephrased. Any suggestions? > So I unpacked the deb and gave it the metainfo folder... is that what > this means?!) Would also work, but you should point it to the directory containing "usr", not usr/share/metainfo: > Looks okay. What is wrong? I'll do a test build later today and see if I can find the problem. -- Happy hacking Petter Reinholdtsen
[toc] | [prev] | [next] | [standalone]
| From | Petter Reinholdtsen <pere@hungry.com> |
|---|---|
| Date | 2025-02-06 14:40 +0100 |
| Message-ID | <KdagO-ePTL-5@gated-at.bofh.it> |
| In reply to | #1231981 |
These were the originally reported problems: broadcom-sta-dkms.metainfo.xml E: broadcom-sta-dkms:3: cid-is-not-rdns broadcom-sta-dkms I: broadcom-sta-dkms:3: cid-contains-hyphen broadcom-sta-dkms E: broadcom-sta-dkms:4: metadata-license-invalid PD ✘ Validation failed: errors: 2, infos: 1, pedantic: 1 And this is the patch to fix it. The ID and file should avoid '-', and need to list a acceptable license. I propose MIT, but there are more PD like licenses that could be used instead. diff --git a/debian/broadcom-sta-dkms.metainfo.xml b/debian/com.broadcom.linux.broadcom_sta.dkms.metainfo.xml similarity index 94% rename from debian/broadcom-sta-dkms.metainfo.xml rename to debian/com.broadcom.linux.broadcom_sta.dkms.metainfo.xml index a071867..3059622 100644 --- a/debian/broadcom-sta-dkms.metainfo.xml +++ b/debian/com.broadcom.linux.broadcom_sta.dkms.metainfo.xml @@ -1,7 +1,7 @@ <?xml version="1.0" encoding="UTF-8"?> <component> - <id>broadcom-sta-dkms</id> - <metadata_license>PD</metadata_license> + <id>com.broadcom.linux.broadcom_sta.dkms</id> + <metadata_license>MIT</metadata_license> <name>broadcom-sta-dkms</name> <summary>Drivers for certain Broadcom WiFi network interfaces</summary> <description> diff --git a/debian/rules b/debian/rules index ec7300e..37e1124 100755 --- a/debian/rules +++ b/debian/rules @@ -17,7 +17,7 @@ dkms_target := usr/src/$(source_name)-$(version) ids_dir := usr/share/broadcom-sta # AppStream data -metadata_dir := usr/share/appdata +metadata_dir := usr/share/metainfo %: dh $@ @@ -36,8 +36,7 @@ install-dkms: install-tmp dh_installdirs -p $(dkms_package) $(dkms_target) dh_install -p $(dkms_package) debian/tmp/* $(dkms_target)/ dh_install -p $(dkms_package) debian/broadcom-sta.ids $(ids_dir)/ -# disable the AppStream metadata until it's clear how to work around confusion with the devices supported by the free driver -# dh_install -p $(dkms_package) debian/broadcom-sta-dkms.metainfo.xml $(metadata_dir)/ + dh_install -p $(dkms_package) debian/com.broadcom.linux.broadcom_sta.dkms.metainfo.xml $(metadata_dir)/ install-source: install-tmp dh_installdirs -p $(source_package) $(source_target) -- Happy hacking Petter Reinholdtsen
[toc] | [prev] | [standalone]
Back to top | Article view | linux.debian.bugs.dist
csiph-web