Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.debian.bugs.dist > #1231993
| From | Petter Reinholdtsen <pere@hungry.com> |
|---|---|
| Newsgroups | linux.debian.bugs.dist |
| Subject | Bug#1093193: broadcom-sta-dkms: Enable AppStream metainfo XML |
| Date | 2025-02-06 14:40 +0100 |
| Message-ID | <KdagO-ePTL-5@gated-at.bofh.it> (permalink) |
| References | (2 earlier) <K8GU2-bFZN-11@gated-at.bofh.it> <Kd7VD-eOaN-19@gated-at.bofh.it> <Kd85j-eOfx-3@gated-at.bofh.it> <K5vir-9kPA-9@gated-at.bofh.it> <Kd85j-eOfx-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
These were the originally reported problems: broadcom-sta-dkms.metainfo.xml E: broadcom-sta-dkms:3: cid-is-not-rdns broadcom-sta-dkms I: broadcom-sta-dkms:3: cid-contains-hyphen broadcom-sta-dkms E: broadcom-sta-dkms:4: metadata-license-invalid PD ✘ Validation failed: errors: 2, infos: 1, pedantic: 1 And this is the patch to fix it. The ID and file should avoid '-', and need to list a acceptable license. I propose MIT, but there are more PD like licenses that could be used instead. diff --git a/debian/broadcom-sta-dkms.metainfo.xml b/debian/com.broadcom.linux.broadcom_sta.dkms.metainfo.xml similarity index 94% rename from debian/broadcom-sta-dkms.metainfo.xml rename to debian/com.broadcom.linux.broadcom_sta.dkms.metainfo.xml index a071867..3059622 100644 --- a/debian/broadcom-sta-dkms.metainfo.xml +++ b/debian/com.broadcom.linux.broadcom_sta.dkms.metainfo.xml @@ -1,7 +1,7 @@ <?xml version="1.0" encoding="UTF-8"?> <component> - <id>broadcom-sta-dkms</id> - <metadata_license>PD</metadata_license> + <id>com.broadcom.linux.broadcom_sta.dkms</id> + <metadata_license>MIT</metadata_license> <name>broadcom-sta-dkms</name> <summary>Drivers for certain Broadcom WiFi network interfaces</summary> <description> diff --git a/debian/rules b/debian/rules index ec7300e..37e1124 100755 --- a/debian/rules +++ b/debian/rules @@ -17,7 +17,7 @@ dkms_target := usr/src/$(source_name)-$(version) ids_dir := usr/share/broadcom-sta # AppStream data -metadata_dir := usr/share/appdata +metadata_dir := usr/share/metainfo %: dh $@ @@ -36,8 +36,7 @@ install-dkms: install-tmp dh_installdirs -p $(dkms_package) $(dkms_target) dh_install -p $(dkms_package) debian/tmp/* $(dkms_target)/ dh_install -p $(dkms_package) debian/broadcom-sta.ids $(ids_dir)/ -# disable the AppStream metadata until it's clear how to work around confusion with the devices supported by the free driver -# dh_install -p $(dkms_package) debian/broadcom-sta-dkms.metainfo.xml $(metadata_dir)/ + dh_install -p $(dkms_package) debian/com.broadcom.linux.broadcom_sta.dkms.metainfo.xml $(metadata_dir)/ install-source: install-tmp dh_installdirs -p $(source_package) $(source_target) -- Happy hacking Petter Reinholdtsen
Back to linux.debian.bugs.dist | Previous | Next — Previous in thread | Find similar | Unroll thread
Bug#1093193: broadcom-sta-dkms: Enable AppStream metainfo XML Petter Reinholdtsen <pere@hungry.com> - 2025-01-25 06:30 +0100
Bug#1093193: broadcom-sta-dkms: Enable AppStream metainfo XML Eduard Bloch <edi@gmx.de> - 2025-02-06 12:10 +0100
Bug#1093193: broadcom-sta-dkms: Enable AppStream metainfo XML Petter Reinholdtsen <pere@hungry.com> - 2025-02-06 12:20 +0100
Bug#1093193: broadcom-sta-dkms: Enable AppStream metainfo XML Petter Reinholdtsen <pere@hungry.com> - 2025-02-06 14:40 +0100
csiph-web