Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.debian.bugs.dist > #1189239 > unrolled thread
| Started by | Paride Legovini <paride@debian.org> |
|---|---|
| First post | 2024-03-06 11:30 +0100 |
| Last post | 2024-03-08 02:30 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.debian.bugs.dist
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Bug#1055438: kea: init-scripts not working Paride Legovini <paride@debian.org> - 2024-03-06 11:30 +0100
Bug#1055438: kea: init-scripts not working Stefan Klein <s-k02@caipora.net> - 2024-03-08 02:30 +0100
| From | Paride Legovini <paride@debian.org> |
|---|---|
| Date | 2024-03-06 11:30 +0100 |
| Subject | Bug#1055438: kea: init-scripts not working |
| Message-ID | <IeWH7-eMEQ-1@gated-at.bofh.it> |
On 2023-11-06 02:56, Stefan Klein wrote: > I appreciate that you include init scripts and support init diversity. > > Unfortunately those script don't work as expected. I fixed them and made > them mimic the behaviour of the Systemd service files as closely as > possible. > > It would be nice if you could apply the attached patch to: [...] Hello Stefan, We are not really able to do much QA on the init scripts; what I can offer is a LGTM-level review, and your patch definitely ticks that box. I prepared a MR including your changes: https://salsa.debian.org/debian/isc-kea/-/merge_requests/53 CI passes, but CI only tests on the default init system, so don't trust that too much. Given that some time passed since when you submitted the patch, I'd appreciate your final green light on proceeding with the merge (here on the bts or on salsa, if you happen to have an account there). @Luigi: OTOH your patch does not appear to be complete. I suggest to resubmit it after Stefan's patch lands. Cheers, Paride
[toc] | [next] | [standalone]
| From | Stefan Klein <s-k02@caipora.net> |
|---|---|
| Date | 2024-03-08 02:30 +0100 |
| Message-ID | <IfxdD-f8Z1-5@gated-at.bofh.it> |
| In reply to | #1189239 |
Hello Paride, thank you for looking at the patch again and rating it as good enough. I fully understand your point about the problems with init-script QA... The merge request you prepared contains all the changes I made. So this mail is my final green light, that MR contains the code that worked for me! Sorry for doing that via mail only. I am currently on vacation and don't have access to my Salsa account :( Stefan
[toc] | [prev] | [standalone]
Back to top | Article view | linux.debian.bugs.dist
csiph-web