Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #1189239

Bug#1055438: kea: init-scripts not working

Show all headers | View raw

On 2023-11-06 02:56, Stefan Klein wrote:
> I appreciate that you include init scripts and support init diversity.
> 
> Unfortunately those script don't work as expected. I fixed them and made
> them mimic the behaviour of the Systemd service files as closely as
> possible.
> 
> It would be nice if you could apply the attached patch to:
[...]

Hello Stefan,

We are not really able to do much QA on the init scripts; what I can offer
is a LGTM-level review, and your patch definitely ticks that box.

I prepared a MR including your changes:

https://salsa.debian.org/debian/isc-kea/-/merge_requests/53

CI passes, but CI only tests on the default init system, so don't trust
that too much. Given that some time passed since when you submitted the
patch, I'd appreciate your final green light on proceeding with the merge
(here on the bts or on salsa, if you happen to have an account there).

@Luigi: OTOH your patch does not appear to be complete. I suggest to
resubmit it after Stefan's patch lands.

Cheers,

Paride

Back to linux.debian.bugs.dist | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Bug#1055438: kea: init-scripts not working Paride Legovini <paride@debian.org> - 2024-03-06 11:30 +0100
  Bug#1055438: kea: init-scripts not working Stefan Klein <s-k02@caipora.net> - 2024-03-08 02:30 +0100

csiph-web