Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > comp.lang.python > #79905

Python Style Question

Newsgroups comp.lang.python
Date 2014-10-29 03:42 -0700
Message-ID <406463d0-1287-49a2-b1ed-08a928db4b94@googlegroups.com> (permalink)
Subject Python Style Question
From Anton <anton.schattenfeld@gmail.com>

Show all headers | View raw


Let's say I have an incoming list of values *l*. Every element of *l* can be one of the following options:
1) an integer value 
2) a string in form of '<int_value>', e.g. '7'
3) a string with a json serialization of an integer value, e.g. '"7"'
4) something else that should be ignored

I need to transform this list into another list with values from options 1)-3) coerced to int. The code below should do this.


Variant 1
===

values = []
for c in l:
	# Case 1) or 2)
	try:
		c_int = int(c)
	except ValueError:
		pass
	else:
		values.add(c_int)
		continue

	# Case 3)
	try:
		c_int = int(json.loads(c))
	except ValueError:
		pass
	else:
		values.add(c_int)
		continue

===

Is this code ugly? 
Does it follow EAFP? 
Am I missing something in language best practice?

Or maybe below is more preferable way with a nested try...except clause?

Variant 2
===
values = []
for c in l:
	# Case 1) or 2)
	try:
		c_int = int(c)
	except ValueError:
	
		# Case 3)
		try:
			c_int = int(json.loads(c))
		except ValueError:
			pass
		else:
			values.add(c_int)
			continue
			
	else:
		values.add(c_int)
		continue
===

Thanks,
Anton.

Back to comp.lang.python | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

Python Style Question Anton <anton.schattenfeld@gmail.com> - 2014-10-29 03:42 -0700
  Re: Python Style Question Martin Kemp <martin.kemp@ingg.com> - 2014-10-29 11:25 +0000
  Re: Python Style Question Rafael Romero Carmona <rafaelromcar@gmail.com> - 2014-10-29 12:09 +0100
    Re: Python Style Question Anton <anton.schattenfeld@gmail.com> - 2014-10-29 12:09 -0700
  Re: Python Style Question Rafael Romero Carmona <rafaelromcar@gmail.com> - 2014-10-29 12:52 +0100
    Re: Python Style Question Anton <anton.schattenfeld@gmail.com> - 2014-10-29 12:23 -0700
  Re: Python Style Question Martin Kemp <martin.kemp@ingg.com> - 2014-10-29 12:42 +0000
  Re: Python Style Question Steven D'Aprano <steve+comp.lang.python@pearwood.info> - 2014-10-30 22:10 +1100
    Re: Python Style Question MRAB <python@mrabarnett.plus.com> - 2014-10-30 12:21 +0000
      Re: Python Style Question Steven D'Aprano <steve+comp.lang.python@pearwood.info> - 2014-10-31 09:48 +1100
        Re: Python Style Question Denis McMahon <denismfmcmahon@gmail.com> - 2014-10-31 04:55 +0000
    Re: Python Style Question Roy Smith <roy@panix.com> - 2014-10-30 20:34 -0400
      Re: Python Style Question Steven D'Aprano <steve+comp.lang.python@pearwood.info> - 2014-10-31 14:52 +1100
    Re: Python Style Question Anton <anton.schattenfeld@gmail.com> - 2014-11-12 12:31 -0800

csiph-web