Re: ISO 8601 Code Review Wanted

Path	csiph.com!v102.xanadu-bbs.net!xanadu-bbs.net!feeder.erje.net!us.feeder.erje.net!news2.arglkargh.de!news.swapon.de!eternal-september.org!feeder.eternal-september.org!news.eternal-september.org!.POSTED!not-for-mail
From	John Harris <niam@jghnorth.org.uk.invalid>
Newsgroups	comp.lang.javascript
Subject	Re: ISO 8601 Code Review Wanted
Date	Thu, 15 May 2014 10:15:24 +0100
Organization	A noiseless patient Spider
Lines	39
Message-ID	<2c19n9t3bjgb68j83gcsv97q1fodt6c38b@4ax.com> (permalink)
References	<8eb3b763-31e1-47b3-9d26-5acbc8662216@googlegroups.com>
Reply-To	jgharris@ic4life.net
Mime-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Transfer-Encoding	7bit
Injection-Info	mx05.eternal-september.org; posting-host="21ad42a9e7ffec65f0c6a3171a433434"; logging-data="24990"; mail-complaints-to="abuse@eternal-september.org"; posting-account="U2FsdGVkX1+RhRJnJuGVeeEFU16fzQmn2Vw98ny8cm0="
User-Agent	ForteAgent/7.20.32.1218
Cancel-Lock	sha1:5k1Y/FqTau8SxtzTU1pIZVODZfQ=
Xref	csiph.com comp.lang.javascript:24169

Show key headers only | View raw

On Wed, 14 May 2014 09:59:23 -0700 (PDT), garrett.smith@acxiom.com
wrote:

>Hey folks. I've got some code here that I'd like review on.
>
>
>FYI - The ProgramCode below gets compiled into a function body, so these aren't globals, but locals, which get used by an exposed interface object (DateRange).
>
>
>
>"use strict";
>
>/**
> * @param {string} start local date,
> *   ISO8601 extended format.
> * @param {string} end local date,
> *   ISO8601 extended format.
> *
> * Accepted ISO8601 extended formats:
> * YYYY-MM-DD
> * YYYY-MM-DDThh
> * YYYY-MM-DDThh:mm
> * YYYY-MM-DDThh:mm:ss
> *
> * @throws {RangeError} if startDate isn't less
> * than or equal to endDate.
> *
> */
>function DateRange(start, end) {

  <snip>
Your preamble comment doesn't say what the code is required to do, nor
what type it returns (or passes on). Is it a number, a string, a
boolean? This makes code reviewing too much of a guess.

As you might surmise, I'm not a fan of this kind of formulaic
pre-amble; there's too much non-thinking about it.

  John

Thread

ISO 8601 Code Review Wanted garrett.smith@acxiom.com - 2014-05-14 09:59 -0700
  Re: ISO 8601 Code Review Wanted John Harris <niam@jghnorth.org.uk.invalid> - 2014-05-15 10:15 +0100
    Re: ISO 8601 Code Review Wanted Christoph Michael Becker <cmbecker69@arcor.de> - 2014-05-15 21:31 +0200
      Re: ISO 8601 Code Review Wanted dhtml <dhtmlkitchen@gmail.com> - 2014-05-15 12:53 -0700
        Re: ISO 8601 Code Review Wanted dhtml <dhtmlkitchen@gmail.com> - 2014-05-15 13:12 -0700
        Re: ISO 8601 Code Review Wanted Christoph Michael Becker <cmbecker69@arcor.de> - 2014-05-15 22:21 +0200
          Re: ISO 8601 Code Review Wanted "Evertjan." <exxjxw.hannivoort@inter.nl.net> - 2014-05-16 00:44 +0200
            Re: ISO 8601 Code Review Wanted Christoph Michael Becker <cmbecker69@arcor.de> - 2014-05-16 01:26 +0200
              Re: ISO 8601 Code Review Wanted "Evertjan." <exxjxw.hannivoort@inter.nl.net> - 2014-05-16 09:39 +0200
                bitwise vs. logical OR operator (was: ISO 8601 Code Review Wanted) Christoph Michael Becker <cmbecker69@arcor.de> - 2014-05-16 12:50 +0200
                Re: bitwise vs. logical OR operator (was: ISO 8601 Code Review Wanted) dhtml <dhtmlkitchen@gmail.com> - 2014-05-16 11:21 -0700
  Re: ISO 8601 Code Review Wanted Dr J R Stockton <reply1400@merlyn.demon.co.uk.invalid> - 2014-05-16 22:26 +0100
    Re: ISO 8601 Code Review Wanted dhtml <dhtmlkitchen@gmail.com> - 2014-05-19 11:56 -0700
      Re: ISO 8601 Code Review Wanted dhtml <dhtmlkitchen@gmail.com> - 2014-05-19 17:03 -0700
        Re: ISO 8601 Code Review Wanted Dr J R Stockton <reply1400@merlyn.demon.co.uk.invalid> - 2014-05-21 17:30 +0100
          Re: ISO 8601 Code Review Wanted John Harris <niam@jghnorth.org.uk.invalid> - 2014-05-22 10:20 +0100
            Re: ISO 8601 Code Review Wanted Dr J R Stockton <reply1400@merlyn.demon.co.uk.invalid> - 2014-05-23 20:44 +0100
              Re: ISO 8601 Code Review Wanted John Harris <niam@jghnorth.org.uk.invalid> - 2014-05-24 15:54 +0100
          Re: ISO 8601 Code Review Wanted Tim Streater <timstreater@greenbee.net> - 2014-05-22 18:46 +0100
            Re: ISO 8601 Code Review Wanted dhtml <dhtmlkitchen@gmail.com> - 2014-05-25 22:18 -0700
              Re: ISO 8601 Code Review Wanted Tim Streater <timstreater@greenbee.net> - 2014-05-26 11:41 +0100
                Re: ISO 8601 Code Review Wanted dhtml <dhtmlkitchen@gmail.com> - 2014-05-28 09:54 -0700
          Re: ISO 8601 Code Review Wanted dhtml <dhtmlkitchen@gmail.com> - 2014-05-23 10:37 -0700
            Re: ISO 8601 Code Review Wanted Dr J R Stockton <reply1400@merlyn.demon.co.uk.invalid> - 2014-05-24 19:09 +0100
  Re: ISO 8601 Code Review Wanted dhtml <dhtmlkitchen@gmail.com> - 2014-05-23 13:14 -0700

csiph-web