Groups > comp.lang.java.programmer > #29689

Re: local constants with switch

Path	csiph.com!v102.xanadu-bbs.net!xanadu-bbs.net!feeder.erje.net!eu.feeder.erje.net!news.swapon.de!eternal-september.org!feeder.eternal-september.org!news.eternal-september.org!.POSTED!not-for-mail
From	Andreas Leitgeb <avl@auth.logic.tuwien.ac.at>
Newsgroups	comp.lang.java.programmer
Subject	Re: local constants with switch
Date	Sat, 16 Aug 2014 09:17:08 +0000 (UTC)
Organization	A noiseless patient Spider
Lines	19
Message-ID	<slrnluu8ck.fp3.avl@login.logic.tuwien.ac.at> (permalink)
References	<slrnlukhpi.fp3.avl@login.logic.tuwien.ac.at> <53eec51f$0$302$14726298@news.sunsite.dk>
Reply-To	avl@logic.at
Mime-Version	1.0
Content-Type	text/plain; charset=UTF-8
Content-Transfer-Encoding	8bit
Injection-Date	Sat, 16 Aug 2014 09:17:08 +0000 (UTC)
Injection-Info	mx05.eternal-september.org; posting-host="7fd0c836d94caf9f0b88d96117d7c68e"; logging-data="30815"; mail-complaints-to="abuse@eternal-september.org"; posting-account="U2FsdGVkX19vPFWnhZE/tmTJeokuh3tf"
User-Agent	slrn/pre1.0.0-18 (Linux)
Cancel-Lock	sha1:bFyjAC4oiXSl5IEl06ncuYA4FxU=
Xref	csiph.com comp.lang.java.programmer:29689

Show key headers only | View raw

Arne Vajhøj <arne@vajhoej.dk> wrote:
> I am somewhat skeptical about the usefulness of this feature.
>
> A single method that defines local constants and use them as
> case labels is very likely a code smell.
>
> If the variable being switches on is external, then the constants
> should be non-local and used both inside and outside.
>
> If it is internal and first there are some logic to assign one
> the constants to the variable and then later in the code comes
> the switch, then I think there is a good chance that the method
> is too long and does too much.

Unfortunately, I have to agree...

The involved code indeed smells badly, and afterall I apparently
didn't really miss all that much, before stumbling over it.

Back to comp.lang.java.programmer | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

local constants with switch Andreas Leitgeb <avl@auth.logic.tuwien.ac.at> - 2014-08-12 16:56 +0000
  Re: local constants with switch Donkey Hottie <donkey@fredriksson.dy.fi> - 2014-08-12 20:30 +0300
  Re: local constants with switch Andreas Leitgeb <avl@auth.logic.tuwien.ac.at> - 2014-08-12 21:15 +0000
    Re: local constants with switch Silvio <silvio@internet.com> - 2014-08-12 23:20 +0200
    Re: local constants with switch Silvio <silvio@internet.com> - 2014-08-12 23:22 +0200
  Re: local constants with switch Lew <lewbloch@gmail.com> - 2014-08-15 15:22 -0700
    Re: local constants with switch Andreas Leitgeb <avl@auth.logic.tuwien.ac.at> - 2014-08-16 00:24 +0000
      Re: local constants with switch Roedy Green <see_website@mindprod.com.invalid> - 2014-08-18 23:46 -0700
        Re: local constants with switch Andreas Leitgeb <avl@auth.logic.tuwien.ac.at> - 2014-08-21 13:57 +0000
          Re: local constants with switch Joerg Meier <joergmmeier@arcor.de> - 2014-08-21 18:52 +0200
            Re: local constants with switch Mike Amling <mamling@chaff.us> - 2014-08-21 13:19 -0500
              Re: local constants with switch Joerg Meier <joergmmeier@arcor.de> - 2014-08-21 22:41 +0200
            [OT] Re: local constants with switch Eric Sosman <esosman@comcast-dot-net.invalid> - 2014-08-21 14:42 -0400
              Re: [OT] Re: local constants with switch Andreas Leitgeb <avl@auth.logic.tuwien.ac.at> - 2014-08-21 19:21 +0000
                Re: [OT] Re: local constants with switch Joshua Cranmer 🐧 <Pidgeot18@verizon.invalid> - 2014-08-21 22:30 -0500
                Re: [OT] Re: local constants with switch Silvio <silvio@internet.com> - 2014-08-23 14:01 +0200
                Re: [OT] Re: local constants with switch Andreas Leitgeb <avl@auth.logic.tuwien.ac.at> - 2014-08-23 15:22 +0000
              Re: [OT] Re: local constants with switch Arne Vajhøj <arne@vajhoej.dk> - 2014-08-23 22:12 -0400
          Re: local constants with switch Jim Gibson <jimsgibson@gmail.com> - 2014-08-21 17:04 -0700
            [OT] Re: local constants with switch Eric Sosman <esosman@comcast-dot-net.invalid> - 2014-08-21 20:50 -0400
              Re: [OT] Re: local constants with switch Martin Gregorie <martin@address-in-sig.invalid> - 2014-08-22 11:48 +0000
  Re: local constants with switch Joerg Meier <joergmmeier@arcor.de> - 2014-08-16 01:18 +0200
    Re: local constants with switch Arne Vajhøj <arne@vajhoej.dk> - 2014-08-15 22:44 -0400
      Re: local constants with switch Andreas Leitgeb <avl@auth.logic.tuwien.ac.at> - 2014-08-16 09:01 +0000
        Re: local constants with switch Joerg Meier <joergmmeier@arcor.de> - 2014-08-16 12:08 +0200
        Re: local constants with switch Arne Vajhøj <arne@vajhoej.dk> - 2014-08-16 20:39 -0400
          Re: local constants with switch Joerg Meier <joergmmeier@arcor.de> - 2014-08-17 13:08 +0200
      Re: local constants with switch Joerg Meier <joergmmeier@arcor.de> - 2014-08-16 12:07 +0200
  Re: local constants with switch Arne Vajhøj <arne@vajhoej.dk> - 2014-08-15 22:42 -0400
    Re: local constants with switch Andreas Leitgeb <avl@auth.logic.tuwien.ac.at> - 2014-08-16 09:17 +0000

csiph-web