Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.java.programmer > #31882

Re: basic output question

Show key headers only | View raw

On 6/29/2015 2:39 PM, Russ P. wrote:
> Suppose I need a function (or method) for printing some (text-based) information to a file or to standard output. What is the recommended way to do this while minimizing duplication of code? Here's a simplification of what I came up with (in Scala, but using the Java standard library):
>
>      def printInformation(out: java.io.PrintStream = System.out) {
>
>          // print information here
>          }
>
>      def printInformation(fileName: String) {
>          printInformation(new java.io.PrintStream(fileName))
>          }
>
> So if I call printInformation with no arguments, the output goes to standard output, but if I give it a filename the output goes to the file. Is this the best way to do it, or is there a simpler/better way? I'd also like to be able to append the output to an existing file as well as create a new file. Thanks.

     I'm not Scalacious and may misunderstand your intent, but it
seems a poor idea to create a brand-new PrintStream every time you
call printInformation().  You don't show them being closed, which
means they'll hang around until they're garbage-collected.  Also,
late arrivals will (attempt to) empty the output file and clobber
whatever the early birds may already have written.

     Instead, I'd suggest providing the PrintStream rather than
the file name: That way, you control the "external" aspects of the
stream and let the method focus solely on generating output:

	void printInfo(PrintStream out) {
	    // print information here
	}

     A simple overload handles the System.out default:

	void printInfo() {
	    printInfo(System.out);
	}

     As for appending vs. overwriting, that's a choice you can make
when you construct the PrintStream.  Instead of using the convenience
constructors that take a file name or a File, build the OutputStream
explicitly and construct the PrintStream from it:

	boolean append = ...;  // true to append, false to clobber
	PrintStream out = new PrintStream(
	    new FileOutputStream(fileName, append));

     Finally, note that separating the stream-handling from the
output-generation gives you more flexibility: You can now send output
to any destination you like, not just to a file.

     "Really finally," I second Arne Vajhøj's suggestion that you might
want to consider using an existing logging framework instead of rolling
your own wheel.  Much depends on what kind of information you're
printing and on what uses you'll make of it, but if it's "status and
progress" kind of stuff -- well, that's what logging's for.

-- 
esosman@comcast-dot-net.invalid
"Don't be afraid of work. Make work afraid of you." -- TLM

Back to comp.lang.java.programmer | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

basic output question "Russ P." <russ.paielli@gmail.com> - 2015-06-29 11:39 -0700
  Re: basic output question Arne Vajhøj <arne@vajhoej.dk> - 2015-06-29 14:53 -0400
  Re: basic output question Eric Sosman <esosman@comcast-dot-net.invalid> - 2015-06-29 15:32 -0400
  Re: basic output question e.d.programmer@gmail.com - 2015-06-30 05:45 -0700
    Re: basic output question Eric Sosman <esosman@comcast-dot-net.invalid> - 2015-06-30 09:05 -0400
      Re: basic output question e.d.programmer@gmail.com - 2015-06-30 11:28 -0700
        Re: basic output question Arne Vajhøj <arne@vajhoej.dk> - 2015-06-30 14:55 -0400
          Re: basic output question e.d.programmer@gmail.com - 2015-06-30 12:14 -0700
            Re: basic output question Arne Vajhøj <arne@vajhoej.dk> - 2015-07-27 22:25 -0400
        Re: basic output question Eric Sosman <esosman@comcast-dot-net.invalid> - 2015-06-30 15:27 -0400

csiph-web