Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > comp.lang.c++ > #72770

Re: Help needed

From Christian Gollwitzer <auriocus@gmx.de>
Newsgroups comp.lang.c++
Subject Re: Help needed
Date 2020-04-03 22:01 +0200
Organization A noiseless patient Spider
Message-ID <r684ml$imf$1@dont-email.me> (permalink)
References <66b94985-7db1-41e1-98f7-e509c5a0a142@googlegroups.com> <r67s55$4oi$1@news.albasani.net>

Show all headers | View raw


Am 03.04.20 um 19:35 schrieb Bonita Montero:
> I just tried to compile your SP62-program. There are a lot assignments
> of string-literals to non-const string-pointers. In C++ every string
> -literal has the type "const char *"; I don't know if this has ever
> been different in earlier versions of C++, but earlier versions of
> MSVC accepted the assignment of string-literals to char-pointers. So
> you have to make your c-strings const. And there are a lot of erors
> which advise you to use safe versions of C-runtime-functions which
> are not prone to buffer-overflows. You can disable this errors by
> defining _CRT_SECURE_NO_WARNINGS or you could use the safer versions
> the error-message shows you.

I also tried to compile the SP71 program. There were only 7 real errors. 
There is the idiotic for-scoping that was wrong in VC6. In VC 6, if you 
write

for (int i=0; i<n; i++) { }

then the i variable belongs to the outer block, whereas in C++ since 
1998 it belongs to the for block. So shift this to

int i;
for (i=0; i<n; i++) { }

to get the same effect. Then there was an default-to-int static variable 
without a type; even the compiler knew how to fix it:


SP71_lib.cpp:16155:9: error: C++ requires a type specifier for all 
declarations
         static column_counter = 0 ;
         ~~~~~~ ^
1 error generated.

and a missing comma in a sequence of declarations; I wonder how that 
ever could compile.

Now it compiles on clang, but with 283 warnings, of course. Here's the diff:

Apfelkiste:Tests chris$ diff -r SP_new/ SP
diff -r SP_new/SP71_head.h SP/SP71_head.h
660c660
< 			{symbol *s ; int i; for (i = 0; i < sequence_depth; i++)
---
 > 			{symbol *s ; for (int i = 0; i < sequence_depth; i++)
diff -r SP_new/SP71_lib.cpp SP/SP71_lib.cpp
2347c2347
< 	for (int i = 1; i < start_col_2; i++)
---
 > 	for (i = 1; i < start_col_2; i++)
12200c12200
< 		*t_pattern = get_row_pattern(bottom_row),
---
 > 		*t_pattern = get_row_pattern(bottom_row)
16155c16155
< 	static int column_counter = 0 ;
---
 > 	static column_counter = 0 ;
Only in SP_new/: a.out
Apfelkiste:Tests chris$


Christian

Back to comp.lang.c++ | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

Help needed Gerry Wolff <gerrywolff65@gmail.com> - 2020-04-03 09:56 -0700
  Re: Help needed Mr Flibble <flibbleREMOVETHISBIT@i42.co.uk> - 2020-04-03 18:18 +0100
    Re: Help needed Ned Latham <nedlatham@woden.valhalla.oz> - 2020-04-03 12:57 -0500
      Re: Help needed Melzzzzz <Melzzzzz@zzzzz.com> - 2020-04-03 18:17 +0000
        Re: Help needed Ned Latham <nedlatham@woden.valhalla.oz> - 2020-04-03 16:41 -0500
      Re: Help needed James Kuyper <jameskuyper@alumni.caltech.edu> - 2020-04-03 14:58 -0400
        Re: Help needed Ned Latham <nedlatham@woden.valhalla.oz> - 2020-04-03 16:45 -0500
          Re: Help needed Ned Latham <nedlatham@woden.valhalla.oz> - 2020-04-03 17:52 -0500
      Re: Help needed Jorgen Grahn <grahn+nntp@snipabacken.se> - 2020-04-03 20:05 +0000
        Re: Help needed Ned Latham <nedlatham@woden.valhalla.oz> - 2020-04-03 16:58 -0500
          Re: Help needed Ned Latham <nedlatham@woden.valhalla.oz> - 2020-04-03 17:50 -0500
          Re: Help needed James Kuyper <jameskuyper@alumni.caltech.edu> - 2020-04-04 00:15 -0400
            Re: Help needed Ned Latham <nedlatham@woden.valhalla.oz> - 2020-04-03 23:58 -0500
              Re: Help needed Ian Collins <ian-news@hotmail.com> - 2020-04-04 18:06 +1300
                Re: Help needed Ned Latham <nedlatham@woden.valhalla.oz> - 2020-04-04 00:35 -0500
                Re: Help needed Ian Collins <ian-news@hotmail.com> - 2020-04-04 19:54 +1300
                Re: Help needed Ned Latham <nedlatham@woden.valhalla.oz> - 2020-04-04 02:22 -0500
                Re: Help needed Bo Persson <bo@bo-persson.se> - 2020-04-04 10:33 +0200
                Re: Help needed Ned Latham <nedlatham@woden.valhalla.oz> - 2020-04-04 04:55 -0500
                Re: Help needed David Brown <david.brown@hesbynett.no> - 2020-04-04 13:02 +0200
                Re: Help needed Ned Latham <nedlatham@woden.valhalla.oz> - 2020-04-04 07:15 -0500
                Re: Help needed David Brown <david.brown@hesbynett.no> - 2020-04-04 16:49 +0200
                Re: Help needed Ned Latham <nedlatham@woden.valhalla.oz> - 2020-04-05 04:10 -0500
                Re: Help needed Mr Flibble <flibbleREMOVETHISBIT@i42.co.uk> - 2020-04-05 16:31 +0100
                Re: Help needed Ned Latham <nedlatham@woden.valhalla.oz> - 2020-04-05 11:37 -0500
                Re: Help needed Bonita Montero <Bonita.Montero@gmail.com> - 2020-04-04 14:19 +0200
                Re: Help needed David Brown <david.brown@hesbynett.no> - 2020-04-04 16:57 +0200
                Re: Help needed James Kuyper <jameskuyper@alumni.caltech.edu> - 2020-04-04 10:51 -0400
                Re: Help needed James Kuyper <jameskuyper@alumni.caltech.edu> - 2020-04-04 10:44 -0400
                Re: Help needed Ned Latham <nedlatham@woden.valhalla.oz> - 2020-04-05 04:06 -0500
                Re: Help needed James Kuyper <jameskuyper@alumni.caltech.edu> - 2020-04-05 11:04 -0400
                Re: Help needed Ned Latham <nedlatham@woden.valhalla.oz> - 2020-04-05 11:31 -0500
                Re: Help needed James Kuyper <jameskuyper@alumni.caltech.edu> - 2020-04-05 16:59 -0400
                Re: Help needed Ned Latham <nedlatham@woden.valhalla.oz> - 2020-04-05 21:38 -0500
              Re: Help needed "Alf P. Steinbach" <alf.p.steinbach+usenet@gmail.com> - 2020-04-04 13:51 +0200
                Re: Help needed Ned Latham <nedlatham@woden.valhalla.oz> - 2020-04-04 08:33 -0500
                Re: Help needed Ian Collins <ian-news@hotmail.com> - 2020-04-05 07:35 +1200
                Re: Help needed Ned Latham <nedlatham@woden.valhalla.oz> - 2020-04-05 04:19 -0500
                Re: Help needed James Kuyper <jameskuyper@alumni.caltech.edu> - 2020-04-05 11:27 -0400
                Re: Help needed James Kuyper <jameskuyper@alumni.caltech.edu> - 2020-04-04 22:27 -0400
                Re: Help needed Mr Flibble <flibbleREMOVETHISBIT@i42.co.uk> - 2020-04-04 14:50 +0100
              Re: Help needed James Kuyper <jameskuyper@alumni.caltech.edu> - 2020-04-04 10:27 -0400
                Re: Help needed Ian Collins <ian-news@hotmail.com> - 2020-04-05 07:37 +1200
                Re: Help needed Ned Latham <nedlatham@woden.valhalla.oz> - 2020-04-05 03:45 -0500
          Re: Help needed Paavo Helde <myfirstname@osa.pri.ee> - 2020-04-04 09:02 +0300
            Re: Help needed Ned Latham <nedlatham@woden.valhalla.oz> - 2020-04-04 01:20 -0500
              Re: Help needed Ian Collins <ian-news@hotmail.com> - 2020-04-04 19:43 +1300
                Re: Help needed Ned Latham <nedlatham@woden.valhalla.oz> - 2020-04-04 02:10 -0500
                Re: Help needed Keith Thompson <Keith.S.Thompson+u@gmail.com> - 2020-04-04 01:58 -0700
                Re: Help needed Ned Latham <nedlatham@woden.valhalla.oz> - 2020-04-04 05:04 -0500
                Re: Help needed Paavo Helde <myfirstname@osa.pri.ee> - 2020-04-04 14:37 +0300
                Re: Help needed Ned Latham <nedlatham@woden.valhalla.oz> - 2020-04-04 07:25 -0500
                Re: Help needed Paavo Helde <eesnimi@osa.pri.ee> - 2020-04-04 17:39 +0300
                Re: Help needed Ned Latham <nedlatham@woden.valhalla.oz> - 2020-04-05 04:02 -0500
  Re: Help needed Bonita Montero <Bonita.Montero@gmail.com> - 2020-04-03 19:35 +0200
    Re: Help needed Bonita Montero <Bonita.Montero@gmail.com> - 2020-04-03 20:01 +0200
      Re: Help needed Bonita Montero <Bonita.Montero@gmail.com> - 2020-04-04 16:16 +0200
        Re: Help needed Bonita Montero <Bonita.Montero@gmail.com> - 2020-04-04 18:58 +0200
    Re: Help needed Christian Gollwitzer <auriocus@gmx.de> - 2020-04-03 22:01 +0200
      Re: Help needed Mr Flibble <flibbleREMOVETHISBIT@i42.co.uk> - 2020-04-03 21:05 +0100
        Re: Help needed Bo Persson <bo@bo-persson.se> - 2020-04-04 02:10 +0200
      Re: Help needed Jorgen Grahn <grahn+nntp@snipabacken.se> - 2020-04-04 08:19 +0000
      Re: Help needed Gerry Wolff <gerrywolff65@gmail.com> - 2020-04-05 02:56 -0700
    Re: Help needed Ben Bacarisse <ben.usenet@bsb.me.uk> - 2020-04-04 01:14 +0100
    Re: Help needed Gerry Wolff <gerrywolff65@gmail.com> - 2020-04-05 02:49 -0700
  Re: Help needed Sam <sam@email-scan.com> - 2020-04-04 16:30 -0400
    Re: Help needed Mr Flibble <flibbleREMOVETHISBIT@i42.co.uk> - 2020-04-05 05:58 +0100
    Re: Help needed Gerry Wolff <gerrywolff65@gmail.com> - 2020-04-05 03:21 -0700
      Re: Help needed Juha Nieminen <nospam@thanks.invalid> - 2020-04-07 06:33 +0000
        Re: Help needed Jorgen Grahn <grahn+nntp@snipabacken.se> - 2020-04-07 10:39 +0000

csiph-web