Re: Structured binding considered harmful

From	Ian Collins <ian-news@hotmail.com>
Newsgroups	comp.lang.c++
Subject	Re: Structured binding considered harmful
Date	2020-03-21 12:06 +1300
Message-ID	<hdl0iqF9v62U2@mid.individual.net> (permalink)
References	(9 earlier) <r52djc$9td$1@news.albasani.net> <0e3656df-8630-4c34-a986-457a394e7e5b@googlegroups.com> <4cec3c81-c988-47a7-9dee-f4158a20a46a@googlegroups.com> <908f81dc-f16d-4689-80e2-c67219ee269c@googlegroups.com> <dc422754-6ab6-4eb6-ac30-4efbeeceff11@googlegroups.com>

Show all headers | View raw

On 21/03/2020 06:36, Daniel wrote:
> On Friday, March 20, 2020 at 1:13:35 PM UTC-4, Öö Tiib wrote:
>>
>> And that is the other property of bad code, things named "iter", "ptr",
>> "data", "buf", "container" and other such "foo" and "poo".
> 
> I would use "it", for a local iterator variable :-) Also i/j/k for indices.

One of the first things I encourage my peers to change (and certainly 
the first thing I change) when modernising a loop is the iterator 
variable name.  Using the likes of "it" or "i" may have been natural 
before, where the variable was an iterator, but with a ranged for the 
variable as a type and should be maned as such.  So we have the likes of

   for( const auto& line : lines )

rather than

   for( std::vector<std::string>::const_iterator it = lines.begin();
        it != lines.end(); ++it )

-- 
Ian.

Thread

Structured binding considered harmful jacobnavia <jacob@jacob.remcomp.fr> - 2020-03-13 00:13 +0100
  Re: Structured binding considered harmful Maciej Sobczak <see.my.homepage@gmail.com> - 2020-03-13 00:46 -0700
    Re: Structured binding considered harmful jacobnavia <jacob@jacob.remcomp.fr> - 2020-03-14 09:10 +0100
  Re: Structured binding considered harmful Öö Tiib <ootiib@hot.ee> - 2020-03-13 09:40 -0700
    Re: Structured binding considered harmful jacobnavia <jacob@jacob.remcomp.fr> - 2020-03-14 09:05 +0100
      Re: Structured binding considered harmful Öö Tiib <ootiib@hot.ee> - 2020-03-14 03:19 -0700
        Re: Structured binding considered harmful Jorgen Grahn <grahn+nntp@snipabacken.se> - 2020-03-15 11:08 +0000
          Re: Structured binding considered harmful Öö Tiib <ootiib@hot.ee> - 2020-03-15 09:46 -0700
            Re: Structured binding considered harmful "Alf P. Steinbach" <alf.p.steinbach+usenet@gmail.com> - 2020-03-15 19:27 +0100
              Re: Structured binding considered harmful Keith Thompson <Keith.S.Thompson+u@gmail.com> - 2020-03-15 15:15 -0700
                Re: Structured binding considered harmful "Alf P. Steinbach" <alf.p.steinbach+usenet@gmail.com> - 2020-03-16 05:23 +0100
                Re: Structured binding considered harmful "Alf P. Steinbach" <alf.p.steinbach+usenet@gmail.com> - 2020-03-16 05:54 +0100
              Re: Structured binding considered harmful Öö Tiib <ootiib@hot.ee> - 2020-03-16 00:20 -0700
  Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-13 23:08 -0400
    Re: Structured binding considered harmful jacobnavia <jacob@jacob.remcomp.fr> - 2020-03-14 08:59 +0100
      Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-14 10:09 -0400
        Re: Structured binding considered harmful jacobnavia <jacob@jacob.remcomp.fr> - 2020-03-14 18:32 +0100
          Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-14 18:33 -0400
  Re: Structured binding considered harmful Bonita Montero <Bonita.Montero@gmail.com> - 2020-03-15 17:50 +0100
    Re: Structured binding considered harmful jacobnavia <jacob@jacob.remcomp.fr> - 2020-03-16 00:11 +0100
      Re: Structured binding considered harmful Bonita Montero <Bonita.Montero@gmail.com> - 2020-03-16 05:24 +0100
        Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-16 06:46 -0400
          Re: Structured binding considered harmful Bonita Montero <Bonita.Montero@gmail.com> - 2020-03-16 12:52 +0100
            Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-16 08:32 -0400
              Re: Structured binding considered harmful Bonita Montero <Bonita.Montero@gmail.com> - 2020-03-16 13:51 +0100
                Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-16 20:06 -0400
                Re: Structured binding considered harmful Bonita Montero <Bonita.Montero@gmail.com> - 2020-03-17 06:37 +0100
                Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-17 07:17 -0400
                Re: Structured binding considered harmful Bonita Montero <Bonita.Montero@gmail.com> - 2020-03-17 18:37 +0100
                Re: Structured binding considered harmful "Alf P. Steinbach" <alf.p.steinbach+usenet@gmail.com> - 2020-03-17 18:50 +0100
                Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-18 06:30 -0400
                Re: Structured binding considered harmful Bonita Montero <Bonita.Montero@gmail.com> - 2020-03-18 11:38 +0100
                Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-18 08:17 -0400
                Re: Structured binding considered harmful Bonita Montero <Bonita.Montero@gmail.com> - 2020-03-18 13:19 +0100
                Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-18 08:31 -0400
                Re: Structured binding considered harmful Bonita Montero <Bonita.Montero@gmail.com> - 2020-03-18 14:15 +0100
                Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-18 10:13 -0400
                Re: Structured binding considered harmful Bonita Montero <Bonita.Montero@gmail.com> - 2020-03-18 15:45 +0100
                Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-18 11:36 -0400
                Re: Structured binding considered harmful Bonita Montero <Bonita.Montero@gmail.com> - 2020-03-18 17:59 +0100
                Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-18 13:18 -0400
                Re: Structured binding considered harmful Bonita Montero <Bonita.Montero@gmail.com> - 2020-03-18 18:27 +0100
                Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-18 14:41 -0400
                Re: Structured binding considered harmful Bonita Montero <Bonita.Montero@gmail.com> - 2020-03-18 19:46 +0100
                Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-18 19:46 -0400
                Re: Structured binding considered harmful Bonita Montero <Bonita.Montero@gmail.com> - 2020-03-19 06:41 +0100
                Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-19 07:02 -0400
                Re: Structured binding considered harmful Bonita Montero <Bonita.Montero@gmail.com> - 2020-03-19 12:41 +0100
                Re: Structured binding considered harmful Öö Tiib <ootiib@hot.ee> - 2020-03-19 06:10 -0700
                Re: Structured binding considered harmful Bonita Montero <Bonita.Montero@gmail.com> - 2020-03-19 14:15 +0100
                Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-19 19:23 -0400
                Re: Structured binding considered harmful Bonita Montero <Bonita.Montero@gmail.com> - 2020-03-20 09:18 +0100
                Re: Structured binding considered harmful James Kuyper <jameskuyper@alumni.caltech.edu> - 2020-03-20 05:31 -0700
                Re: Structured binding considered harmful Bonita Montero <Bonita.Montero@gmail.com> - 2020-03-20 13:40 +0100
                Re: Structured binding considered harmful Öö Tiib <ootiib@hot.ee> - 2020-03-20 08:50 -0700
                Re: Structured binding considered harmful Daniel <danielaparker@gmail.com> - 2020-03-20 09:30 -0700
                Re: Structured binding considered harmful Öö Tiib <ootiib@hot.ee> - 2020-03-20 10:13 -0700
                Re: Structured binding considered harmful Daniel <danielaparker@gmail.com> - 2020-03-20 10:36 -0700
                Re: Structured binding considered harmful Ian Collins <ian-news@hotmail.com> - 2020-03-21 12:06 +1300
                Re: Structured binding considered harmful Öö Tiib <ootiib@hot.ee> - 2020-03-20 16:37 -0700
                Re: Structured binding considered harmful Daniel <danielaparker@gmail.com> - 2020-03-20 17:17 -0700
                Re: Structured binding considered harmful Öö Tiib <ootiib@hot.ee> - 2020-03-21 10:09 -0700
                Re: Structured binding considered harmful Daniel <danielaparker@gmail.com> - 2020-03-21 11:21 -0700
                Re: Structured binding considered harmful Öö Tiib <ootiib@hot.ee> - 2020-03-21 13:09 -0700
                Re: Structured binding considered harmful Jorgen Grahn <grahn+nntp@snipabacken.se> - 2020-03-21 22:33 +0000
                Re: Structured binding considered harmful Jorgen Grahn <grahn+nntp@snipabacken.se> - 2020-03-20 17:30 +0000
                Re: Structured binding considered harmful Daniel <danielaparker@gmail.com> - 2020-03-20 10:49 -0700
                Re: Structured binding considered harmful Jorgen Grahn <grahn+nntp@snipabacken.se> - 2020-03-20 18:47 +0000
                Re: Structured binding considered harmful Bonita Montero <Bonita.Montero@gmail.com> - 2020-03-20 17:41 +0100
                Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-20 18:06 -0400
                Re: Structured binding considered harmful Bonita Montero <Bonita.Montero@gmail.com> - 2020-03-21 06:31 +0100
                Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-21 09:50 -0400
                Re: Structured binding considered harmful Bonita Montero <Bonita.Montero@gmail.com> - 2020-03-21 14:59 +0100
                Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-21 10:42 -0400
                Re: Structured binding considered harmful Bonita Montero <Bonita.Montero@gmail.com> - 2020-03-21 16:09 +0100
                Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-21 11:12 -0400
                Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-20 18:05 -0400
                Re: Structured binding considered harmful Daniel <danielaparker@gmail.com> - 2020-03-20 15:57 -0700
                Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-20 23:23 -0400
                Re: Structured binding considered harmful Keith Thompson <Keith.S.Thompson+u@gmail.com> - 2020-03-20 21:08 -0700
                Re: Structured binding considered harmful Ralf Goertz <me@myprovider.invalid> - 2020-03-21 08:24 +0100
                Re: Structured binding considered harmful Daniel <danielaparker@gmail.com> - 2020-03-21 01:36 -0700
                Re: Structured binding considered harmful Bonita Montero <Bonita.Montero@gmail.com> - 2020-03-21 06:30 +0100
                Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-21 09:51 -0400
                Re: Structured binding considered harmful jacobnavia <jacob@jacob.remcomp.fr> - 2020-03-22 13:22 +0100
                Re: Structured binding considered harmful Jorgen Grahn <grahn+nntp@snipabacken.se> - 2020-03-22 13:24 +0000
                Re: Structured binding considered harmful James Kuyper <jameskuyper@alumni.caltech.edu> - 2020-03-22 06:32 -0700
                Re: Structured binding considered harmful Daniel <danielaparker@gmail.com> - 2020-03-22 07:59 -0700
                Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-22 13:02 -0400
                Re: Structured binding considered harmful Melzzzzz <Melzzzzz@zzzzz.com> - 2020-03-22 17:09 +0000
                Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-22 13:35 -0400
                Re: Structured binding considered harmful Melzzzzz <Melzzzzz@zzzzz.com> - 2020-03-22 17:54 +0000
                Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-22 17:19 -0400
                Re: Structured binding considered harmful Melzzzzz <Melzzzzz@zzzzz.com> - 2020-03-22 21:46 +0000
                Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-22 19:06 -0400
                Re: Structured binding considered harmful danielaparker@gmail.com - 2020-03-22 17:11 -0700
                Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-22 22:16 -0400
                Re: Structured binding considered harmful Chris Vine <chris@cvine--nospam--.freeserve.co.uk> - 2020-03-25 20:38 +0000
                Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-25 20:01 -0400
                Re: Structured binding considered harmful danielaparker@gmail.com - 2020-03-22 10:58 -0700
                Re: Structured binding considered harmful Ian Collins <ian-news@hotmail.com> - 2020-03-23 07:41 +1300
                Re: Structured binding considered harmful James Kuyper <jameskuyper@alumni.caltech.edu> - 2020-03-22 15:01 -0400
                Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-22 10:24 -0400
                Re: Structured binding considered harmful James Kuyper <jameskuyper@alumni.caltech.edu> - 2020-03-20 20:15 -0700
                Re: Structured binding considered harmful jacobnavia <jacob@jacob.remcomp.fr> - 2020-03-21 08:32 +0100
                Re: Structured binding considered harmful David Brown <david.brown@hesbynett.no> - 2020-03-21 11:27 +0100
                Re: Structured binding considered harmful Mr Flibble <flibbleREMOVETHISBIT@i42.co.uk> - 2020-03-21 13:34 +0000
                Re: Structured binding considered harmful Daniel <danielaparker@gmail.com> - 2020-03-21 07:11 -0700
                Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-21 10:45 -0400
                Re: Structured binding considered harmful Daniel <danielaparker@gmail.com> - 2020-03-21 08:03 -0700
                Re: Structured binding considered harmful Daniel <danielaparker@gmail.com> - 2020-03-19 08:24 -0700
                Re: Structured binding considered harmful Ian Collins <ian-news@hotmail.com> - 2020-03-19 09:05 +1300
                Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-18 19:47 -0400
                Re: Structured binding considered harmful James Kuyper <jameskuyper@alumni.caltech.edu> - 2020-03-18 11:43 -0700
                Re: Structured binding considered harmful Bonita Montero <Bonita.Montero@gmail.com> - 2020-03-18 19:48 +0100
                Re: Structured binding considered harmful James Kuyper <jameskuyper@alumni.caltech.edu> - 2020-03-18 12:37 -0700
          Re: Structured binding considered harmful jacobnavia <jacob@jacob.remcomp.fr> - 2020-03-16 16:11 +0100
            Re: Structured binding considered harmful Ian Collins <ian-news@hotmail.com> - 2020-03-17 08:17 +1300
            Re: Structured binding considered harmful Daniel <danielaparker@gmail.com> - 2020-03-16 13:12 -0700
            Re: Structured binding considered harmful Sam <sam@email-scan.com> - 2020-03-16 20:13 -0400
  Re: Structured binding considered harmful Melzzzzz <Melzzzzz@zzzzz.com> - 2020-03-17 19:46 +0000
    Re: Structured binding considered harmful Daniel <danielaparker@gmail.com> - 2020-03-21 01:43 -0700

csiph-web