Re: Oozing poison

Path	csiph.com!x330-a1.tempe.blueboxinc.net!usenet.pasdenom.info!news.albasani.net!fu-berlin.de!uni-berlin.de!individual.net!not-for-mail
From	Ian Collins <ian-news@hotmail.com>
Newsgroups	comp.lang.c++
Subject	Re: Oozing poison
Date	Wed, 11 Jan 2012 22:09:48 +1300
Lines	47
Message-ID	<9n51usFvfbU1@mid.individual.net> (permalink)
References	<ee928a54-720f-4beb-bdd3-2f1f112f0036@24g2000yqi.googlegroups.com> <R-qdnblKoaRhy5HSnZ2dnUVZ8rednZ2d@giganews.com> <2f356856-3e59-442f-b711-bde8e13d8beb@o14g2000vbo.googlegroups.com> <jejj5f$pi1$1@dont-email.me>
Mime-Version	1.0
Content-Type	text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding	7bit
X-Trace	individual.net MUD2lbjwvDKuVPgTe4+Pbw9ZKDdbkoasgg1qWPpc/vTjf/pJAP
Cancel-Lock	sha1:Uw61K0pfn6AXixhML+OvdWVQeBw=
User-Agent	Mozilla/5.0 (X11; SunOS i86pc; rv:6.0.2) Gecko/20111003 Thunderbird/6.0.2
In-Reply-To	<jejj5f$pi1$1@dont-email.me>
Xref	x330-a1.tempe.blueboxinc.net comp.lang.c++:13236

Show key headers only | View raw

On 01/11/12 10:01 PM, Alf P. Steinbach wrote:
> On 11.01.2012 09:43, AD wrote:
>> On Jan 10, 5:19 pm, Leigh Johnston<le...@i42.co.uk>   wrote:
>>> On 10/01/2012 12:35, AD wrote:
>>>
>>>> I kid you not, I found this trash in a real project:
>>>
>>>> //Remove texture from the the stack and try to unload from memory
>>>> void resourceManager::popTexture(const char* nickName)
>>>> {
>>>>      BOOL removed = false;
>>>>      for  (std::vector<texture*>::iterator itr = textures.begin(); itr !=
>>>> textures.end();)
>>>>      {
>>>>              if ( (*itr)->nickName == nickName )
>>>>              {
>>>
>>> If texture::nickName is a std::string I can see nothing wrong with this
>>> code snippet.
>>>
>>> Posting such partial code snippets which lack sufficient context are
>>> time wasting at best.
>>>
>>
>> that's exactly what the person who wrote that piece of code did.
>> made assumptions without verifying it wasting my time in the process.
>> now for the actual texture class definition:
>>
>> typedef struct texture
>> {
>> 	texture(TextureInfo *glTexture_, const char *nick) :
>> glTexture(glTexture_), nickName(nick)
>> 	{
>>
>> 	}
>> 	const char *nickName;
>> 	TextureInfo *glTexture;
>> }texture;
>
> The author of that code mixed up C and C++. The typedef only makes sense
> in C (but the code will not compile as C). The constructor only makes
> sense in C++ (but the typedef is meaningless in C++).

Using a type "BOOL" also hints at a confused author.

-- 
Ian Collins

Thread

Oozing poison AD <isquat@gmail.com> - 2012-01-10 04:35 -0800
  Re: Oozing poison Leigh Johnston <leigh@i42.co.uk> - 2012-01-10 15:19 +0000
    Re: Oozing poison AD <isquat@gmail.com> - 2012-01-11 00:43 -0800
      Re: Oozing poison "Alf P. Steinbach" <alf.p.steinbach+usenet@gmail.com> - 2012-01-11 10:01 +0100
        Re: Oozing poison Ian Collins <ian-news@hotmail.com> - 2012-01-11 22:09 +1300
          Re: Oozing poison AD <isquat@gmail.com> - 2012-01-11 01:42 -0800
            Re: Oozing poison Leigh Johnston <leigh@i42.co.uk> - 2012-01-11 13:36 +0000
              Re: Oozing poison John Bokma <john@castleamber.com> - 2012-01-11 10:08 -0600
              Re: Oozing poison AD <isquat@gmail.com> - 2012-01-12 06:08 -0800
                Re: Oozing poison Leigh Johnston <leigh@i42.co.uk> - 2012-01-12 14:13 +0000
                Re: Oozing poison AD <isquat@gmail.com> - 2012-01-17 02:08 -0800
                Re: Oozing poison Henrik Faber <hfaber@invalid.net> - 2012-01-17 12:50 +0100
                Re: Oozing poison Nick Keighley <nick_keighley_nospam@hotmail.com> - 2012-01-13 02:18 -0800
                Re: Oozing poison AD <isquat@gmail.com> - 2012-01-17 02:24 -0800
      Re: Oozing poison Jorgen Grahn <grahn+nntp@snipabacken.se> - 2012-01-11 16:50 +0000
        Re: Oozing poison AD <isquat@gmail.com> - 2012-01-12 06:04 -0800
          Re: Oozing poison Victor Bazarov <v.bazarov@comcast.invalid> - 2012-01-12 10:13 -0500
            Re: Oozing poison AD <isquat@gmail.com> - 2012-01-17 02:19 -0800
              Re: Oozing poison Victor Bazarov <v.bazarov@comcast.invalid> - 2012-01-17 08:04 -0500
              Re: Oozing poison Miles Bader <miles@gnu.org> - 2012-01-18 13:51 +0900
                Re: Oozing poison AD <isquat@gmail.com> - 2012-01-21 04:40 -0800
                Re: Oozing poison Quint Rankid <qbr567@gmail.com> - 2012-01-21 09:05 -0800
                Re: Oozing poison Wil Evers <bouncer@dev.null> - 2012-01-21 18:52 +0000
                Re: Oozing poison Quint Rankid <qbr567@gmail.com> - 2012-01-21 11:33 -0800
                Re: Oozing poison AD <isquat@gmail.com> - 2012-01-25 02:23 -0800
                Re: Oozing poison AD <isquat@gmail.com> - 2012-01-25 02:07 -0800
                Re: Oozing poison Victor Bazarov <v.bazarov@comcast.invalid> - 2012-01-25 07:59 -0500
                Re: Oozing poison Ian Collins <ian-news@hotmail.com> - 2012-01-26 07:54 +1300
                Re: Oozing poison Pavel <pauldontspamtolk@removeyourself.dontspam.yahoo> - 2012-01-21 22:43 -0500
                Re: Oozing poison Ian Collins <ian-news@hotmail.com> - 2012-01-22 21:05 +1300
                Re: Oozing poison Pavel <pauldontspamtolk@removeyourself.dontspam.yahoo> - 2012-01-22 18:21 -0500
                Re: Oozing poison Jorgen Grahn <grahn+nntp@snipabacken.se> - 2012-01-23 15:55 +0000
                Re: Oozing poison gwowen <gwowen@gmail.com> - 2012-01-23 08:37 -0800
                Re: Oozing poison Pavel <pauldontspamtolk@removeyourself.dontspam.yahoo> - 2012-01-24 22:48 -0500
                Re: Oozing poison Jorgen Grahn <grahn+nntp@snipabacken.se> - 2012-01-25 19:44 +0000
                Re: Oozing poison Ian Collins <ian-news@hotmail.com> - 2012-01-26 08:56 +1300
                Re: Oozing poison 88888 Dihedral <dihedral88888@googlemail.com> - 2012-01-25 23:04 -0800
                Re: Oozing poison Nick Keighley <nick_keighley_nospam@hotmail.com> - 2012-01-26 03:24 -0800
                Re: Oozing poison scott@slp53.sl.home (Scott Lurndal) - 2012-01-26 19:13 +0000
                Re: Oozing poison Brian Drummond <brian@shapes.demon.co.uk> - 2012-01-27 00:12 +0000
                Re: Oozing poison "MikeWhy" <boat042-nospam@yahoo.com> - 2012-01-26 22:44 -0600
                Re: Oozing poison 88888 Dihedral <dihedral88888@googlemail.com> - 2012-01-28 14:25 -0800
                Re: Oozing poison Robert Miles <milesrf@Usenet-News.net> - 2012-02-26 22:16 -0600
              Re: Oozing poison "Gernot Frisch" <me@privacy.net> - 2012-01-24 18:21 +0100
                Re: Oozing poison Victor Bazarov <v.bazarov@comcast.invalid> - 2012-01-24 12:41 -0500
                Re: Oozing poison Nick Keighley <nick_keighley_nospam@hotmail.com> - 2012-01-26 03:25 -0800
              Re: Oozing poison Rui Maciel <rui.maciel@gmail.com> - 2012-01-25 19:44 +0000
                Re: Oozing poison Jorgen Grahn <grahn+nntp@snipabacken.se> - 2012-01-26 09:44 +0000
                Re: Oozing poison Rui Maciel <rui.maciel@gmail.com> - 2012-01-26 10:36 +0000
                Re: Oozing poison scott@slp53.sl.home (Scott Lurndal) - 2012-01-26 19:18 +0000
                Re: Oozing poison Jorgen Grahn <grahn+nntp@snipabacken.se> - 2012-01-26 20:42 +0000
                Re: Oozing poison Juha Nieminen <nospam@thanks.invalid> - 2012-01-26 16:30 +0000
                Re: Oozing poison scott@slp53.sl.home (Scott Lurndal) - 2012-01-26 19:24 +0000
                Re: Oozing poison Cholo Lennon <chololennon@hotmail.com> - 2012-01-26 17:13 -0300
                Re: Oozing poison scott@slp53.sl.home (Scott Lurndal) - 2012-01-26 20:55 +0000
                Re: Oozing poison Jorgen Grahn <grahn+nntp@snipabacken.se> - 2012-01-26 22:08 +0000
                Re: Oozing poison scott@slp53.sl.home (Scott Lurndal) - 2012-01-27 00:32 +0000
                Re: Oozing poison Dombo <dombo@disposable.invalid> - 2012-01-28 12:59 +0100
                Re: Oozing poison Cholo Lennon <chololennon@hotmail.com> - 2012-01-27 18:28 -0300
                Re: Oozing poison Jorgen Grahn <grahn+nntp@snipabacken.se> - 2012-01-29 18:02 +0000
                Re: Oozing poison Ian Collins <ian-news@hotmail.com> - 2012-01-27 20:18 +1300
                Re: Oozing poison Miles Bader <miles@gnu.org> - 2012-01-27 18:09 +0900
                Re: Oozing poison scott@slp53.sl.home (Scott Lurndal) - 2012-01-27 20:29 +0000
                Re: Oozing poison Ian Collins <ian-news@hotmail.com> - 2012-01-28 10:06 +1300
                Re: Oozing poison scott@slp53.sl.home (Scott Lurndal) - 2012-01-27 21:26 +0000
                Re: Oozing poison Ian Collins <ian-news@hotmail.com> - 2012-01-28 12:22 +1300
                Re: Oozing poison scott@slp53.sl.home (Scott Lurndal) - 2012-01-28 04:18 +0000
                Re: Oozing poison Miles Bader <miles@gnu.org> - 2012-01-28 13:44 +0900
                Re: Oozing poison scott@slp53.sl.home (Scott Lurndal) - 2012-01-28 21:31 +0000
                Re: Oozing poison Ian Collins <ian-news@hotmail.com> - 2012-01-29 11:32 +1300
                Re: Oozing poison 88888 Dihedral <dihedral88888@googlemail.com> - 2012-01-28 14:55 -0800
                Re: Oozing poison Ian Collins <ian-news@hotmail.com> - 2012-01-29 11:59 +1300
                Re: Oozing poison scott@slp53.sl.home (Scott Lurndal) - 2012-01-30 17:08 +0000
                Re: Oozing poison Ian Collins <ian-news@hotmail.com> - 2012-01-28 18:06 +1300
                Re: Oozing poison scott@slp53.sl.home (Scott Lurndal) - 2012-01-28 22:49 +0000
                Re: Oozing poison Ian Collins <ian-news@hotmail.com> - 2012-01-29 12:22 +1300
                Re: Oozing poison scott@slp53.sl.home (Scott Lurndal) - 2012-01-27 20:16 +0000
                Re: Oozing poison Ian Collins <ian-news@hotmail.com> - 2012-01-28 10:01 +1300
                Re: Oozing poison Juha Nieminen <nospam@thanks.invalid> - 2012-01-28 16:00 +0000
  Re: Oozing poison Jorgen Grahn <grahn+nntp@snipabacken.se> - 2012-01-10 21:42 +0000
    Re: Oozing poison AD <isquat@gmail.com> - 2012-01-17 02:31 -0800

csiph-web