Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #17360 > unrolled thread

review for audio-visualizer-python/2.1.2-1

Back to article view | Back to linux.debian.maint.python

Contents

  review for audio-visualizer-python/2.1.2-1 Jeroen Ploemen <jcfp@debian.org> - 2026-01-15 19:40 +0100
    Re: review for audio-visualizer-python/2.1.2-1 Jeroen Ploemen <jcfp@debian.org> - 2026-01-16 11:50 +0100

#17360 — review for audio-visualizer-python/2.1.2-1

[Multipart message — attachments visible in raw view] — view raw

hi Aeliton,

I took a look at the audio-visualizer-python package, up for
sponsorship in the Python team. Don't worry about the volume of
comments, all of it is quite easy to fix.

* repo: pristine-tar branch is missing. Forgot to 'gbp push'?
* repo: please don't tag a Debian revision without an upload; for
  sponsored uploads within the team, the sponsor will typically take
  care of this.
* repo: but do enable the CI on salsa. It's a powerful quality
  control tool for yourself and sponsors alike. You always want to
  inspect results for key parts (build, lintian, autopkgtest), even
  if those checks passed.

* changelog: a new package should only have a single revision,
  closing an ITP bug (and no other entries). For subsequent updates,
  there should be a single new revision documenting every change to
  the packaging directory.

* control: no human maintainer, which is required by Debian policy;
  you want to add yourself as an uploader.
* control: outdated standards-version; redundant Rules-Requires-Root
  and Priority fields once you update that to 4.7.3.
* control: VCS links commented out (and pointing to a non-team repo).
* control: architecture set to "any" for what appears to be a
  pure-Python, architecture-independent util. Did you mean "all"?
* control: no ffmpeg dependency on the binary pkg?

* lintian: I: audio-visualizer-python: synopsis-is-a-sentence. An
  effective way to come up with a short description is to complete
  the following:>> Package-name is a <this part is your short
  description>.

* copyright: please format the MIT license text into the customary
  paragraphs.
* copyright: careful with setting a different, more restrictive
  license on debian/*: this may make forwarding patches difficult or
  impossible. Recommended practice is to match the upstream license.

* tests: package is missing a non-trivial autopkgtest, even though it
  would be easy to add via the Testsuite field in d/control.


Then for the package's design: audio-visualizer-python is an
application written in Python that internally takes the shape of a
(private) module [1], but it installs into /usr/lib/python3/ as a
public module [2]. Unless the avp module is actually intended to be
imported by other scripts, it should be installed as a private module.
Pybuild accepts arguments via d/rules that tell it where to install
libraries and scripts, examples in the team repo or via [3].


[1]https://www.debian.org/doc/packaging-manuals/python-policy/#programs-shipping-private-modules
[2]https://www.debian.org/doc/packaging-manuals/python-policy/#types-of-python-modules
[3]https://codesearch.debian.net/search?q=path%3Adebian%2Frules+PYBUILD_INSTALL_ARGS.*--install-lib.*--install-scripts&literal=0


Once the above comments have been addressed, simply re-add the
package to the IRC channel topic and/or ping me by e-mail.

[toc] | [next] | [standalone]

#17363

[Multipart message — attachments visible in raw view] — view raw

On Fri, 16 Jan 2026 01:15:41 -0300
"Aeliton G. Silva" <aeliton@aeliton.com> wrote:

> I managed to include a autopkgtest that generates a video from
> tests/data/test.ogg and checks if the output is a video/mp4 using
> file.

To ensure the content of the extracted source package isn't somehow
still used in an unforseen way, you probably want to copy the input
.ogg over and change directory to $AUTOPKGTEST_TMP before running the
avp command. The goal of an autopkgtest is to test the installed
*.deb, not the sources.

Why does the autopkgtest need a dependency on python3-qtpy-pyqt6?

> So the last problem still standing is now to make avp be [installed]
> as a program.

Maybe the PYBUILD_INSTALL_ARGS only works with an actual setup.py, but
not with pyproject.toml? All I found was another maintainer with the
same problem, suggesting this could be a bug/limitation of pybuild
(see [1] for their comments and workaround). Please ask on the Python
Team IRC channel how to pull this off with PEP517/pyproject.toml,
maybe someone there knows a less hacky way.

Then there's build failure on i386, see CI results on salsa. Could be
the failing test is just taking longer on that arch than on amd64 and
gets cut off after 10 seconds? Note the "[libx264 @ 0x56bf84c0] using
cpu capabilities: none!" in the build log; the lack of hardware
acceleration could have a significant impact. Try patching the test to
make the timeout at least an order of magnitude longer.

And lastly a few minor lintian hits, "P: audio-visualizer-python
source: trailing-whitespace" about d/control that need to go as well.


[1]https://sources.debian.org/src/comitup/1.43-1/debian/rules?hl=29#L29-L43

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.maint.python

csiph-web