Path: csiph.com!news.samoylyk.net!gothmog.csi.it!bofh.it!news.nic.it!robomod From: Jeroen Ploemen Newsgroups: linux.debian.maint.python Subject: review for audio-visualizer-python/2.1.2-1 Date: Thu, 15 Jan 2026 19:40:01 +0100 Message-ID: X-Mailbox-Line: From debian-python-request@lists.debian.org Thu Jan 15 18:36:43 2026 Old-Return-Path: X-Amavis-Spam-Status: No, score=-114.51 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_MED=-2.3, UNPARSEABLE_RELAY=0.001, USER_IN_DKIM_WELCOMELIST=-0.01, USER_IN_DKIM_WHITELIST=-100] autolearn=ham autolearn_force=no X-Mailer: Claws Mail 4.3.1 (GTK 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/I=z3R8R80y/5oLNwC5O+14s"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Debian-User: jcfp X-Mailing-List: archive/latest/23611 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/20260115183622.71b8fdb9@debian.org Approved: robomod@news.nic.it Lines: 90 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: debian-python@lists.debian.org X-Original-Date: Thu, 15 Jan 2026 18:36:22 -0000 X-Original-Message-ID: <20260115183622.71b8fdb9@debian.org> Xref: csiph.com linux.debian.maint.python:17360 --Sig_/I=z3R8R80y/5oLNwC5O+14s Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable hi Aeliton, I took a look at the audio-visualizer-python package, up for sponsorship in the Python team. Don't worry about the volume of comments, all of it is quite easy to fix. * repo: pristine-tar branch is missing. Forgot to 'gbp push'? * repo: please don't tag a Debian revision without an upload; for sponsored uploads within the team, the sponsor will typically take care of this. * repo: but do enable the CI on salsa. It's a powerful quality control tool for yourself and sponsors alike. You always want to inspect results for key parts (build, lintian, autopkgtest), even if those checks passed. * changelog: a new package should only have a single revision, closing an ITP bug (and no other entries). For subsequent updates, there should be a single new revision documenting every change to the packaging directory. * control: no human maintainer, which is required by Debian policy; you want to add yourself as an uploader. * control: outdated standards-version; redundant Rules-Requires-Root and Priority fields once you update that to 4.7.3. * control: VCS links commented out (and pointing to a non-team repo). * control: architecture set to "any" for what appears to be a pure-Python, architecture-independent util. Did you mean "all"? * control: no ffmpeg dependency on the binary pkg? * lintian: I: audio-visualizer-python: synopsis-is-a-sentence. An effective way to come up with a short description is to complete the following:>> Package-name is a . * copyright: please format the MIT license text into the customary paragraphs. * copyright: careful with setting a different, more restrictive license on debian/*: this may make forwarding patches difficult or impossible. Recommended practice is to match the upstream license. * tests: package is missing a non-trivial autopkgtest, even though it would be easy to add via the Testsuite field in d/control. Then for the package's design: audio-visualizer-python is an application written in Python that internally takes the shape of a (private) module [1], but it installs into /usr/lib/python3/ as a public module [2]. Unless the avp module is actually intended to be imported by other scripts, it should be installed as a private module. Pybuild accepts arguments via d/rules that tell it where to install libraries and scripts, examples in the team repo or via [3]. [1]https://www.debian.org/doc/packaging-manuals/python-policy/#programs-shi= pping-private-modules [2]https://www.debian.org/doc/packaging-manuals/python-policy/#types-of-pyt= hon-modules [3]https://codesearch.debian.net/search?q=3Dpath%3Adebian%2Frules+PYBUILD_I= NSTALL_ARGS.*--install-lib.*--install-scripts&literal=3D0 Once the above comments have been addressed, simply re-add the package to the IRC channel topic and/or ping me by e-mail. --Sig_/I=z3R8R80y/5oLNwC5O+14s Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEd8lhnEnWos3N8v+qQoMEoXSNzHoFAmlpM6cACgkQQoMEoXSN zHonLg//SKVLS8APhfqob7LwoIVd83IotcCKVUu1upyujBW6NVIqQh2eSdZr7sW0 yCZddOXWczu/oOXesxqhppLttKfmsOFsL9i/cUMowhzCX+v75QBAHpEjTddDLRL0 wnc/B0Z4T5fJC4t+bQrwm7f9+GKvT9ZF2wIGBsRn1t41fbFDh/MXr54Gxl7CollU RGKg86SLsT7DKu6fPqYqznuM4kbBXNutIOvWA9dcUhIcII6sJpGH7V5t4Lv53knm hO198OYqjsHz6X8YSSYIw/jPfypi4lYoh8UsgPtpzOUKcTYiPnkrYzwf1n8mlmbg wzn38TO2GXGh5VAkQLoHrRbGrK94wI7TPrRqqlciJe6Bboy+xbJcbgkNRzM+w9WY MNVd9qlurfXPvMZpj5FcU5dedXdXMBAB9RE9pTPdF5NuIq3a2BJeQ72kR0oz0qth sGSr7p5sbNbs7/R1H2Y9TO0nkuvuG42at9oUZtKr0URl6wgIIb2vGWtt8z4UEGkj XMhwhUfcPUXUg8rY4hz0DzmRXoO8GZEuEIyyEKJStu3NtWwc6rzWawpv4fGFa/DS SnAzmW9jGCmqtG/Izc+viKvRlIY2RbrfYjYlJjugmBlXwSAc1VtgQ39atNTjlTY8 zHJSOSH9a5SOkaP4OvYIrOziPXlnHPJkh0JcKAlcx1M6RnEovv0= =dumO -----END PGP SIGNATURE----- --Sig_/I=z3R8R80y/5oLNwC5O+14s--