Path: csiph.com!weretis.net!feeder8.news.weretis.net!news.samoylyk.net!gothmog.csi.it!bofh.it!news.nic.it!robomod From: Jeroen Ploemen Newsgroups: linux.debian.maint.python Subject: Re: review for audio-visualizer-python/2.1.2-1 Date: Fri, 16 Jan 2026 11:50:01 +0100 Message-ID: References: X-Mailbox-Line: From debian-python-request@lists.debian.org Fri Jan 16 10:49:23 2026 Old-Return-Path: X-Amavis-Spam-Status: No, score=-114.51 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_MED=-2.3, UNPARSEABLE_RELAY=0.001, USER_IN_DKIM_WELCOMELIST=-0.01, USER_IN_DKIM_WHITELIST=-100] autolearn=ham autolearn_force=no X-Mailer: Claws Mail 4.3.1 (GTK 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/+4kSnaod=9nWFFbw/Wa4JYJ"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Debian-User: jcfp X-Mailing-List: archive/latest/23616 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/20260116104837.6ddd48e9@debian.org Approved: robomod@news.nic.it Lines: 65 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: debian-python@lists.debian.org X-Original-Date: Fri, 16 Jan 2026 10:48:37 -0000 X-Original-Message-ID: <20260116104837.6ddd48e9@debian.org> X-Original-References: <20260115183622.71b8fdb9@debian.org> <580e9e5ce7df3cf658f038e212697738abb98e01.camel@aeliton.com> <31dda47048014b564c6b1915b237f51f9ab12a25.camel@aeliton.com> Xref: csiph.com linux.debian.maint.python:17363 --Sig_/+4kSnaod=9nWFFbw/Wa4JYJ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 16 Jan 2026 01:15:41 -0300 "Aeliton G. Silva" wrote: > I managed to include a autopkgtest that generates a video from > tests/data/test.ogg and checks if the output is a video/mp4 using > file. To ensure the content of the extracted source package isn't somehow still used in an unforseen way, you probably want to copy the input .ogg over and change directory to $AUTOPKGTEST_TMP before running the avp command. The goal of an autopkgtest is to test the installed *.deb, not the sources. Why does the autopkgtest need a dependency on python3-qtpy-pyqt6? > So the last problem still standing is now to make avp be [installed] > as a program. Maybe the PYBUILD_INSTALL_ARGS only works with an actual setup.py, but not with pyproject.toml? All I found was another maintainer with the same problem, suggesting this could be a bug/limitation of pybuild (see [1] for their comments and workaround). Please ask on the Python Team IRC channel how to pull this off with PEP517/pyproject.toml, maybe someone there knows a less hacky way. Then there's build failure on i386, see CI results on salsa. Could be the failing test is just taking longer on that arch than on amd64 and gets cut off after 10 seconds? Note the "[libx264 @ 0x56bf84c0] using cpu capabilities: none!" in the build log; the lack of hardware acceleration could have a significant impact. Try patching the test to make the timeout at least an order of magnitude longer. And lastly a few minor lintian hits, "P: audio-visualizer-python source: trailing-whitespace" about d/control that need to go as well. [1]https://sources.debian.org/src/comitup/1.43-1/debian/rules?hl=3D29#L29-L= 43 --Sig_/+4kSnaod=9nWFFbw/Wa4JYJ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEd8lhnEnWos3N8v+qQoMEoXSNzHoFAmlqF4UACgkQQoMEoXSN zHrxbRAApK/JK8KdIRyajPG7iEvcIyQgguPflFmYZbPccg43X3lZDjlIIyO+eAm4 9Yig5Prh2GkKyXhPMvbvIDg0WdEbWKfKn/mhrj7quFAX08VkR/tzzYhImiK3KSDv hZqhL5QTAIPxw/AtHr3pqjPpCFd4uhfrllyZGCcQVXlFn0TbVPZbwB0wjYZ1saAJ Nqm9pkHZjnAc35s10PS0A1HthoeQ6kX2zxXqJmVeIyKyDnxMgo/9rtoIZOUd36cH S8f8hvdpW8UGWNV0pUxoNRkdKnjaW2BEd1w1TNrsM585OWCejSBG1Guc9mJYouuS V0+L4ESv5x9iYxt9TX8TzxLzfwOAyAfSsxqgLnkWJAOvTbSanVrHHRsy+bmPV8wq p5LcuCvIuPV+mlRBfBh0wKwJXIX7QyGULejVE1BlFtvXWdO2rrL7nvr8vzTuGPPG WH1ZyhOZjEdAHcxxJEnm/iZSPjVXcZs/xBsxI5t4QmeAT5HfZUJ2aaK2xeHoQe+t llWHKmTER16UmmL2ckdbYP2ssOZKEkKbU1Py+l0SRRNfEES+ywGjAhPGdEI/I/Ua 2bjpyqJAFL+Agspu0pJGz2DN5x9Y78bSy8yx7WaO89RZTbRcWWAXw7QOQ6ycLJdd e9g3s6bgfSe43PXV6XZEAG2sOYbOLj0Q3E+yo8TrF2ZRiTMX9Uk= =yfeD -----END PGP SIGNATURE----- --Sig_/+4kSnaod=9nWFFbw/Wa4JYJ--