Groups > linux.debian.maint.python > #8539

Re: python-social-auth 0.2.19-1 review

Path	csiph.com!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Michael Fladischer <michael@fladi.at>
Newsgroups	linux.debian.maint.python
Subject	Re: python-social-auth 0.2.19-1 review
Date	Thu, 19 May 2016 13:50:02 +0200
Message-ID	<rAuCK-7Be-21@gated-at.bofh.it> (permalink)
References	<rAuCK-7Be-23@gated-at.bofh.it> <rzFTz-qJ-3@gated-at.bofh.it>
X-Mailbox-Line	From debian-python-request@lists.debian.org Thu May 19 11:42:35 2016
Old-Return-Path	<michael@fladi.at>
X-Amavis-Spam-Status	No, score=-13.096 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RP_MATCHES_RCVD=-0.996] autolearn=ham autolearn_force=no
X-Policyd-Weight	using cached result; rate: -6.1
Dkim-Signature	v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=@; s=rsa1; h=Mime-Version:Content-Type:References:In-Reply-To:Date:To:From:Subject: Message-ID:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=mhTpUMDX1xvtBEte6t4/IxnbDSVHdsGb0s1FQRXfiaA=; b=qVSB2YZZrYuKYnewIJ48D1uZ2Q h0oCZc28VcY9dRAfOZD4WpEMThE6P8yBWb+2ISqszPS9yen8B9fp2KLsNwRGPtmItZembggGixVPw SbQBVjJGs4nT2mbV69AdfXQsY;
Dkim-Signature	v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=localhost; s=rsa1; h=Mime-Version:Content-Type:References:In-Reply-To:Date:To:From: Subject:Message-ID:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=mhTpUMDX1xvtBEte6t4/IxnbDSVHdsGb0s1FQRXfiaA=; b=e0JOTrGjqGPJgVMvaWVnd1m2zo WTVfNRq2be3lDNXLPB853kBavFTp3QSbyR0EE+g9YrfxXVVGqYr6RDWR4Ssiwtj3jRHVWpyVbysma c/gh/eDbP9u0cru83BeAr7OJO;
Dkim-Signature	v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fladi.at; s=rsa1; h=Mime-Version:Content-Type:References:In-Reply-To:Date:To:From: Subject:Message-ID:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=mhTpUMDX1xvtBEte6t4/IxnbDSVHdsGb0s1FQRXfiaA=; b=WBDicRDaOcJVEItXcbM98APN6+ lESfLV+cbbrWLP1uNs2hz3jE/0U1e+SRyaHt9KV0hGGFxBNXj+DfIknnkzregdC8ikDSeKutAyGVU U85XGsV/NR+0AICkKW8UQc3wj;
Dkim-Signature	v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=openservices.at; s=rsa1; h=Mime-Version:Content-Type:References:In-Reply-To :Date:To:From:Subject:Message-ID:Sender:Reply-To:Cc:Content-Transfer-Encoding :Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=mhTpUMDX1xvtBEte6t4/IxnbDSVHdsGb0s1FQRXfiaA=; b=qVcgyDRfEZmC+buWsiK45OGcXs Rt22n4mzKwWdgzrj1mR14fYl3Mt/qH9dFaNzd4IlnGizzcvsZI1MoIhGCP9OZSyShc0uTpxzdCkwk +Q7+lhP9pCDKZKaVMToF5RHRd;
Dkim-Signature	v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qraz.at; s=rsa1; h=Mime-Version:Content-Type:References:In-Reply-To:Date:To:From: Subject:Message-ID:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=mhTpUMDX1xvtBEte6t4/IxnbDSVHdsGb0s1FQRXfiaA=; b=hjzGd9dlwCwnO1kFpQgqYyx4E6 33lG2NPb74IVUXYSIZOuSea2QwpcST3zpk/sU3W0F+oZM2MM5boc7umwoneTAiN7gkZjCj5QAwp2m HRK5RbzYKOzoFHKzjlSe/0onV;
Dkim-Signature	v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=firedata.at ; s=rsa1; h=Mime-Version:Content-Type:References:In-Reply-To:Date:To:From: Subject:Message-ID:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=mhTpUMDX1xvtBEte6t4/IxnbDSVHdsGb0s1FQRXfiaA=; b=m/rCbb6QIAjXGATKV7GtdTH/XK qjDkx2GyAasuZ1VTHprRng4zwM0qubkoMYg5aDH5HryYzhkZdMtos5AEhCzsIyx5VBWzm/R4ebszY YImeY7wh+5+NZdGgyxU0Td7xQ;
Organization	Fladi.at
Content-Type	multipart/signed; micalg="sha-512"; protocol="application/x-pkcs7-signature"; boundary="=-N4zw0OQnu6udwOZEFHH4"
X-Mailer	Evolution 3.18.5.1-1+b1
MIME-Version	1.0
X-Mailing-List	<debian-python@lists.debian.org> archive/latest/13869
List-ID	<debian-python.lists.debian.org>
List-URL	<https://lists.debian.org/debian-python/>
List-Archive	https://lists.debian.org/msgid-search/1463658117.14890.8.camel@fladi.at
Approved	robomod@news.nic.it
Lines	130
Sender	robomod@news.nic.it
X-Original-Date	Thu, 19 May 2016 13:41:57 +0200
X-Original-Message-ID	<1463658117.14890.8.camel@fladi.at>
X-Original-References	<CALdTKe_=E9B7mWy5dYohJ+M3xpgO7zh3PeqvdKRzzhApJ8-oAQ@mail.gmail.com>
Xref	csiph.com linux.debian.maint.python:8539

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Tiago,

On Tue, 2016-05-17 at 02:14 -0300, Tiago Ilieve wrote:
> In my first task as a member of the Debian Python Modules Team, I've
> prepared an upload of "python-social-auth"[1]. It was updated to a
> newer upstream release (0.2.13 to 0.2.19) and some fixes were also
> done.
> 
> Is there anyone here able to review/sponsor those changes?

my quick review after building it:

- lintian complains about site/js/bootstrap.min.js, AFAIKT the "site"
folder  contains the project's website. Maybe you would like to remove
it by repacking the source tarball.
- You could shorten "python-all (>= 2.7~)" from Build-Depends to
"python-all".
- It's more accurate to use "Expat" instead of "MIT" in d/copyright.
- Both binary packages ship the documentation. While it's only a few KB
it would be an option to move the documentation to a separate binary
package.

Cheers and thanks for your work!
-- 
Michael Fladischer
Fladi.at

Thread

python-social-auth 0.2.19-1 review Tiago Ilieve <tiago.myhro@gmail.com> - 2016-05-17 07:40 +0200
  Re: python-social-auth 0.2.19-1 review Michael Fladischer <michael@fladi.at> - 2016-05-19 13:50 +0200
    Re: python-social-auth 0.2.19-1 review Tiago Ilieve <tiago.myhro@gmail.com> - 2016-05-19 18:40 +0200
      Re: python-social-auth 0.2.19-1 review Dmitry Shachnev <mitya57@debian.org> - 2016-05-21 10:50 +0200
        Re: python-social-auth 0.2.19-1 review Tiago Ilieve <tiago.myhro@gmail.com> - 2016-05-24 12:30 +0200
          Re: python-social-auth 0.2.19-1 review Tiago Ilieve <tiago.myhro@gmail.com> - 2016-05-30 08:20 +0200
            Re: python-social-auth 0.2.19-1 review Dmitry Shachnev <mitya57@debian.org> - 2016-06-01 13:50 +0200
              Re: python-social-auth 0.2.19-1 review Tiago Ilieve <tiago.myhro@gmail.com> - 2016-06-08 22:40 +0200

csiph-web