Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #8539

Re: python-social-auth 0.2.19-1 review

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Tiago,

On Tue, 2016-05-17 at 02:14 -0300, Tiago Ilieve wrote:
> In my first task as a member of the Debian Python Modules Team, I've
> prepared an upload of "python-social-auth"[1]. It was updated to a
> newer upstream release (0.2.13 to 0.2.19) and some fixes were also
> done.
> 
> Is there anyone here able to review/sponsor those changes?

my quick review after building it:

- lintian complains about site/js/bootstrap.min.js, AFAIKT the "site"
folder  contains the project's website. Maybe you would like to remove
it by repacking the source tarball.
- You could shorten "python-all (>= 2.7~)" from Build-Depends to
"python-all".
- It's more accurate to use "Expat" instead of "MIT" in d/copyright.
- Both binary packages ship the documentation. While it's only a few KB
it would be an option to move the documentation to a separate binary
package.

Cheers and thanks for your work!
-- 
Michael Fladischer
Fladi.at

Back to linux.debian.maint.python | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

python-social-auth 0.2.19-1 review Tiago Ilieve <tiago.myhro@gmail.com> - 2016-05-17 07:40 +0200
  Re: python-social-auth 0.2.19-1 review Michael Fladischer <michael@fladi.at> - 2016-05-19 13:50 +0200
    Re: python-social-auth 0.2.19-1 review Tiago Ilieve <tiago.myhro@gmail.com> - 2016-05-19 18:40 +0200
      Re: python-social-auth 0.2.19-1 review Dmitry Shachnev <mitya57@debian.org> - 2016-05-21 10:50 +0200
        Re: python-social-auth 0.2.19-1 review Tiago Ilieve <tiago.myhro@gmail.com> - 2016-05-24 12:30 +0200
          Re: python-social-auth 0.2.19-1 review Tiago Ilieve <tiago.myhro@gmail.com> - 2016-05-30 08:20 +0200
            Re: python-social-auth 0.2.19-1 review Dmitry Shachnev <mitya57@debian.org> - 2016-06-01 13:50 +0200
              Re: python-social-auth 0.2.19-1 review Tiago Ilieve <tiago.myhro@gmail.com> - 2016-06-08 22:40 +0200

csiph-web