Path: csiph.com!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From: Michael Fladischer <michael@fladi.at>
Newsgroups: linux.debian.maint.python
Subject: Re: python-social-auth 0.2.19-1 review
Date: Thu, 19 May 2016 13:50:02 +0200
Message-ID: <rAuCK-7Be-21@gated-at.bofh.it>
References: <rAuCK-7Be-23@gated-at.bofh.it> <rzFTz-qJ-3@gated-at.bofh.it>
Old-Return-Path: <michael@fladi.at>
Organization: Fladi.at
Content-Type: multipart/signed; micalg="sha-512"; protocol="application/x-pkcs7-signature"; boundary="=-N4zw0OQnu6udwOZEFHH4"
MIME-Version: 1.0
Approved: robomod@news.nic.it
Lines: 130
Sender: robomod@news.nic.it
Xref: csiph.com linux.debian.maint.python:8539


--=-N4zw0OQnu6udwOZEFHH4
Content-Type: multipart/signed; micalg="pgp-sha512";
	protocol="application/pgp-signature"; boundary="=-QMLq6nIFitW1LRz+jNhR"


--=-QMLq6nIFitW1LRz+jNhR
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Tiago,

On Tue, 2016-05-17 at 02:14 -0300, Tiago Ilieve wrote:
> In my first task as a member of the Debian Python Modules Team, I've
> prepared an upload of "python-social-auth"[1]. It was updated to a
> newer upstream release (0.2.13 to 0.2.19) and some fixes were also
> done.
>=20
> Is there anyone here able to review/sponsor those changes?

my quick review after building it:

- lintian complains about=C2=A0site/js/bootstrap.min.js, AFAIKT the "site"
folder =C2=A0contains the project's website. Maybe you would like to remove
it by repacking the source tarball.
- You could shorten "python-all (>=3D 2.7~)" from Build-Depends to
"python-all".
- It's more accurate to use "Expat" instead of "MIT" in d/copyright.
- Both binary packages ship the documentation. While it's only a few KB
it would be an option to move the documentation to a separate binary
package.

Cheers and thanks for your work!
--=20
Michael Fladischer
Fladi.at

--=-QMLq6nIFitW1LRz+jNhR
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAABCgAGBQJXPaaGAAoJEP/TyIuZfdFq0ukH/0gra8MQIhKSG+6bRcDT2Xfq
iNcyn3DCSOzjsKBZgpEXmORlSUj9lyNxnv/eI8eS1rAb5TkzJR5RXd99tXHgn5ei
HzuograEgKt3l0ntaYUomkEUJ2znMQ8jK4LU09aTws1GO6zZBEPTBsGpC0nkDxOt
qiwUKzA8Y/i9FxHSwjP9TNNbCx/getZbOVF0uD93CQs1MSoSq6kxenAqgD6KLsON
a4jPEPLRaTNNmElwh61E2Rzd82a0GWv8bcukI9Bk8fNZKVI8egrJTKzM6uhErfHf
UIZd8vfnNU9wT5zF0gGSqef7MmPfZbo+SURppAstSHPdLPEF1eDguELY5r07yFg=
=p9Bu
-----END PGP SIGNATURE-----

--=-QMLq6nIFitW1LRz+jNhR--

--=-N4zw0OQnu6udwOZEFHH4
Content-Type: application/x-pkcs7-signature; name="smime.p7s"
Content-Disposition: attachment; filename="smime.p7s"
Content-Transfer-Encoding: base64

MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgMFADCABgkqhkiG9w0BBwEAAKCCDFow
ggYeMIIFBqADAgECAgMOe/8wDQYJKoZIhvcNAQEFBQAwgYwxCzAJBgNVBAYTAklMMRYwFAYDVQQK
Ew1TdGFydENvbSBMdGQuMSswKQYDVQQLEyJTZWN1cmUgRGlnaXRhbCBDZXJ0aWZpY2F0ZSBTaWdu
aW5nMTgwNgYDVQQDEy9TdGFydENvbSBDbGFzcyAxIFByaW1hcnkgSW50ZXJtZWRpYXRlIENsaWVu
dCBDQTAeFw0xNTA2MjMxMzE4MDFaFw0xNjA2MjQwMDIwNDRaMDwxGTAXBgNVBAMMEG1pY2hhZWxA
ZmxhZGkuYXQxHzAdBgkqhkiG9w0BCQEWEG1pY2hhZWxAZmxhZGkuYXQwggEiMA0GCSqGSIb3DQEB
AQUAA4IBDwAwggEKAoIBAQDXslQkFHrs6NLCkvarP9fSii/y8vCEtNK03o8nKDFKKu42LuWExw1/
wcX8OUuk9qL7mdKhkaiML+gMArxbl3XEW2X++14DB/pMYNM38sz/jGlm2NUchGXrO8iufiMtNbuE
Csvoh6aKdwjvIA+yzmPfHXZncPipse9/ts3gr/RhMlXR/ublaUp5Hb2CxJfdSFV0IwNCdXKss2fX
WtXPpj2PezEXgo27IXe+neWmxLy1EGWd1GNd9iJamSd3BaUwTP+CNlCdvD2HaX9ZeG3CHPl40hGm
XN3dB8FIUjkDLNXUuFLUH1VQOZnkGGzPZA5Z2Xzp/9phvHUZ34x5WP7jm12HAgMBAAGjggLWMIIC
0jAJBgNVHRMEAjAAMAsGA1UdDwQEAwIEsDAdBgNVHSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQw
HQYDVR0OBBYEFAi5I7HjnWPEePJLg2J13h28+vOlMB8GA1UdIwQYMBaAFFNy7ZKc4NrLAVx8fpY1
TvLUuFGCMBsGA1UdEQQUMBKBEG1pY2hhZWxAZmxhZGkuYXQwggFMBgNVHSAEggFDMIIBPzCCATsG
CysGAQQBgbU3AQIDMIIBKjAuBggrBgEFBQcCARYiaHR0cDovL3d3dy5zdGFydHNzbC5jb20vcG9s
aWN5LnBkZjCB9wYIKwYBBQUHAgIwgeowJxYgU3RhcnRDb20gQ2VydGlmaWNhdGlvbiBBdXRob3Jp
dHkwAwIBARqBvlRoaXMgY2VydGlmaWNhdGUgd2FzIGlzc3VlZCBhY2NvcmRpbmcgdG8gdGhlIENs
YXNzIDEgVmFsaWRhdGlvbiByZXF1aXJlbWVudHMgb2YgdGhlIFN0YXJ0Q29tIENBIHBvbGljeSwg
cmVsaWFuY2Ugb25seSBmb3IgdGhlIGludGVuZGVkIHB1cnBvc2UgaW4gY29tcGxpYW5jZSBvZiB0
aGUgcmVseWluZyBwYXJ0eSBvYmxpZ2F0aW9ucy4wNgYDVR0fBC8wLTAroCmgJ4YlaHR0cDovL2Ny
bC5zdGFydHNzbC5jb20vY3J0dTEtY3JsLmNybDCBjgYIKwYBBQUHAQEEgYEwfzA5BggrBgEFBQcw
AYYtaHR0cDovL29jc3Auc3RhcnRzc2wuY29tL3N1Yi9jbGFzczEvY2xpZW50L2NhMEIGCCsGAQUF
BzAChjZodHRwOi8vYWlhLnN0YXJ0c3NsLmNvbS9jZXJ0cy9zdWIuY2xhc3MxLmNsaWVudC5jYS5j
cnQwIwYDVR0SBBwwGoYYaHR0cDovL3d3dy5zdGFydHNzbC5jb20vMA0GCSqGSIb3DQEBBQUAA4IB
AQA1UyFhUq1Hg6ql9wWR/knidZdTUzGwvK67sVM8PwV/Gd0HEhU6j3imfj8N3PgLtTN1KYbmDFIV
QE2KunmU7FKkRxN+mx30fr7k6gq8gUIIsXNKAkAPB8yIwjXmg18yTW2MSHMjWubHqisFkeXtwQDW
gMv0MB+ypLyRd6988zg79SkkLFtVPVzjV/8t1V9SnDzrrmuQ9Q6o8TEvP3LHbAKuxG+j0vASwEzI
+3U3swXLtsGWUKRpIo4Xi8QPwdgekmBuuajXj59G8l+TAcw9vvxH2BYIOKx7p+JbJffBCKUKnqsD
PNORxGByq/8B5ceEFJnjkS+NJBoNTNPjKUke5ogwMIIGNDCCBBygAwIBAgIBHjANBgkqhkiG9w0B
AQUFADB9MQswCQYDVQQGEwJJTDEWMBQGA1UEChMNU3RhcnRDb20gTHRkLjErMCkGA1UECxMiU2Vj
dXJlIERpZ2l0YWwgQ2VydGlmaWNhdGUgU2lnbmluZzEpMCcGA1UEAxMgU3RhcnRDb20gQ2VydGlm
aWNhdGlvbiBBdXRob3JpdHkwHhcNMDcxMDI0MjEwMTU1WhcNMTcxMDI0MjEwMTU1WjCBjDELMAkG
A1UEBhMCSUwxFjAUBgNVBAoTDVN0YXJ0Q29tIEx0ZC4xKzApBgNVBAsTIlNlY3VyZSBEaWdpdGFs
IENlcnRpZmljYXRlIFNpZ25pbmcxODA2BgNVBAMTL1N0YXJ0Q29tIENsYXNzIDEgUHJpbWFyeSBJ
bnRlcm1lZGlhdGUgQ2xpZW50IENBMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAxwmD
zM4t2BqxKaQuE6uWvooyg4ymiEGWVUet1G8SD+rqvyNH4QrvnEIaFHxOhESip7vMz39ScLpNLbL1
QpOlPW/tFIzNHS3qd2XRNYG5Sv9RcGE+T4qbLtsjjJbi6sL7Ls/f/X9ftTyhxvxWkf8KW37iKrue
Ksxw2HqolH7GM6FX5UfNAwAu4ZifkpmZzU1slBhyWwaQPEPPZRsWoTb7q8hmgv6Nv3Hg9rmA1/VP
BIOQ6SKRkHXG0Hhmq1dOFoAFI411+a/9nWm5rcVjGcIWZ2v/43Yksq60jExipA4l5uv9/+Hm33mb
gmCszdj/Dthf13tgAv2O83hLJ0exTqfrlwIDAQABo4IBrTCCAakwDwYDVR0TAQH/BAUwAwEB/zAO
BgNVHQ8BAf8EBAMCAQYwHQYDVR0OBBYEFFNy7ZKc4NrLAVx8fpY1TvLUuFGCMB8GA1UdIwQYMBaA
FE4L7xqkQFulF2mHMMo0aEPQQa7yMGYGCCsGAQUFBwEBBFowWDAnBggrBgEFBQcwAYYbaHR0cDov
L29jc3Auc3RhcnRzc2wuY29tL2NhMC0GCCsGAQUFBzAChiFodHRwOi8vd3d3LnN0YXJ0c3NsLmNv
bS9zZnNjYS5jcnQwWwYDVR0fBFQwUjAnoCWgI4YhaHR0cDovL3d3dy5zdGFydHNzbC5jb20vc2Zz
Y2EuY3JsMCegJaAjhiFodHRwOi8vY3JsLnN0YXJ0c3NsLmNvbS9zZnNjYS5jcmwwgYAGA1UdIAR5
MHcwdQYLKwYBBAGBtTcBAgEwZjAuBggrBgEFBQcCARYiaHR0cDovL3d3dy5zdGFydHNzbC5jb20v
cG9saWN5LnBkZjA0BggrBgEFBQcCARYoaHR0cDovL3d3dy5zdGFydHNzbC5jb20vaW50ZXJtZWRp
YXRlLnBkZjANBgkqhkiG9w0BAQUFAAOCAgEACoMIfXirLAZcuGOMXq4cuSN3TaFx2H2GvD5VSy/6
rV55BYHbWNaPeQn3oBSU8KgQZn/Kck1JxbLpAxVCNtsxeW1R87ifhsYZ0qjdrA9anrW2MAWCtosm
AOT4OxK9QPoSjCMxM3HbkZCDJgnlE8jMopH21BbyAYr7b5EfGRQJNtgWcvqSXwKHnTutR08+Kkn0
KAkXCzeQNLeA5LlYUzFyM7kPAp8pIRMQ+seHunmyG642S2+y/qHEdMuGIwpfz3eDF1PdctL04qYK
/zu+Qg1Bw0RwgigVZs/0c5HP2/e9DBHh7eSwtzYlk4AUr6yxLlcwSjOfOmKEQ/Q8tzh0IFiNu9IP
uTGAPBn4CPxD0+Ru8T2wg8/s43R/PT3kd1OEqOJUl7q+h+r6fpvU0Fzxd2tC8Ga6fDEPme+1Nbi+
03pVjuZQKbGwKJ66gEn06WqaxVZC+J8hh/jR0k9mST1iAZPNYulcNJ8tKmVtjYsv0L1TSm2+NwON
58tO+pIVzu3DWwSEXSf+qkDavQam+QtEOZxLBXI++aMUEapSn+k3Lxm48ZCYfAWLb/Xj7F5JQMbZ
vCexglAbYR0kIHqW5DnsYSdMD/IplJMojx0NBrxJ3fN9dvX2Y6BIXRsF1du4qESm4/3CKuyUV7p9
DW3mPlHTGLvYxnyKQy7VFBkoLINszBrOUeIxggJMMIICSAIBATCBlDCBjDELMAkGA1UEBhMCSUwx
FjAUBgNVBAoTDVN0YXJ0Q29tIEx0ZC4xKzApBgNVBAsTIlNlY3VyZSBEaWdpdGFsIENlcnRpZmlj
YXRlIFNpZ25pbmcxODA2BgNVBAMTL1N0YXJ0Q29tIENsYXNzIDEgUHJpbWFyeSBJbnRlcm1lZGlh
dGUgQ2xpZW50IENBAgMOe/8wDQYJYIZIAWUDBAIDBQCggYkwGAYJKoZIhvcNAQkDMQsGCSqGSIb3
DQEHATAcBgkqhkiG9w0BCQUxDxcNMTYwNTE5MTE0MjAzWjBPBgkqhkiG9w0BCQQxQgRAXc8IJVvL
pqts5mnkydTF0NDVPqjmwbOsAyIufHoJXesWfD36GThk2X1wpgAKVjxxHvjoHSuF4jsNVcs93zNV
czANBgkqhkiG9w0BAQEFAASCAQA+fAvfv8BwGcJZea/F6joUedOtgghClPzmeBdwPJm2ZkYovRs1
AZCTLjDQswP5khIUwtNQrNG5F1yldDRtDg4HvWsG4MZIiyteKYPDlvjyoBKqggcmcExz3VMXzp+L
5fkrcwz4spzioDZFUBxVUMKg9K+UK1yYzQm/Gf02kWTtE+uNus0aT++hnJraJnLPBPDNubabk0Oz
SqLI1+WKwbgxNTVsH+jrr0VPK0ciQU+BGyCzIyZB1M+qYeCnv5z8+urFUgiuTvl3EcB/Bjjd6CG2
zyKBBsTbvy7mJt7SERB19Aa1hGVWjMQMFbd6FekRR4vZMrq0yy0BlsKn5Rlhm6wYAAAAAAAA


--=-N4zw0OQnu6udwOZEFHH4--