Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.debian.maint.python > #17135

Re: review for ocrfeeder/0.8.5-2

From Pieter Lenaerts <plenae@disroot.org>
Newsgroups linux.debian.maint.python
Subject Re: review for ocrfeeder/0.8.5-2
Date 2025-11-10 19:40 +0100
Message-ID <LPEY2-bYoC-1@gated-at.bofh.it> (permalink)
References <LOULv-bsjf-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Op 8/11/2025 om 18:13 schreef Jeroen Ploemen:
> I took a look at the ocrfeeder package, up for sponsorship in the
> Python team:
>
> * copyright: assorted missing entries, including:
I've used cme to update d/copyright. It's quite a lot of changes now.
> * control: unused dependency on python3-lxml?
> * control: old debhelper compat level 12 (current is 13).
Done.
> * patches: newly added 'remove_gnome_autogen.patch' looks redundant;
>    recent compat levels run autoreconf by default and the package
>    seems to build fine without it (the .deb is identical too). The
>    related override in d/rules can go as well.
Done
> * watch: regexp (\d\.\d) in the Source line is overly specific, could
>    easily miss realistic future versions such as 0.10; something like
>    '\d[\d.]*' avoids that problem while still limiting to digits and
>    dots only.

Done.

I also adressed bug #1085746 
<https://salsa.debian.org/python-team/packages/ocrfeeder/-/commit/3a322e10d9fe468b83b63c05d22f93789d81b48d>

Thanks for your time and pointers!

Pieter

Back to linux.debian.maint.python | Previous | NextPrevious in thread | Next in thread | Find similar


Thread

review for ocrfeeder/0.8.5-2 Jeroen Ploemen <jcfp@debian.org> - 2025-11-08 18:20 +0100
  Re: review for ocrfeeder/0.8.5-2 Pieter Lenaerts <plenae@disroot.org> - 2025-11-10 19:40 +0100
    Re: review for ocrfeeder/0.8.5-2 Jeroen Ploemen <jcfp@debian.org> - 2025-11-11 15:00 +0100
      Re: review for ocrfeeder/0.8.5-2 Pieter Lenaerts <plenae@disroot.org> - 2025-11-11 16:00 +0100
        Re: review for ocrfeeder/0.8.5-2 Jeroen Ploemen <jcfp@debian.org> - 2025-11-11 17:20 +0100

csiph-web