Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #17128

review for ocrfeeder/0.8.5-2

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

hi Pieter,

I took a look at the ocrfeeder package, up for sponsorship in the
Python team:

* copyright: assorted missing entries, including:
  m4/m4_ax_python_module.m4:17:#   Copyright (c) 2008 Andrew Collier <colliera@ukzn.ac.za>
  m4/intltool.m4:2:## Copyright (C) 2001 Eazel, Inc.
  po/bs.po:2:# Copyright (c) 2013 Rosetta Contributors and Canonical Ltd 2013
  po/Makefile.in.in:2:# Copyright (C) 1995, 1996, 1997 by Ulrich Drepper <drepper@gnu.ai.mit.edu>
  po/Makefile.in.in:3:# Copyright (C) 2004-2008 Rodney Dawes <dobey.pwns@gmail.com>
  help/*/legal.xml:[...] Creative Commons Attribution-Share Alike 3.0 United States
  resources/icons/detect_icon.svg:347:           rdf:resource="http://creativecommons.org/licenses/GPL/2.0/" />
  resources/icons/detect_icon.svg:356:         rdf:about="http://creativecommons.org/licenses/GPL/2.0/">

* control: unused dependency on python3-lxml?
* control: old debhelper compat level 12 (current is 13).

* patches: newly added 'remove_gnome_autogen.patch' looks redundant;
  recent compat levels run autoreconf by default and the package
  seems to build fine without it (the .deb is identical too). The
  related override in d/rules can go as well.

* watch: regexp (\d\.\d) in the Source line is overly specific, could
  easily miss realistic future versions such as 0.10; something like
  '\d[\d.]*' avoids that problem while still limiting to digits and
  dots only.


Once the above comments have been addressed, simply re-add the
package to the IRC channel topic and/or ping me by e-mail.

Back to linux.debian.maint.python | Previous | Next — Next in thread | Find similar

Thread

review for ocrfeeder/0.8.5-2 Jeroen Ploemen <jcfp@debian.org> - 2025-11-08 18:20 +0100
  Re: review for ocrfeeder/0.8.5-2 Pieter Lenaerts <plenae@disroot.org> - 2025-11-10 19:40 +0100
    Re: review for ocrfeeder/0.8.5-2 Jeroen Ploemen <jcfp@debian.org> - 2025-11-11 15:00 +0100
      Re: review for ocrfeeder/0.8.5-2 Pieter Lenaerts <plenae@disroot.org> - 2025-11-11 16:00 +0100
        Re: review for ocrfeeder/0.8.5-2 Jeroen Ploemen <jcfp@debian.org> - 2025-11-11 17:20 +0100

csiph-web