Path: csiph.com!pasdenom.info!weretis.net!feeder8.news.weretis.net!news.samoylyk.net!gothmog.csi.it!bofh.it!news.nic.it!robomod From: Pieter Lenaerts Newsgroups: linux.debian.maint.python Subject: Re: review for ocrfeeder/0.8.5-2 Date: Mon, 10 Nov 2025 19:40:02 +0100 Message-ID: References: X-Original-To: Jeroen Ploemen X-Mailbox-Line: From debian-python-request@lists.debian.org Mon Nov 10 18:39:11 2025 Old-Return-Path: X-Amavis-Spam-Status: No, score=-8.196 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, LDO_WHITELIST=-5, MD5_SHA1_SUM=-1, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001] autolearn=ham autolearn_force=no X-Policyd-Weight: using cached result; rate: -4.6 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: nl-BE Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailing-List: archive/latest/23336 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/6551d469-28de-44fc-8299-ca9aed2df522@disroot.org Approved: robomod@news.nic.it Lines: 27 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: debian-python@lists.debian.org X-Original-Date: Mon, 10 Nov 2025 19:23:10 +0100 X-Original-Message-ID: <6551d469-28de-44fc-8299-ca9aed2df522@disroot.org> X-Original-References: <20251108171317.0c5ee96e@debian.org> Xref: csiph.com linux.debian.maint.python:17135 Op 8/11/2025 om 18:13 schreef Jeroen Ploemen: > I took a look at the ocrfeeder package, up for sponsorship in the > Python team: > > * copyright: assorted missing entries, including: I've used cme to update d/copyright. It's quite a lot of changes now. > * control: unused dependency on python3-lxml? > * control: old debhelper compat level 12 (current is 13). Done. > * patches: newly added 'remove_gnome_autogen.patch' looks redundant; > recent compat levels run autoreconf by default and the package > seems to build fine without it (the .deb is identical too). The > related override in d/rules can go as well. Done > * watch: regexp (\d\.\d) in the Source line is overly specific, could > easily miss realistic future versions such as 0.10; something like > '\d[\d.]*' avoids that problem while still limiting to digits and > dots only. Done. I also adressed bug #1085746 Thanks for your time and pointers! Pieter