Groups > linux.debian.maint.python > #17128

review for ocrfeeder/0.8.5-2

Path	csiph.com!news.samoylyk.net!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Jeroen Ploemen <jcfp@debian.org>
Newsgroups	linux.debian.maint.python
Subject	review for ocrfeeder/0.8.5-2
Date	Sat, 08 Nov 2025 18:20:01 +0100
Message-ID	<LOULv-bsjf-1@gated-at.bofh.it> (permalink)
X-Original-To	plenae@disroot.org
X-Mailbox-Line	From debian-python-request@lists.debian.org Sat Nov 8 17:14:00 2025
Old-Return-Path	<jcfp@debian.org>
X-Amavis-Spam-Status	No, score=-113.51 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, GMAIL=1, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_MED=-2.3, UNPARSEABLE_RELAY=0.001, USER_IN_DKIM_WELCOMELIST=-0.01, USER_IN_DKIM_WHITELIST=-100] autolearn=ham autolearn_force=no
X-Mailer	Claws Mail 4.3.1 (GTK 3.24.33; x86_64-pc-linux-gnu)
MIME-Version	1.0
Content-Type	multipart/signed; boundary="Sig_/C/rU3Qu0yC9Kt=+jEBCuHEG"; protocol="application/pgp-signature"; micalg=pgp-sha512
X-Debian-User	jcfp
X-Mailing-List	<debian-python@lists.debian.org> archive/latest/23328
List-ID	<debian-python.lists.debian.org>
List-URL	<https://lists.debian.org/debian-python/>
List-Archive	https://lists.debian.org/msgid-search/20251108171317.0c5ee96e@debian.org
Approved	robomod@news.nic.it
Lines	65
Organization	linux.* mail to news gateway
Sender	robomod@news.nic.it
X-Original-Cc	debian-python@lists.debian.org
X-Original-Date	Sat, 8 Nov 2025 17:13:17 -0000
X-Original-Message-ID	<20251108171317.0c5ee96e@debian.org>
Xref	csiph.com linux.debian.maint.python:17128

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

hi Pieter,

I took a look at the ocrfeeder package, up for sponsorship in the
Python team:

* copyright: assorted missing entries, including:
  m4/m4_ax_python_module.m4:17:#   Copyright (c) 2008 Andrew Collier <colliera@ukzn.ac.za>
  m4/intltool.m4:2:## Copyright (C) 2001 Eazel, Inc.
  po/bs.po:2:# Copyright (c) 2013 Rosetta Contributors and Canonical Ltd 2013
  po/Makefile.in.in:2:# Copyright (C) 1995, 1996, 1997 by Ulrich Drepper <drepper@gnu.ai.mit.edu>
  po/Makefile.in.in:3:# Copyright (C) 2004-2008 Rodney Dawes <dobey.pwns@gmail.com>
  help/*/legal.xml:[...] Creative Commons Attribution-Share Alike 3.0 United States
  resources/icons/detect_icon.svg:347:           rdf:resource="http://creativecommons.org/licenses/GPL/2.0/" />
  resources/icons/detect_icon.svg:356:         rdf:about="http://creativecommons.org/licenses/GPL/2.0/">

* control: unused dependency on python3-lxml?
* control: old debhelper compat level 12 (current is 13).

* patches: newly added 'remove_gnome_autogen.patch' looks redundant;
  recent compat levels run autoreconf by default and the package
  seems to build fine without it (the .deb is identical too). The
  related override in d/rules can go as well.

* watch: regexp (\d\.\d) in the Source line is overly specific, could
  easily miss realistic future versions such as 0.10; something like
  '\d[\d.]*' avoids that problem while still limiting to digits and
  dots only.


Once the above comments have been addressed, simply re-add the
package to the IRC channel topic and/or ping me by e-mail.

Back to linux.debian.maint.python | Previous | Next — Next in thread | Find similar

Thread

review for ocrfeeder/0.8.5-2 Jeroen Ploemen <jcfp@debian.org> - 2025-11-08 18:20 +0100
  Re: review for ocrfeeder/0.8.5-2 Pieter Lenaerts <plenae@disroot.org> - 2025-11-10 19:40 +0100
    Re: review for ocrfeeder/0.8.5-2 Jeroen Ploemen <jcfp@debian.org> - 2025-11-11 15:00 +0100
      Re: review for ocrfeeder/0.8.5-2 Pieter Lenaerts <plenae@disroot.org> - 2025-11-11 16:00 +0100
        Re: review for ocrfeeder/0.8.5-2 Jeroen Ploemen <jcfp@debian.org> - 2025-11-11 17:20 +0100

csiph-web